Skip to content

Commit 071e63f

Browse files
committed
Modernize some things (#713)
* Modernize some things. * clean up * wip * wip * clean up * wip * wip
1 parent 3df41f0 commit 071e63f

29 files changed

+79
-132
lines changed

Examples/CaseStudies/CaseStudies.xcodeproj/project.pbxproj

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@
6767
DC89C41B24460F95006900B9 /* 00-RootView.swift in Sources */ = {isa = PBXBuildFile; fileRef = DC89C41A24460F95006900B9 /* 00-RootView.swift */; };
6868
DC89C41D24460F96006900B9 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = DC89C41C24460F96006900B9 /* Assets.xcassets */; };
6969
DC89C4442446111B006900B9 /* 01-GettingStarted-Counter.swift in Sources */ = {isa = PBXBuildFile; fileRef = DC89C4432446111B006900B9 /* 01-GettingStarted-Counter.swift */; };
70-
DC89C44724461431006900B9 /* ActivityIndicator.swift in Sources */ = {isa = PBXBuildFile; fileRef = DC89C44624461431006900B9 /* ActivityIndicator.swift */; };
7170
DC89C449244618D5006900B9 /* 03-Navigation-LoadThenNavigate.swift in Sources */ = {isa = PBXBuildFile; fileRef = DC89C448244618D5006900B9 /* 03-Navigation-LoadThenNavigate.swift */; };
7271
DC89C44D244621A5006900B9 /* 03-Navigation-NavigateAndLoad.swift in Sources */ = {isa = PBXBuildFile; fileRef = DC89C44C244621A5006900B9 /* 03-Navigation-NavigateAndLoad.swift */; };
7372
DC89C45124462DE7006900B9 /* 03-Navigation-Lists-LoadThenNavigate.swift in Sources */ = {isa = PBXBuildFile; fileRef = DC89C45024462DE7006900B9 /* 03-Navigation-Lists-LoadThenNavigate.swift */; };
@@ -220,7 +219,6 @@
220219
DC89C43824460FC7006900B9 /* swift-composable-architecture */ = {isa = PBXFileReference; lastKnownFileType = folder; name = "swift-composable-architecture"; path = ../..; sourceTree = "<group>"; };
221220
DC89C43924460FFF006900B9 /* README.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = README.md; sourceTree = "<group>"; };
222221
DC89C4432446111B006900B9 /* 01-GettingStarted-Counter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "01-GettingStarted-Counter.swift"; sourceTree = "<group>"; };
223-
DC89C44624461431006900B9 /* ActivityIndicator.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ActivityIndicator.swift; sourceTree = "<group>"; };
224222
DC89C448244618D5006900B9 /* 03-Navigation-LoadThenNavigate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "03-Navigation-LoadThenNavigate.swift"; sourceTree = "<group>"; };
225223
DC89C44C244621A5006900B9 /* 03-Navigation-NavigateAndLoad.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "03-Navigation-NavigateAndLoad.swift"; sourceTree = "<group>"; };
226224
DC89C45024462DE7006900B9 /* 03-Navigation-Lists-LoadThenNavigate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "03-Navigation-Lists-LoadThenNavigate.swift"; sourceTree = "<group>"; };
@@ -454,7 +452,6 @@
454452
DC89C44524461416006900B9 /* Internal */ = {
455453
isa = PBXGroup;
456454
children = (
457-
DC89C44624461431006900B9 /* ActivityIndicator.swift */,
458455
CA6AC2612451135C00C71CB3 /* CircularProgressView.swift */,
459456
DCC68EDE2447BC810037F998 /* TemplateText.swift */,
460457
DC9EB4162450CBD2005F413B /* UIViewRepresented.swift */,
@@ -751,7 +748,6 @@
751748
DCC68EDF2447BC810037F998 /* TemplateText.swift in Sources */,
752749
DCAC2A4F2452352E0094DEF5 /* 04-HigherOrderReducers-ElmLikeSubscriptions.swift in Sources */,
753750
CA6AC2672451135C00C71CB3 /* DownloadClient.swift in Sources */,
754-
DC89C44724461431006900B9 /* ActivityIndicator.swift in Sources */,
755751
CAA9ADC624465C810003A984 /* 02-Effects-Cancellation.swift in Sources */,
756752
DC2E370D24573ACB00B94699 /* 04-HigherOrderReducers-StrictReducers.swift in Sources */,
757753
CA5ECF92267A79F0002067FF /* FactClient.swift in Sources */,
@@ -962,7 +958,7 @@
962958
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
963959
BUNDLE_LOADER = "$(TEST_HOST)";
964960
CODE_SIGN_STYLE = Automatic;
965-
INFOPLIST_FILE = UIKitCaseStudiesTests/Info.plist;
961+
INFOPLIST_FILE = UIKitCaseStudies/Info.plist;
966962
LD_RUNPATH_SEARCH_PATHS = (
967963
"$(inherited)",
968964
"@executable_path/Frameworks",
@@ -982,7 +978,7 @@
982978
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
983979
BUNDLE_LOADER = "$(TEST_HOST)";
984980
CODE_SIGN_STYLE = Automatic;
985-
INFOPLIST_FILE = UIKitCaseStudiesTests/Info.plist;
981+
INFOPLIST_FILE = UIKitCaseStudies/Info.plist;
986982
LD_RUNPATH_SEARCH_PATHS = (
987983
"$(inherited)",
988984
"@executable_path/Frameworks",
@@ -1152,6 +1148,7 @@
11521148
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
11531149
BUNDLE_LOADER = "$(TEST_HOST)";
11541150
CODE_SIGN_STYLE = Automatic;
1151+
INFOPLIST_FILE = SwiftUICaseStudies/Info.plist;
11551152
LD_RUNPATH_SEARCH_PATHS = (
11561153
"$(inherited)",
11571154
"@executable_path/Frameworks",
@@ -1171,6 +1168,7 @@
11711168
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
11721169
BUNDLE_LOADER = "$(TEST_HOST)";
11731170
CODE_SIGN_STYLE = Automatic;
1171+
INFOPLIST_FILE = SwiftUICaseStudies/Info.plist;
11741172
LD_RUNPATH_SEARCH_PATHS = (
11751173
"$(inherited)",
11761174
"@executable_path/Frameworks",

Examples/CaseStudies/SwiftUICaseStudies/02-Effects-Basics.swift

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,7 @@ let effectsBasicsReducer = Reducer<
6969
// value back to the reducer's `numberFactResponse` action.
7070
return environment.fact.fetch(state.count)
7171
.observe(on: environment.mainQueue)
72-
.catchToEffect()
73-
.map(EffectsBasicsAction.numberFactResponse)
72+
.catchToEffect(EffectsBasicsAction.numberFactResponse)
7473

7574
case let .numberFactResponse(.success(response)):
7675
state.isNumberFactRequestInFlight = false
@@ -112,7 +111,7 @@ struct EffectsBasicsView: View {
112111

113112
Button("Number fact") { viewStore.send(.numberFactButtonTapped) }
114113
if viewStore.isNumberFactRequestInFlight {
115-
ActivityIndicator()
114+
ProgressView()
116115
}
117116

118117
viewStore.numberFact.map(Text.init)

Examples/CaseStudies/SwiftUICaseStudies/02-Effects-Cancellation.swift

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,7 @@ let effectsCancellationReducer = Reducer<
5959

6060
return environment.fact.fetch(state.count)
6161
.observe(on: environment.mainQueue)
62-
.catchToEffect()
63-
.map(EffectsCancellationAction.triviaResponse)
62+
.catchToEffect(EffectsCancellationAction.triviaResponse)
6463
.cancellable(id: TriviaRequestId())
6564

6665
case let .triviaResponse(.success(response)):
@@ -99,7 +98,7 @@ struct EffectsCancellationView: View {
9998
HStack {
10099
Button("Cancel") { viewStore.send(.cancelButtonTapped) }
101100
Spacer()
102-
ActivityIndicator()
101+
ProgressView()
103102
}
104103
} else {
105104
Button("Number fact") { viewStore.send(.triviaButtonTapped) }

Examples/CaseStudies/SwiftUICaseStudies/02-Effects-Refreshable.swift

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,7 @@ let refreshableReducer = Reducer<
6767
state.isLoading = true
6868
return environment.fact.fetch(state.count)
6969
.delay(2, on: environment.mainQueue.animation())
70-
.catchToEffect()
71-
.map(RefreshableAction.factResponse)
70+
.catchToEffect(RefreshableAction.factResponse)
7271
.cancellable(id: CancelId())
7372
}
7473
}
@@ -100,7 +99,7 @@ let refreshableReducer = Reducer<
10099
}
101100
}
102101
.refreshable {
103-
await viewStore.send(.refresh, while: \.isLoading)
102+
await viewStore.send(.refresh, while: \.isLoading)
104103
}
105104
}
106105
}

Examples/CaseStudies/SwiftUICaseStudies/02-Effects-WebSocket.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ let webSocketReducer = Reducer<WebSocketState, WebSocketAction, WebSocketEnviron
4646
var receiveSocketMessageEffect: Effect<WebSocketAction, Never> {
4747
return environment.webSocket.receive(WebSocketId())
4848
.observe(on: environment.mainQueue)
49-
.catchToEffect()
50-
.map(WebSocketAction.receivedSocketMessage)
49+
.catchToEffect(WebSocketAction.receivedSocketMessage)
5150
.cancellable(id: WebSocketId())
5251
}
5352
var sendPingEffect: Effect<WebSocketAction, Never> {

Examples/CaseStudies/SwiftUICaseStudies/03-Effects-SystemEnvironment.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ struct MultipleDependenciesView: View {
123123
Spacer()
124124

125125
if viewStore.isFetchInFlight {
126-
ActivityIndicator()
126+
ProgressView()
127127
}
128128
}
129129
}

Examples/CaseStudies/SwiftUICaseStudies/03-Navigation-Lists-LoadThenNavigate.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ struct LoadThenNavigateListView: View {
111111
Text("Load optional counter that starts from \(row.count)")
112112
if row.isActivityIndicatorVisible {
113113
Spacer()
114-
ActivityIndicator()
114+
ProgressView()
115115
}
116116
}
117117
}

Examples/CaseStudies/SwiftUICaseStudies/03-Navigation-Lists-NavigateAndLoad.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ struct NavigateAndLoadListView: View {
9191
action: NavigateAndLoadListAction.counter
9292
),
9393
then: CounterView.init(store:),
94-
else: { ActivityIndicator() }
94+
else: ProgressView.init
9595
),
9696
tag: row.id,
9797
selection: viewStore.binding(

Examples/CaseStudies/SwiftUICaseStudies/03-Navigation-LoadThenNavigate.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ struct LoadThenNavigateView: View {
8484
Text("Load optional counter")
8585
if viewStore.isActivityIndicatorVisible {
8686
Spacer()
87-
ActivityIndicator()
87+
ProgressView()
8888
}
8989
}
9090
}

Examples/CaseStudies/SwiftUICaseStudies/03-Navigation-NavigateAndLoad.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ struct NavigateAndLoadView: View {
7373
action: NavigateAndLoadAction.optionalCounter
7474
),
7575
then: CounterView.init(store:),
76-
else: { ActivityIndicator() }
76+
else: ProgressView.init
7777
),
7878
isActive: viewStore.binding(
7979
get: \.isNavigationActive,

0 commit comments

Comments
 (0)