Fix tests in Xcode 14. (#1135)

* Fix tests in Xcode 14.

* wip

* Update download example with proper cancel button.

Author: mluisbrown

Examples/CaseStudies/SwiftUICaseStudies/04-HigherOrderReducers-ResuableOfflineDownloads/DownloadComponent.swift

@@ -36,10 +36,10 @@ enum DownloadComponentAction: Equatable {
   case downloadClient(Result<DownloadClient.Action, DownloadClient.Error>)
 
   enum AlertAction: Equatable {
-    case cancelButtonTapped
     case deleteButtonTapped
     case dismiss
     case nevermindButtonTapped
+    case stopButtonTapped
   }
 }
 
@@ -58,11 +58,6 @@ extension Reducer {
       Reducer<DownloadComponentState<ID>, DownloadComponentAction, DownloadComponentEnvironment> {
         state, action, environment in
         switch action {
-        case .alert(.cancelButtonTapped):
-          state.mode = .notDownloaded
-          state.alert = nil
-          return .cancel(id: state.id)
-
         case .alert(.deleteButtonTapped):
           state.alert = nil
           state.mode = .notDownloaded
@@ -73,14 +68,19 @@ extension Reducer {
           state.alert = nil
           return .none
 
+        case .alert(.stopButtonTapped):
+          state.mode = .notDownloaded
+          state.alert = nil
+          return .cancel(id: state.id)
+
         case .buttonTapped:
           switch state.mode {
           case .downloaded:
             state.alert = deleteAlert
             return .none
 
           case .downloading:
-            state.alert = cancelAlert
+            state.alert = stopAlert
             return .none
 
           case .notDownloaded:
@@ -92,7 +92,7 @@ extension Reducer {
               .cancellable(id: state.id)
 
           case .startingToDownload:
-            state.alert = cancelAlert
+            state.alert = stopAlert
             return .none
           }
 
@@ -123,14 +123,14 @@ private let deleteAlert = AlertState(
   secondaryButton: nevermindButton
 )
 
-private let cancelAlert = AlertState(
-  title: .init("Do you want to cancel downloading this map?"),
-  primaryButton: .destructive(.init("Cancel"), action: .send(.cancelButtonTapped)),
+private let stopAlert = AlertState(
+  title: .init("Do you want to stop downloading this map?"),
+  primaryButton: .destructive(.init("Stop"), action: .send(.stopButtonTapped)),
   secondaryButton: nevermindButton
 )
 
 let nevermindButton = AlertState<DownloadComponentAction.AlertAction>.Button
-  .default(.init("Nevermind"), action: .send(.nevermindButtonTapped))
+  .cancel(.init("Nevermind"), action: .send(.nevermindButtonTapped))
 
 struct DownloadComponent<ID: Equatable>: View {
   let store: Store<DownloadComponentState<ID>, DownloadComponentAction>

Examples/CaseStudies/SwiftUICaseStudiesTests/04-HigherOrderReducers-ReusableOfflineDownloadsTests.swift

@@ -116,13 +116,13 @@ class ReusableComponentsDownloadComponentTests: XCTestCase {
 
     store.send(.buttonTapped) {
       $0.alert = .init(
-        title: .init("Do you want to cancel downloading this map?"),
-        primaryButton: .destructive(.init("Cancel"), action: .send(.cancelButtonTapped)),
-        secondaryButton: .default(.init("Nevermind"), action: .send(.nevermindButtonTapped))
+        title: .init("Do you want to stop downloading this map?"),
+        primaryButton: .destructive(.init("Stop"), action: .send(.stopButtonTapped)),
+        secondaryButton: .cancel(.init("Nevermind"), action: .send(.nevermindButtonTapped))
       )
     }
 
-    store.send(.alert(.cancelButtonTapped)) {
+    store.send(.alert(.stopButtonTapped)) {
       $0.alert = nil
       $0.mode = .notDownloaded
     }
@@ -153,9 +153,9 @@ class ReusableComponentsDownloadComponentTests: XCTestCase {
 
     store.send(.buttonTapped) {
       $0.alert = .init(
-        title: .init("Do you want to cancel downloading this map?"),
-        primaryButton: .destructive(.init("Cancel"), action: .send(.cancelButtonTapped)),
-        secondaryButton: .default(.init("Nevermind"), action: .send(.nevermindButtonTapped))
+        title: .init("Do you want to stop downloading this map?"),
+        primaryButton: .destructive(.init("Stop"), action: .send(.stopButtonTapped)),
+        secondaryButton: .cancel(.init("Nevermind"), action: .send(.nevermindButtonTapped))
       )
     }
 
@@ -190,7 +190,7 @@ class ReusableComponentsDownloadComponentTests: XCTestCase {
       $0.alert = .init(
         title: .init("Do you want to delete this map from your offline storage?"),
         primaryButton: .destructive(.init("Delete"), action: .send(.deleteButtonTapped)),
-        secondaryButton: .default(.init("Nevermind"), action: .send(.nevermindButtonTapped))
+        secondaryButton: .cancel(.init("Nevermind"), action: .send(.nevermindButtonTapped))
       )
     }
 

Tests/ComposableArchitectureTests/EffectTests.swift

@@ -200,7 +200,7 @@ final class EffectTests: XCTestCase {
     func testTask() {
       let expectation = self.expectation(description: "Complete")
       var result: Int?
-      Effect<Int, Never>.task {
+      Effect<Int, Never>.task { @MainActor in
         expectation.fulfill()
         return 42
       }
@@ -213,7 +213,7 @@ final class EffectTests: XCTestCase {
       let expectation = self.expectation(description: "Complete")
       struct MyError: Error {}
       var result: Error?
-      let disposable = Effect<Int, Error>.task {
+      let disposable = Effect<Int, Error>.task { @MainActor in
         expectation.fulfill()
         throw MyError()
       }