Use modify helper in Tic-Tac-Toe integration test (#687)

* Use `modify` helper

* Clean up breakpoint warnings

Author: stephencelis

Examples/TicTacToe/tic-tac-toe/Tests/AppCoreTests/AppCoreTests.swift

@@ -19,18 +19,18 @@ class AppCoreTests: XCTestCase {
     )
 
     store.send(.login(.emailChanged("[email protected]"))) {
-      try (/AppState.login).update(&$0) {
+      try (/AppState.login).modify(&$0) {
         $0.email = "[email protected]"
       }
     }
     store.send(.login(.passwordChanged("bl0bbl0b"))) {
-      try (/AppState.login).update(&$0) {
+      try (/AppState.login).modify(&$0) {
         $0.password = "bl0bbl0b"
         $0.isFormValid = true
       }
     }
     store.send(.login(.loginButtonTapped)) {
-      try (/AppState.login).update(&$0) {
+      try (/AppState.login).modify(&$0) {
         $0.isLoginRequestInFlight = true
       }
     }
@@ -40,7 +40,7 @@ class AppCoreTests: XCTestCase {
       $0 = .newGame(.init())
     }
     store.send(.newGame(.oPlayerNameChanged("Blob Sr."))) {
-      try (/AppState.newGame).update(&$0) {
+      try (/AppState.newGame).modify(&$0) {
         $0.oPlayerName = "Blob Sr."
       }
     }
@@ -67,41 +67,41 @@ class AppCoreTests: XCTestCase {
     )
 
     store.send(.login(.emailChanged("[email protected]"))) {
-      try (/AppState.login).update(&$0) {
+      try (/AppState.login).modify(&$0) {
         $0.email = "[email protected]"
       }
     }
 
     store.send(.login(.passwordChanged("bl0bbl0b"))) {
-      try (/AppState.login).update(&$0) {
+      try (/AppState.login).modify(&$0) {
         $0.password = "bl0bbl0b"
         $0.isFormValid = true
       }
     }
 
     store.send(.login(.loginButtonTapped)) {
-      try (/AppState.login).update(&$0) {
+      try (/AppState.login).modify(&$0) {
         $0.isLoginRequestInFlight = true
       }
     }
     store.receive(
       .login(.loginResponse(.success(.init(token: "deadbeef", twoFactorRequired: true))))
     ) {
-      try (/AppState.login).update(&$0) {
+      try (/AppState.login).modify(&$0) {
         $0.isLoginRequestInFlight = false
         $0.twoFactor = .init(token: "deadbeef")
       }
     }
 
     store.send(.login(.twoFactor(.codeChanged("1234")))) {
-      try (/AppState.login).update(&$0) {
+      try (/AppState.login).modify(&$0) {
         $0.twoFactor?.code = "1234"
         $0.twoFactor?.isFormValid = true
       }
     }
 
     store.send(.login(.twoFactor(.submitButtonTapped))) {
-      try (/AppState.login).update(&$0) {
+      try (/AppState.login).modify(&$0) {
         $0.twoFactor?.isTwoFactorRequestInFlight = true
       }
     }
@@ -114,11 +114,3 @@ class AppCoreTests: XCTestCase {
     }
   }
 }
-
-extension CasePath {
-  func update(_ root: inout Root, perform: (inout Value) throws -> Void) throws {
-    var value = try XCTUnwrap(self.extract(from: root))
-    try perform(&value)
-    root = self.embed(value)
-  }
-}

Sources/ComposableArchitecture/Reducer.swift

@@ -486,12 +486,12 @@ public struct Reducer<State, Action, Environment> {
             This ensures that case-specific reducers can handle their actions while their state \
             is available.
 
-            * An in-flight effect emitted this action when state was unavailable. While it may \
-            be perfectly reasonable to ignore this action, you may want to cancel the associated \
+            * An in-flight effect emitted this action when state was unavailable. While it may be \
+            perfectly reasonable to ignore this action, you may want to cancel the associated \
             effect before state is set to another case, especially if it is a long-living effect.
 
             * This action was sent to the store while state was another case. Make sure that \
-            actions for this reducer can only be sent to a view store when state is non-"nil".
+            actions for this reducer can only be sent to a view store when state is non-"nil". \
             In SwiftUI applications, use "SwitchStore".
             ---
             """
@@ -691,16 +691,16 @@ public struct Reducer<State, Action, Environment> {
 
             * The optional reducer was combined with or run from another reducer that set \
             "\(State.self)" to "nil" before the optional reducer ran. Combine or run optional \
-            reducers before reducers that can set their state to "nil". This ensures that \
-            optional reducers can handle their actions while their state is still non-"nil".
+            reducers before reducers that can set their state to "nil". This ensures that optional \
+            reducers can handle their actions while their state is still non-"nil".
 
             * An in-flight effect emitted this action while state was "nil". While it may be \
             perfectly reasonable to ignore this action, you may want to cancel the associated \
             effect before state is set to "nil", especially if it is a long-living effect.
 
-            * This action was sent to the store while state was "nil". Make sure that actions \
-            for this reducer can only be sent to a view store when state is non-"nil". In \
-            SwiftUI applications, use "IfLetStore".
+            * This action was sent to the store while state was "nil". Make sure that actions for \
+            this reducer can only be sent to a view store when state is non-"nil". In SwiftUI \
+            applications, use "IfLetStore".
             ---
             """
           )
@@ -771,20 +771,20 @@ public struct Reducer<State, Action, Environment> {
             ---
             Warning: Reducer.forEach@\(file):\(line)
 
-            "\(debugCaseOutput(localAction))" was received by a "forEach" reducer at id \(id) \
-            when its state contained no element at this id. This is generally considered an \
-            application logic error, and can happen for a few reasons:
+            "\(debugCaseOutput(localAction))" was received by a "forEach" reducer at id \(id) when \
+            its state contained no element at this id. This is generally considered an application \
+            logic error, and can happen for a few reasons:
 
             * This "forEach" reducer was combined with or run from another reducer that removed \
             the element at this id when it handled this action. To fix this make sure that this \
             "forEach" reducer is run before any other reducers that can move or remove elements \
             from state. This ensures that "forEach" reducers can handle their actions for the \
             element at the intended id.
 
-            * An in-flight effect emitted this action while state contained no element at this \
-            id. It may be perfectly reasonable to ignore this action, but you also may want to \
-            cancel the effect it originated from when removing an element from the identified \
-            array, especially if it is a long-living effect.
+            * An in-flight effect emitted this action while state contained no element at this id. \
+            It may be perfectly reasonable to ignore this action, but you also may want to cancel \
+            the effect it originated from when removing an element from the identified array, \
+            especially if it is a long-living effect.
 
             * This action was sent to the store while its state contained no element at this id. \
             To fix this make sure that actions for this reducer can only be sent to a view store \