Sync latest changes from swift-composable-architecture (#33)

* Fix Binding animations (#338)

* Replace deprecated optional with optional() (#339)

* Only include actions in TestStore debug output (#342)

* Add `Scene` conformance to `WithViewStore` (#336)

* Add SceneWithViewStore for accessing stores in scenes

 This would allow accessing `ViewStore` instances from a `body` definition of a type conforming to `Scene`. It could be useful for conditional rendering of scenes or sending actions from scene commands. Here's an example:

```swift
 import ComposableArchitecture
 import SwiftUI

@main
 struct CommandsApp: App {
  private let store = Store(
    initialState: RootState(),
    reducer: rootReducer,
    environment: .live(rootEnvironment)
  )

  var body: some Scene {
    SceneWithViewStore(store) { viewStore in
      WindowGroup {
        WorkspaceView()
      }.commands {
        CommandGroup(after: CommandGroupPlacement.newItem) {
          Button("Open...") {
            viewStore.send(.open)
          }.keyboardShortcut("o", modifiers: [.command])
        }
      }
    }
  }
}
```

* Avoid building SceneWithViewStore with old Xcode

* Separate Catalina and Big Sur jobs

 This allows testing APIs that are only available on Big Sur

* Unify `WithViewStore` and `SceneWithViewStore`

* Format and coverage

* Update Reducer.swift (#332)

* Remove LocationManager and MotionManager examples from README (#319)

* Fix Tests (#343)

* Fix tests

* fix

* Direct people to GH discussions instead of Swift forums (#348)

* Direct people to GH discussions instead of Swift forums

How do you feel about this?

* Update README.md

Co-authored-by: Stephen Celis <[email protected]>

* Update README.md

Co-authored-by: Stephen Celis <[email protected]>

* Update issue template to mention GH discussions. (#358)

* Add TextState (for AlertState, ActionSheetState, etc.) (#359)

* Use SwiftUI.Text with {Alert,ActionSheet}State

Fix #293, #318.

* Use public interface

* Availability

* TextState

* Note

* Simplify

* Update LocalizedStringTests.swift

* Fix warnings

* Fix docs

* Fix availability annotations.

* Re-publicize `AlertState.Button.type` (#361)

* Re-publicize `AlertState.Button.type`

* Update Alert.swift

* Simplify UIKit list case study (#365)

Suggestion from @ryanbooker: pointfreeco/swift-composable-architecture#351

* Disable Big Sur tests - too flaky right now.

* - Use Xcode 12.3 for CI
- Remove #if nesting in WithViewStore.swift

* Fix typo.

Co-authored-by: Stephen Celis <[email protected]>
Co-authored-by: Jans Pavlovs <[email protected]>
Co-authored-by: Brandon Williams <[email protected]>

Author: 4 people

.github/ISSUE_TEMPLATE/question.md

@@ -7,4 +7,4 @@ assignees: ''
 
 ---
 
-The Composable Architecture uses GitHub issues for bugs. For more general discussion and help, please use [the Swift forum](https://forums.swift.org/c/related-projects/swift-composable-architecture) first.
+The Composable Architecture uses GitHub issues for bugs. For more general discussion and help, please use [GitHub Discussions](https://github.com/pointfreeco/swift-composable-architecture/discussions) or [the Swift forum](https://forums.swift.org/c/related-projects/swift-composable-architecture) first.

.github/workflows/ci.yml

@@ -10,19 +10,33 @@ on:
 
 jobs:
   library:
-    runs-on: macOS-latest
+    runs-on: macos-10.15
     strategy:
       matrix:
         xcode:
           - 11.7
-          - 12.0
+          - 12.3
     steps:
       - uses: actions/checkout@v2
       - name: Select Xcode ${{ matrix.xcode }}
         run: sudo xcode-select -s /Applications/Xcode_${{ matrix.xcode }}.app
       - name: Run tests
         run: make test
 
+  # NB: GitHub's Big Sur instances are super flaky. We should revisit later.
+  # bigsur-tests:
+  #   runs-on: macos-11.0
+  #   strategy:
+  #     matrix:
+  #       xcode:
+  #         - 12.3
+  #   steps:
+  #     - uses: actions/checkout@v2
+  #     - name: Select Xcode ${{ matrix.xcode }}
+  #       run: sudo xcode-select -s /Applications/Xcode_${{ matrix.xcode }}.app
+  #     - name: Run tests
+  #       run: make test
+
   swiftpm-linux:
     name: SwiftPM Linux
     runs-on: ubuntu-18.04

Examples/CaseStudies/SwiftUICaseStudies/01-GettingStarted-AlertsAndActionSheets.swift

@@ -44,12 +44,12 @@ let alertAndSheetReducer = Reducer<
   switch action {
   case .actionSheetButtonTapped:
     state.actionSheet = .init(
-      title: "Action sheet",
-      message: "This is an action sheet.",
+      title: .init("Action sheet"),
+      message: .init("This is an action sheet."),
       buttons: [
         .cancel(),
-        .default("Increment", send: .incrementButtonTapped),
-        .default("Decrement", send: .decrementButtonTapped),
+        .default(.init("Increment"), send: .incrementButtonTapped),
+        .default(.init("Decrement"), send: .decrementButtonTapped),
       ]
     )
     return .none
@@ -63,10 +63,10 @@ let alertAndSheetReducer = Reducer<
 
   case .alertButtonTapped:
     state.alert = .init(
-      title: "Alert!",
-      message: "This is an alert",
+      title: .init("Alert!"),
+      message: .init("This is an alert"),
       primaryButton: .cancel(),
-      secondaryButton: .default("Increment", send: .incrementButtonTapped)
+      secondaryButton: .default(.init("Increment"), send: .incrementButtonTapped)
     )
     return .none
 
@@ -78,12 +78,12 @@ let alertAndSheetReducer = Reducer<
     return .none
 
   case .decrementButtonTapped:
-    state.alert = .init(title: "Decremented!")
+    state.alert = .init(title: .init("Decremented!"))
     state.count -= 1
     return .none
 
   case .incrementButtonTapped:
-    state.alert = .init(title: "Incremented!")
+    state.alert = .init(title: .init("Incremented!"))
     state.count += 1
     return .none
   }

Examples/CaseStudies/SwiftUICaseStudies/01-GettingStarted-SharedState.swift

@@ -107,8 +107,8 @@ let sharedStateCounterReducer = Reducer<
   case .isPrimeButtonTapped:
     state.alert = .init(
       title: isPrime(state.count)
-        ? "👍 The number \(state.count) is prime!"
-        : "👎 The number \(state.count) is not prime :("
+        ? .init("👍 The number \(state.count) is prime!")
+        : .init("👎 The number \(state.count) is not prime :(")
     )
     return .none
   }

Examples/CaseStudies/SwiftUICaseStudies/02-Effects-WebSocket.swift

@@ -106,7 +106,7 @@ let webSocketReducer = Reducer<WebSocketState, WebSocketAction, WebSocketEnviron
 
   case let .sendResponse(error):
     if error != nil {
-      state.alert = .init(title: "Could not send socket message. Try again.")
+      state.alert = .init(title: .init("Could not send socket message. Try again."))
     }
     return .none
 
@@ -118,7 +118,7 @@ let webSocketReducer = Reducer<WebSocketState, WebSocketAction, WebSocketEnviron
     let .webSocket(.didCompleteWithError(error)):
     state.connectivityState = .disconnected
     if error != nil {
-      state.alert = .init(title: "Disconnected from socket for some reason. Try again.")
+      state.alert = .init(title: .init("Disconnected from socket for some reason. Try again."))
     }
     return .cancel(id: WebSocketId())
 

Examples/CaseStudies/SwiftUICaseStudies/03-Effects-SystemEnvironment.swift

@@ -50,7 +50,7 @@ let multipleDependenciesReducer = Reducer<
       .delay(1, on: environment.mainQueue())
 
   case .alertDelayReceived:
-    state.alert = .init(title: "Here's an alert after a delay!")
+    state.alert = .init(title: .init("Here's an alert after a delay!"))
     return .none
 
   case .alertDismissed:

Examples/CaseStudies/SwiftUICaseStudies/04-HigherOrderReducers-ResuableOfflineDownloads/DownloadComponent.swift

@@ -119,19 +119,19 @@ extension Reducer {
 }
 
 private let deleteAlert = AlertState(
-  title: "Do you want to delete this map from your offline storage?",
-  primaryButton: .destructive("Delete", send: .deleteButtonTapped),
+  title: .init("Do you want to delete this map from your offline storage?"),
+  primaryButton: .destructive(.init("Delete"), send: .deleteButtonTapped),
   secondaryButton: nevermindButton
 )
 
 private let cancelAlert = AlertState(
-  title: "Do you want to cancel downloading this map?",
-  primaryButton: .destructive("Cancel", send: .cancelButtonTapped),
+  title: .init("Do you want to cancel downloading this map?"),
+  primaryButton: .destructive(.init("Cancel"), send: .cancelButtonTapped),
   secondaryButton: nevermindButton
 )
 
 let nevermindButton = AlertState<DownloadComponentAction.AlertAction>.Button
-  .default("Nevermind", send: .nevermindButtonTapped)
+  .default(.init("Nevermind"), send: .nevermindButtonTapped)
 
 struct DownloadComponent<ID: Equatable>: View {
   let store: Store<DownloadComponentState<ID>, DownloadComponentAction>

Examples/CaseStudies/SwiftUICaseStudies/04-HigherOrderReducers-ReusableFavoriting.swift

@@ -79,7 +79,7 @@ extension Reducer {
             .cancellable(id: FavoriteCancelId(id: state.id), cancelInFlight: true)
 
         case let .response(.failure(error)):
-          state.alert = .init(title: .init(error.localizedDescription))
+          state.alert = .init(title: TextState(error.localizedDescription))
           return .none
 
         case let .response(.success(isFavorite)):

Examples/CaseStudies/SwiftUICaseStudiesTests/01-GettingStarted-AlertsAndActionSheetsTests.swift

@@ -16,14 +16,14 @@ class AlertsAndActionSheetsTests: XCTestCase {
     store.assert(
       .send(.alertButtonTapped) {
         $0.alert = .init(
-          title: "Alert!",
-          message: "This is an alert",
+          title: .init("Alert!"),
+          message: .init("This is an alert"),
           primaryButton: .cancel(),
-          secondaryButton: .default("Increment", send: .incrementButtonTapped)
+          secondaryButton: .default(.init("Increment"), send: .incrementButtonTapped)
         )
       },
       .send(.incrementButtonTapped) {
-        $0.alert = .init(title: "Incremented!")
+        $0.alert = .init(title: .init("Incremented!"))
         $0.count = 1
       },
       .send(.alertDismissed) {
@@ -42,17 +42,17 @@ class AlertsAndActionSheetsTests: XCTestCase {
     store.assert(
       .send(.actionSheetButtonTapped) {
         $0.actionSheet = .init(
-          title: "Action sheet",
-          message: "This is an action sheet.",
+          title: .init("Action sheet"),
+          message: .init("This is an action sheet."),
           buttons: [
             .cancel(),
-            .default("Increment", send: .incrementButtonTapped),
-            .default("Decrement", send: .decrementButtonTapped),
+            .default(.init("Increment"), send: .incrementButtonTapped),
+            .default(.init("Decrement"), send: .decrementButtonTapped),
           ]
         )
       },
       .send(.incrementButtonTapped) {
-        $0.alert = .init(title: "Incremented!")
+        $0.alert = .init(title: .init("Incremented!"))
         $0.count = 1
       },
       .send(.actionSheetDismissed) {

Examples/CaseStudies/SwiftUICaseStudiesTests/01-GettingStarted-SharedStateTests.swift

@@ -80,7 +80,7 @@ class SharedStateTests: XCTestCase {
     store.assert(
       .send(.isPrimeButtonTapped) {
         $0.alert = .init(
-          title: "👍 The number \($0.count) is prime!"
+          title: .init("👍 The number \($0.count) is prime!")
         )
       },
       .send(.alertDismissed) {
@@ -100,7 +100,7 @@ class SharedStateTests: XCTestCase {
     store.assert(
       .send(.isPrimeButtonTapped) {
         $0.alert = .init(
-          title: "👎 The number \($0.count) is not prime :("
+          title: .init("👎 The number \($0.count) is not prime :(")
         )
       },
       .send(.alertDismissed) {