Add support for SwiftUI withTransaction API (#1824)

* Adds withTransaction extension

* reduce code

* fix typo

* Adds transaction support to Send and ViewStore.send

* Update Sources/ComposableArchitecture/Effect.swift

* Update Sources/ComposableArchitecture/ViewStore.swift

Co-authored-by: Stephen Celis <[email protected]>
(cherry picked from commit b4e6e83c982fd715fd9049de205c46f91501fa1d)

# Conflicts:
#	Sources/ComposableArchitecture/Effect.swift
#	Sources/ComposableArchitecture/Effects/Animation.swift

Author: drucelweisse

Sources/ComposableArchitecture/Effect.swift

@@ -379,8 +379,17 @@ public struct Send<Action> {
   ///   - action: An action.
   ///   - animation: An animation.
   public func callAsFunction(_ action: Action, animation: Animation?) {
+    callAsFunction(action, transaction: Transaction(animation: animation))
+  }
+    
+    /// Sends an action back into the system from an effect with transaction.
+    ///
+    /// - Parameters:
+    ///   - action: An action.
+    ///   - transaction: A transaction.
+    public func callAsFunction(_ action: Action, transaction: Transaction) {
     guard !Task.isCancelled else { return }
-    withAnimation(animation) {
+      withTransaction(transaction) {
       self(action)
     }
   }

Sources/ComposableArchitecture/Effects/Animation.swift

@@ -1,32 +1,50 @@
 #if canImport(SwiftUI)
   import ReactiveSwift
-  import SwiftUI
+import SwiftUI
 
   extension EffectProducer {
-    /// Wraps the emission of each element with SwiftUI's `withAnimation`.
-    ///
-    /// ```swift
-    /// case .buttonTapped:
-    ///   return .task {
-    ///     .activityResponse(await self.apiClient.fetchActivity())
-    ///   }
-    ///   .animation()
-    /// ```
-    ///
-    /// - Parameter animation: An animation.
+  /// Wraps the emission of each element with SwiftUI's `withAnimation`.
+  ///
+  /// ```swift
+  /// case .buttonTapped:
+  ///   return .task {
+  ///     .activityResponse(await self.apiClient.fetchActivity())
+  ///   }
+  ///   .animation()
+  /// ```
+  ///
+  /// - Parameter animation: An animation.
     /// - Returns: An effect.
-    public func animation(_ animation: Animation? = .default) -> Self {
-      switch self.operation {
-      case .none:
-        return .none
+  public func animation(_ animation: Animation? = .default) -> Self {
+    self.transaction(Transaction(animation: animation))
+  }
+    
+  /// Wraps the emission of each element with SwiftUI's `withTransaction`.
+  ///
+  /// ```swift
+  /// case .buttonTapped:
+  ///   var transaction = Transaction(animation: .default)
+  ///   transaction.disablesAnimations = true
+  ///   return .task {
+  ///     .activityResponse(await self.apiClient.fetchActivity())
+  ///   }
+  ///   .transaction(transaction)
+  /// ```
+  ///
+  /// - Parameter transaction: A transaction.
+  /// - Returns: A publisher.
+  public func transaction(_ transaction: Transaction) -> Self {
+    switch self.operation {
+    case .none:
+      return .none
       case let .producer(producer):
-        return Self(
+      return Self(
           operation: .producer(
             SignalProducer<Action, Failure> { observer, _ in
               producer.start { action in
                 switch action {
                 case let .value(value):
-                  withAnimation(animation) {
+                  withTransaction(transaction) {
                     observer.send(value: value)
                   }
                 case .completed:
@@ -38,21 +56,21 @@
                 }
               }
             }
-          )
         )
-      case let .run(priority, operation):
-        return Self(
-          operation: .run(priority) { send in
-            await operation(
-              Send { value in
-                withAnimation(animation) {
-                  send(value)
-                }
+      )
+    case let .run(priority, operation):
+      return Self(
+        operation: .run(priority) { send in
+          await operation(
+            Send { value in
+              withTransaction(transaction) {
+                send(value)
               }
-            )
-          }
-        )
-      }
+            }
+          )
+        }
+      )
     }
   }
+}
 #endif

Sources/ComposableArchitecture/ViewStore.swift

@@ -306,7 +306,19 @@ public final class ViewStore<ViewState, ViewAction> {
   ///   - animation: An animation.
   @discardableResult
   public func send(_ action: ViewAction, animation: Animation?) -> ViewStoreTask {
-    withAnimation(animation) {
+    send(action, transaction: Transaction(animation: animation))
+  }
+    
+  /// Sends an action to the store with a given transaction.
+  ///
+  /// See ``ViewStore/send(_:)`` for more info.
+  ///
+  /// - Parameters:
+  ///   - action: An action.
+  ///   - transaction: A transaction.
+  @discardableResult
+  public func send(_ action: ViewAction, transaction: Transaction) -> ViewStoreTask {
+    withTransaction(transaction) {
       self.send(action)
     }
   }