Rename ViewStore.suspend(while:) to yield(while:) (#1151)

The naming of `ViewStore.suspend(while:)` was inspired by
`Task.suspend()`, which was deprecated and renamed to `Task.yield()`
long ago. Let's do the same here and call it `ViewStore.yield(while:)`.

Author: mluisbrown

Sources/ComposableArchitecture/Internal/Deprecations.swift

@@ -9,6 +9,15 @@ import SwiftUI
   import os
 #endif
 
+// NB: Deprecated after 0.36.0:
+
+extension ViewStore {
+  @available(*, deprecated, renamed: "yield(while:)")
+  public func suspend(while predicate: @escaping (State) -> Bool) async {
+    await self.yield(while: predicate)
+  }
+}
+
 // NB: Deprecated after 0.34.0:
 
 extension Effect {

Sources/ComposableArchitecture/ViewStore.swift

@@ -453,7 +453,7 @@ private struct HashableWrapper<Value>: Hashable {
       while predicate: @escaping (State) -> Bool
     ) async {
       self.send(action)
-      await self.suspend(while: predicate)
+      await self.yield(while: predicate)
     }
 
     #if canImport(SwiftUI)
@@ -472,15 +472,18 @@ private struct HashableWrapper<Value>: Hashable {
       while predicate: @escaping (State) -> Bool
     ) async {
       withAnimation(animation) { self.send(action) }
-      await self.suspend(while: predicate)
+      await self.yield(while: predicate)
     }
     #endif
 
-    /// Suspends while a predicate on state is `true`.
+    /// Suspends the current task while a predicate on state is `true`.
+    ///
+    /// If you want to suspend at the same time you send an action to the view store, use
+    /// ``send(_:while:)``.
     ///
     /// - Parameter predicate: A predicate on `State` that determines for how long this method
     ///   should suspend.
-    public func suspend(while predicate: @escaping (State) -> Bool) async {
+    public func yield(while predicate: @escaping (State) -> Bool) async {
       let cancellable = Box<Disposable?>(wrappedValue: nil)
         try? await withTaskCancellationHandler(
         handler: { cancellable.wrappedValue?.dispose() },

Tests/ComposableArchitectureTests/ViewStoreTests.swift

@@ -227,7 +227,7 @@ final class ViewStoreTests: XCTestCase {
         XCTAssertNoDifference(viewStore.state, false)
         viewStore.send(.tapped)
         XCTAssertNoDifference(viewStore.state, true)
-        await viewStore.suspend(while: { $0 })
+        await viewStore.yield(while: { $0 })
         XCTAssertNoDifference(viewStore.state, false)
         expectation.fulfill()
       }