Force Effect.{debounce,deferred} through publisher (#1326)

* Force `Effect.{debounce,deferred}` through publisher

Because publishers can be animated, we should force these helpers
through our publisher endpoints, otherwise our next release could break
animated schedulers.

* wip

Co-authored-by: Brandon Williams <[email protected]>
(cherry picked from commit 41b39f117103d79f4848b62ceb8999df7d4fe283)

# Conflicts:
#	Sources/ComposableArchitecture/Effects/Debouncing.swift
#	Sources/ComposableArchitecture/Effects/Deferring.swift
#	Sources/ComposableArchitecture/Effects/Timer.swift

Author: stephencelis

Sources/ComposableArchitecture/Effects/Debouncing.swift

@@ -32,13 +32,13 @@ extension Effect {
     switch self.operation {
     case .none:
       return .none
-    case let .producer(producer):
+    case .producer:
       return Self(
         operation: .producer(
           SignalProducer<Void, Never>.init(value: ())
             .promoteError(Failure.self)
             .delay(dueTime, on: scheduler)
-            .flatMap(.latest) { producer.observe(on: scheduler) }
+            .flatMap(.latest) { self.producer.observe(on: scheduler) }
         )
       )
       .cancellable(id: id, cancelInFlight: true)
@@ -48,7 +48,13 @@ extension Effect {
           await withTaskCancellation(id: id, cancelInFlight: true) {
             do {
               try await scheduler.sleep(for: .nanoseconds(Int(dueTime * TimeInterval(NSEC_PER_SEC))))
-              await operation(send)
+              await operation(
+                Send { output in
+                  scheduler.schedule {
+                    send(output)
+                  }
+                }
+              )
             } catch {}
           }
         }

Sources/ComposableArchitecture/Effects/Deferring.swift

@@ -16,27 +16,39 @@ extension Effect {
   ///   - scheduler: The scheduler you want to deliver the defer output to.
   ///   - options: Scheduler options that customize the effect's delivery of elements.
   /// - Returns: An effect that will be executed after `dueTime`
+  @available(iOS, deprecated: 9999.0, message: "Use 'scheduler.sleep' in 'Effect.run', instead.")
+  @available(macOS, deprecated: 9999.0, message: "Use 'scheduler.sleep' in 'Effect.run', instead.")
+  @available(tvOS, deprecated: 9999.0, message: "Use 'scheduler.sleep' in 'Effect.run', instead.")
+  @available(
+    watchOS, deprecated: 9999.0, message: "Use 'scheduler.sleep' in 'Effect.run', instead."
+  )
   public func deferred(
     for dueTime: TimeInterval,
     scheduler: DateScheduler
   ) -> Self {
     switch self.operation {
     case .none:
       return .none
-    case let .producer(producer):
+    case .producer:
       return Self(
         operation: .producer(
           SignalProducer<Void, Never>(value: ())
             .delay(dueTime, on: scheduler)
-            .flatMap(.latest) { producer.observe(on: scheduler) }
+            .flatMap(.latest) { self.producer.observe(on: scheduler) }
         )
       )
     case let .run(priority, operation):
       return Self(
         operation: .run(priority) { send in
           do {
             try await scheduler.sleep(for: .nanoseconds(Int(dueTime * TimeInterval(NSEC_PER_SEC))))
-            await operation(send)
+            await operation(
+              Send { output in
+                scheduler.schedule {
+                  send(output)
+                }
+              }
+            )
           } catch {}
         }
       )

Sources/ComposableArchitecture/Effects/Timer.swift

@@ -111,6 +111,12 @@ extension Effect where Output == Date, Failure == Never {
   ///   - tolerance: The allowed timing variance when emitting events. Defaults to `nil`, which
   ///     allows any variance.
   ///   - options: Scheduler options passed to the timer. Defaults to `nil`.
+  @available(iOS, deprecated: 9999.0, message: "Use 'scheduler.timer' in 'Effect.run', instead.")
+  @available(macOS, deprecated: 9999.0, message: "Use 'scheduler.timer' in 'Effect.run', instead.")
+  @available(tvOS, deprecated: 9999.0, message: "Use 'scheduler.timer' in 'Effect.run', instead.")
+  @available(
+    watchOS, deprecated: 9999.0, message: "Use 'scheduler.timer' in 'Effect.run', instead."
+  )
   public static func timer(
     id: Any.Type,
     every interval: DispatchTimeInterval,