Fix warnings introduced in Xcode 14.1 (#1388)

* Fix warnings introduced in Xcode 14.1

* wip

(cherry picked from commit bcdcb3d7091d57a3e9cf5370b345a9309d205d39)

# Conflicts:
#	Sources/ComposableArchitecture/Internal/TaskCancellableValue.swift
#	Sources/ComposableArchitecture/ViewStore.swift

Author: stephencelis

Examples/VoiceMemos/VoiceMemos/AudioRecorderClient/LiveAudioRecorderClient.swift

@@ -79,9 +79,10 @@ private actor AudioRecorder {
       }
     }
 
-    guard let action = try await stream.first(where: { @Sendable _ in true })
-    else { throw CancellationError() }
-    return action
+    for try await didFinish in stream {
+      return didFinish
+    }
+    throw CancellationError()
   }
 }
 

Sources/ComposableArchitecture/Internal/TaskCancellableValue.swift

@@ -3,9 +3,9 @@
     var cancellableValue: Success {
       get async throws {
         try await withTaskCancellationHandler {
-          self.cancel()
-        } operation: {
           try await self.value
+        } onCancel: {
+          self.cancel()
         }
       }
     }
@@ -16,9 +16,9 @@
     var cancellableValue: Success {
       get async {
         await withTaskCancellationHandler {
-          self.cancel()
-        } operation: {
           await self.value
+        } onCancel: {
+          self.cancel()
         }
       }
     }

Sources/ComposableArchitecture/Store.swift

@@ -422,13 +422,13 @@ public final class Store<State, Action> {
         var index = tasks.wrappedValue.startIndex
         while index < tasks.wrappedValue.endIndex {
           defer { index += 1 }
-          tasks.wrappedValue[index].cancel()
+          await tasks.wrappedValue[index].value
         }
-      } operation: {
+      } onCancel: {
         var index = tasks.wrappedValue.startIndex
         while index < tasks.wrappedValue.endIndex {
           defer { index += 1 }
-          await tasks.wrappedValue[index].value
+          tasks.wrappedValue[index].cancel()
         }
       }
     }

Sources/ComposableArchitecture/ViewStore.swift

@@ -264,9 +264,9 @@ public final class ViewStore<State, Action> {
     public func send(_ action: Action, while predicate: @escaping (State) -> Bool) async {
       let task = self.send(action)
       await withTaskCancellationHandler {
-        task.rawValue?.cancel()
-      } operation: {
         await self.yield(while: predicate)
+      } onCancel: {
+        task.rawValue?.cancel()
       }
     }
 
@@ -287,9 +287,9 @@ public final class ViewStore<State, Action> {
       ) async {
         let task = withAnimation(animation) { self.send(action) }
         await withTaskCancellationHandler {
-          task.rawValue?.cancel()
-        } operation: {
           await self.yield(while: predicate)
+        } onCancel: {
+          task.rawValue?.cancel()
         }
       }
     #endif
@@ -304,31 +304,30 @@ public final class ViewStore<State, Action> {
     @MainActor
     public func yield(while predicate: @escaping (State) -> Bool) async {
       if #available(iOS 15, macOS 12, tvOS 15, watchOS 8, *) {
-        _ = await self.produced.producer
+          _ = await self.produced.producer
           .values
           .first(where: { !predicate($0) })
       } else {
         let cancellable = Box<Disposable?>(wrappedValue: nil)
-        try? await withTaskCancellationHandler(
-          handler: { cancellable.wrappedValue?.dispose() },
-          operation: {
-            try Task.checkCancellation()
-            try await withUnsafeThrowingContinuation {
-              (continuation: UnsafeContinuation<Void, Error>) in
-              guard !Task.isCancelled else {
-                continuation.resume(throwing: CancellationError())
-                return
-              }
-              cancellable.wrappedValue = self.produced.producer
-                .filter { !predicate($0) }
-                .take(first: 1)
-                .startWithValues { _ in
-                  continuation.resume()
-                  _ = cancellable
-                }
+        try? await withTaskCancellationHandler {
+          try Task.checkCancellation()
+          try await withUnsafeThrowingContinuation {
+            (continuation: UnsafeContinuation<Void, Error>) in
+            guard !Task.isCancelled else {
+              continuation.resume(throwing: CancellationError())
+              return
             }
+                cancellable.wrappedValue = self.produced.producer
+              .filter { !predicate($0) }
+                  .take(first: 1)
+                  .startWithValues { _ in
+                continuation.resume()
+                _ = cancellable
+              }
           }
-        )
+        } onCancel: {
+          cancellable.wrappedValue?.dispose()
+        }
       }
     }
   #endif