Ignore errors thrown in fireAndForget. (#1088)

* Ignore errors throw in fireAndForget.

* Update Sources/ComposableArchitecture/Effects/Concurrency.swift

Co-authored-by: Stephen Celis <[email protected]>

* Update Sources/ComposableArchitecture/Effects/Concurrency.swift

Co-authored-by: Stephen Celis <[email protected]>

Author: 2 people

Sources/ComposableArchitecture/Effects/Concurrency.swift

@@ -104,7 +104,7 @@ import ReactiveSwift
     }
 
     /// Creates an effect that executes some work in the real world that doesn't need to feed data
-    /// back into the store.
+    /// back into the store. If an error is thrown, the effect will complete and the error will be ignored.
     ///
     /// - Parameters:
     ///   - priority: Priority of the underlying task. If `nil`, the priority will come from
@@ -113,9 +113,9 @@ import ReactiveSwift
     /// - Returns: An effect.
     public static func fireAndForget(
       priority: TaskPriority? = nil,
-      _ work: @escaping @Sendable () async -> Void
+      _ work: @escaping @Sendable () async throws -> Void
     ) -> Effect {
-      Effect<Void, Never>.task(priority: priority) { await work() }
+      Effect<Void, Never>.task(priority: priority) { try? await work() }
         .fireAndForget()
     }
   }

Tests/ComposableArchitectureTests/EffectTests.swift

@@ -249,6 +249,7 @@ final class EffectTests: XCTestCase {
        .start()
 
       disposable.dispose()
+
       _ = XCTWaiter.wait(for: [.init()], timeout: 1.1)
     }
 
@@ -262,14 +263,15 @@ final class EffectTests: XCTestCase {
         return 42
       }
 
-      Effect<Int, Never >.task { await work() }
-        .sink(
-          receiveCompletion: { _ in XCTFail() },
-          receiveValue: { _ in XCTFail() }
+      let disposable = Effect<Int, Never >.task { await work() }
+        .on(
+           completed: { XCTFail() },
+           value: { _ in XCTFail() }
         )
-        .store(in: &self.cancellables)
+        .start(on: QueueScheduler.main)
+        .start()
 
-      self.cancellables = []
+      disposable.dispose()
 
       _ = XCTWaiter.wait(for: [.init()], timeout: 1.1)
     }