Cleanup: Global/Local -> Parent/Child (#1269)

* Make openSettings async.

* global/local -> parent/child

* error cleanup

* Clean up action scoping

* cleanup

* wip

Co-authored-by: Brandon Williams <[email protected]>
(cherry picked from commit 799aa18f86cd9df8d7787e0c05c5cd13067c44b9)

# Conflicts:
#	Examples/VoiceMemos/VoiceMemos/VoiceMemosApp.swift
#	Sources/ComposableArchitecture/Internal/Deprecations.swift
#	Sources/ComposableArchitecture/Store.swift
#	Sources/ComposableArchitecture/SwiftUI/SwitchStore.swift
#	Sources/ComposableArchitecture/TestStore.swift
#	Sources/ComposableArchitecture/ViewStore.swift

Author: stephencelis

Examples/VoiceMemos/VoiceMemos/RecordingMemo.swift

@@ -2,6 +2,8 @@ import ComposableArchitecture
 import ReactiveSwift
 import SwiftUI
 
+struct RecordingMemoFailed: Equatable, Error {}
+
 struct RecordingMemoState: Equatable {
   var date: Date
   var duration: TimeInterval = 0
@@ -12,8 +14,6 @@ struct RecordingMemoState: Equatable {
     case recording
     case encoding
   }
-
-  struct Failed: Equatable, Error {}
 }
 
 enum RecordingMemoAction: Equatable {
@@ -44,7 +44,7 @@ let recordingMemoReducer = Reducer<
     return .task { [state] in .delegate(.didFinish(.success(state))) }
 
   case .audioRecorderDidFinish(.success(false)):
-    return .task { .delegate(.didFinish(.failure(RecordingMemoState.Failed()))) }
+    return .task { .delegate(.didFinish(.failure(RecordingMemoFailed()))) }
 
   case let .audioRecorderDidFinish(.failure(error)):
     return .task { .delegate(.didFinish(.failure(error))) }

Examples/VoiceMemos/VoiceMemos/VoiceMemo.swift

@@ -104,8 +104,7 @@ struct VoiceMemoView: View {
       HStack {
         TextField(
           "Untitled, \(viewStore.date.formatted(date: .numeric, time: .shortened))",
-          text: viewStore.binding(
-            get: \.title, send: VoiceMemoAction.titleTextFieldChanged)
+          text: viewStore.binding(get: \.title, send: { .titleTextFieldChanged($0) })
         )
 
         Spacer()

Examples/VoiceMemos/VoiceMemos/VoiceMemos.swift

@@ -150,7 +150,7 @@ struct VoiceMemosView: View {
         VStack {
           List {
             ForEachStore(
-              self.store.scope(state: \.voiceMemos, action: VoiceMemosAction.voiceMemo(id:action:))
+              self.store.scope(state: \.voiceMemos, action: { .voiceMemo(id: $0, action: $1) })
             ) {
               VoiceMemoView(store: $0)
             }
@@ -162,7 +162,7 @@ struct VoiceMemosView: View {
           }
 
           IfLetStore(
-            self.store.scope(state: \.recordingMemo, action: VoiceMemosAction.recordingMemo)
+            self.store.scope(state: \.recordingMemo, action: { .recordingMemo($0) })
           ) { store in
             RecordingMemoView(store: store)
           } else: {

Examples/VoiceMemos/VoiceMemos/VoiceMemosApp.swift

@@ -15,8 +15,10 @@ struct VoiceMemosApp: App {
             audioPlayer: .live,
             audioRecorder: .live,
             mainRunLoop: QueueScheduler.main,
-            openSettings: { @MainActor in
+            openSettings: {
+              await MainActor.run {
               UIApplication.shared.open(URL(string: UIApplication.openSettingsURLString)!)
+              }
             },
             temporaryDirectory: { URL(fileURLWithPath: NSTemporaryDirectory()) },
             uuid: { UUID() }

Sources/ComposableArchitecture/Debugging/ReducerDebugging.swift

@@ -83,46 +83,46 @@ extension Reducer {
     )
   }
 
-  /// Prints debug messages describing all received local actions and local state mutations.
+  /// Prints debug messages describing all received actions and state mutations.
   ///
   /// Printing is only done in debug (`#if DEBUG`) builds.
   ///
   /// - Parameters:
   ///   - prefix: A string with which to prefix all debug messages.
-  ///   - toLocalState: A function that filters state to be printed.
-  ///   - toLocalAction: A case path that filters actions that are printed.
+  ///   - toDebugState: A function that filters state to be printed.
+  ///   - toDebugAction: A case path that filters actions that are printed.
   ///   - toDebugEnvironment: A function that transforms an environment into a debug environment by
   ///     describing a print function and a queue to print from. Defaults to a function that ignores
   ///     the environment and returns a default ``DebugEnvironment`` that uses Swift's `print`
   ///     function and a background queue.
   /// - Returns: A reducer that prints debug messages for all received actions.
-  public func debug<LocalState, LocalAction>(
+  public func debug<DebugState, DebugAction>(
     _ prefix: String = "",
-    state toLocalState: @escaping (State) -> LocalState,
-    action toLocalAction: CasePath<Action, LocalAction>,
+    state toDebugState: @escaping (State) -> DebugState,
+    action toDebugAction: CasePath<Action, DebugAction>,
     actionFormat: ActionFormat = .prettyPrint,
     environment toDebugEnvironment: @escaping (Environment) -> DebugEnvironment = { _ in
       DebugEnvironment()
     }
   ) -> Self {
     #if DEBUG
       return .init { state, action, environment in
-        let previousState = toLocalState(state)
+        let previousState = toDebugState(state)
         let effects = self.run(&state, action, environment)
-        guard let localAction = toLocalAction.extract(from: action) else { return effects }
-        let nextState = toLocalState(state)
+        guard let debugAction = toDebugAction.extract(from: action) else { return effects }
+        let nextState = toDebugState(state)
         let debugEnvironment = toDebugEnvironment(environment)
         return .concatenate(
           .fireAndForget {
             debugEnvironment.queue.async {
               var actionOutput = ""
               if actionFormat == .prettyPrint {
-                customDump(localAction, to: &actionOutput, indent: 2)
+                customDump(debugAction, to: &actionOutput, indent: 2)
               } else {
-                actionOutput.write(debugCaseOutput(localAction).indent(by: 2))
+                actionOutput.write(debugCaseOutput(debugAction).indent(by: 2))
               }
               let stateOutput =
-                LocalState.self == Void.self
+                DebugState.self == Void.self
                 ? ""
                 : diff(previousState, nextState).map { "\($0)\n" } ?? "  (No state changes)\n"
               debugEnvironment.printer(