Update Effect internals to be more efficient. (#1312)

* Distinguish Combine and async effects from each other

* wip

* wip

* wip

* Add some tests

* wip

* wip

* wip

Co-authored-by: Stephen Celis <[email protected]>
(cherry picked from commit 7b5bc85f2eac9e8290b74e41f5a8b3d1136b1928)

# Conflicts:
#	Sources/ComposableArchitecture/Debugging/ReducerDebugging.swift
#	Sources/ComposableArchitecture/Debugging/ReducerInstrumentation.swift
#	Sources/ComposableArchitecture/Effect.swift
#	Sources/ComposableArchitecture/Effects/Animation.swift
#	Sources/ComposableArchitecture/Effects/Cancellation.swift
#	Sources/ComposableArchitecture/Effects/Debouncing.swift
#	Sources/ComposableArchitecture/Effects/Deferring.swift
#	Sources/ComposableArchitecture/Effects/SignalProducer.swift
#	Sources/ComposableArchitecture/Effects/Throttling.swift
#	Sources/ComposableArchitecture/Internal/TaskCancellableValue.swift
#	Sources/ComposableArchitecture/Store.swift
#	Tests/ComposableArchitectureTests/EffectFailureTests.swift
#	Tests/ComposableArchitectureTests/EffectTests.swift

Author: mbrandonw

Examples/CaseStudies/SwiftUICaseStudies/00-Core.swift

@@ -276,8 +276,6 @@ let rootReducer = Reducer<RootState, RootAction, RootEnvironment>.combine(
       environment: { .init(mainQueue: $0.mainQueue, webSocket: $0.webSocket) }
     )
 )
-.debug()
-.signpost()
 
 @Sendable private func liveFetchNumber() async throws -> Int {
   try await Task.sleep(nanoseconds: NSEC_PER_SEC)

Examples/CaseStudies/SwiftUICaseStudies/04-HigherOrderReducers-ResuableOfflineDownloads/DownloadClient.swift

@@ -1,6 +1,7 @@
 import Combine
 import ComposableArchitecture
 import Foundation
+import XCTestDynamicOverlay
 
 struct DownloadClient {
   var download: @Sendable (URL) -> AsyncThrowingStream<Event, Error>
@@ -38,4 +39,8 @@ extension DownloadClient {
       }
     }
   )
+
+  static let unimplemented = Self(
+    download: XCTUnimplemented("\(Self.self).asyncDownload")
+  )
 }

Examples/CaseStudies/SwiftUICaseStudies/CaseStudiesApp.swift

@@ -8,7 +8,9 @@ struct CaseStudiesApp: App {
       RootView(
         store: Store(
           initialState: RootState(),
-          reducer: rootReducer,
+          reducer: rootReducer
+            .debug()
+            .signpost(),
           environment: .live
         )
       )

Examples/CaseStudies/SwiftUICaseStudiesTests/04-HigherOrderReducers-ReusableOfflineDownloadsTests.swift

@@ -1,7 +1,6 @@
 import ComposableArchitecture
 import ReactiveSwift
 import XCTest
-import XCTestDynamicOverlay
 
 @testable import SwiftUICaseStudies
 
@@ -161,9 +160,3 @@ final class ReusableComponentsDownloadComponentTests: XCTestCase {
     }
   }
 }
-
-extension DownloadClient {
-  static let unimplemented = Self(
-    download: XCTUnimplemented("\(Self.self).asyncDownload")
-  )
-}

Examples/Search/Search/SearchApp.swift

@@ -8,7 +8,8 @@ struct SearchApp: App {
       SearchView(
         store: Store(
           initialState: SearchState(),
-          reducer: searchReducer.debug(),
+          reducer: searchReducer
+            .debug(),
           environment: SearchEnvironment(
             weatherClient: WeatherClient.live
           )

Examples/SpeechRecognition/SpeechRecognition/SpeechRecognition.swift

@@ -102,7 +102,6 @@ let appReducer = Reducer<AppState, AppAction, AppEnvironment> { state, action, e
     }
   }
 }
-.debug()
 
 struct SpeechRecognitionView: View {
   let store: Store<AppState, AppAction>

Examples/SpeechRecognition/SpeechRecognition/SpeechRecognitionApp.swift

@@ -8,7 +8,8 @@ struct SpeechRecognitionApp: App {
       SpeechRecognitionView(
         store: Store(
           initialState: AppState(),
-          reducer: appReducer,
+          reducer: appReducer
+            .debug(),
           environment: AppEnvironment(
             speechClient: .live
           )

Examples/TicTacToe/App/RootView.swift

@@ -30,7 +30,8 @@ enum GameType: Identifiable {
 struct RootView: View {
   let store = Store(
     initialState: AppState(),
-    reducer: appReducer,
+    reducer: appReducer
+      .debug(),
     environment: AppEnvironment(
       authenticationClient: .live
     )

Examples/TicTacToe/tic-tac-toe/Sources/AppCore/AppCore.swift

@@ -60,4 +60,3 @@ public let appReducer = Reducer<AppState, AppAction, AppEnvironment>.combine(
     }
   }
 )
-.debug()

Examples/Todos/Todos/TodosApp.swift

@@ -9,7 +9,8 @@ struct TodosApp: App {
       AppView(
         store: Store(
           initialState: AppState(),
-          reducer: appReducer.debug(),
+          reducer: appReducer
+            .debug(),
           environment: AppEnvironment(
             mainQueue: QueueScheduler.main,
             uuid: { UUID() }