Remove old Effect.fireAndForget() (#430)

Author: mluisbrown

Sources/ComposableArchitecture/Effect.swift

@@ -131,41 +131,27 @@ extension Effect {
   /// and any failure.
   ///
   /// This is useful for times you want to fire off an effect but don't want to feed any data back
-  /// into the system.
+  /// into the system. It can automatically promote an effect to your reducer's domain.
   ///
   ///     case .buttonTapped:
   ///       return analyticsClient.track("Button Tapped")
   ///         .fireAndForget()
   ///
+  /// - Parameters:
+  ///   - outputType: An output type.
+  ///   - failureType: A failure type.
   /// - Returns: An effect that never produces output or errors.
-  public func fireAndForget<NewValue, NewError>() -> Effect<NewValue, NewError> {
+  public func fireAndForget<NewValue, NewError>(
+    outputType: NewValue.Type = NewValue.self,
+    failureType: NewError.Type = NewError.self
+  ) -> Effect<NewValue, NewError> {
     self.flatMapError { _ in .empty }
       .flatMap(.latest) { _ in
         .empty
       }
   }
 }
 
-extension Effect where Value == Never {
-  /// Upcasts an `Effect<Never, Error>` to an `Effect<T, Error>` for any type `T`. This is
-  /// possible to do because an `Effect<Never, Error>` can never produce any values to feed back
-  /// into the store (hence the name "fire and forget"), and therefore we can act like it's an
-  /// effect that produces values of any type (since it never produces values).
-  ///
-  /// This is useful for times you have an `Effect<Never, Error>` but need to massage it into
-  /// another type in order to return it from a reducer:
-  ///
-  ///     case .buttonTapped:
-  ///       return analyticsClient.track("Button Tapped")
-  ///         .fireAndForget()
-  ///
-  /// - Returns: An effect.
-  public func fireAndForget<T>() -> Effect<T, Error> {
-    func absurd<A>(_ never: Never) -> A {}
-    return self.map(absurd)
-  }
-}
-
 extension Effect where Self.Error == Never {
 
   /// Assigns each element from an Effect to a property on an object.