Improved error message when AssertEmpty fails on a message queue (#84)

azingher · web-flow · commit 5670ee56cca0 · 2020-09-14T10:04:05.000-04:00
Include the type of the first message in the non-empty queue in the error message.
diff --git a/src/ReactiveDomain.Testing/Messaging/ConcurrentMessageQueue.cs b/src/ReactiveDomain.Testing/Messaging/ConcurrentMessageQueue.cs
@@ -56,8 +56,11 @@ public ConcurrentMessageQueue<T> AssertNext<TMsg>(
         }
         public void AssertEmpty()
         {
-            if (!IsEmpty)
-                throw new Exception($" {_name} Queue not Empty.");
+            if (IsEmpty) return;
+            var errMsg = $"{_name} Queue is not Empty.";
+            if (TryPeek(out var msg))
+                errMsg += $" Instead {msg.GetType()} is next.";
+            throw new Exception(errMsg);
         }
 
         // JUST INHERITING EVERYTHING

Original file line number	Diff line number	Diff line change
`@@ -56,8 +56,11 @@ public ConcurrentMessageQueue<T> AssertNext<TMsg>(`
`56`	`56`	`}`
`57`	`57`	`public void AssertEmpty()`
`58`	`58`	`{`
`59`		`- if (!IsEmpty)`
`60`		`- throw new Exception($" {_name} Queue not Empty.");`
	`59`	`+ if (IsEmpty) return;`
	`60`	`+ var errMsg = $"{_name} Queue is not Empty.";`
	`61`	`+ if (TryPeek(out var msg))`
	`62`	`+ errMsg += $" Instead {msg.GetType()} is next.";`
	`63`	`+ throw new Exception(errMsg);`
`61`	`64`	`}`
`62`	`65`
`63`	`66`	`// JUST INHERITING EVERYTHING`