Policy tool enhancements (#123)

* Adds "--app-id" option to "add-app" subcommand
* Adds "--app-uri" as an option for add-app subcommand. Defaults to "http://localhost" which is deliberately different from the previous hard-coded default.
* Fixes bug that made --user-name optional when adding a user. Changed to object initializers for Option<T> construction to avoid similar such bugs in the future.
* Changes role name comparison to be case-insensitive.
* Fixes spelling of "principal" (was "principle"). This is a breaking change since it impacts multiple public interfaces that were created in RD 0.9.0.

Author: joshkempner

src/ReactiveDomain.IdentityStorage.Tests/MockPrinciple.cs renamed to src/ReactiveDomain.IdentityStorage.Tests/MockPrincipal.cs

@@ -2,7 +2,7 @@
 
 namespace ReactiveDomain.IdentityStorage.Tests
 {
-    internal class MockPrinciple : IPrinciple
+    internal class MockPrincipal : IPrincipal
     {
         public string Provider { get; set; }
 

src/ReactiveDomain.IdentityStorage.Tests/SubjectRmTests.cs

@@ -64,12 +64,12 @@ public void can_get_subject_ids()
             Assert.Equal(sub3, testSub);
         }
         [Fact]
-        public void can_get_subject_id_for_principle()
+        public void can_get_subject_id_for_principal()
         {
             var userId = Guid.NewGuid();            
             var subjectId = AddNewSubject(userId, provider: AuthProvider, domain: AuthDomain);
-            var user = new MockPrinciple { Provider = AuthProvider, Domain = AuthDomain, SId = userId.ToString() };
-            Assert.True(_rm.TryGetSubjectIdForPrinciple(user, out var id));
+            var user = new MockPrincipal { Provider = AuthProvider, Domain = AuthDomain, SId = userId.ToString() };
+            Assert.True(_rm.TryGetSubjectIdForPrincipal(user, out var id));
             Assert.Equal(subjectId, id);
         }
         [Fact]

src/ReactiveDomain.IdentityStorage/ReadModels/PrincipalWrapper.cs

@@ -0,0 +1,29 @@
+using System.DirectoryServices.AccountManagement;
+using ReactiveDomain.Util;
+
+namespace ReactiveDomain.IdentityStorage.ReadModels
+{
+
+    public interface IPrincipal
+    {
+        string Provider { get; }
+        string Domain { get; }
+        string SId { get; }
+    }
+    public class PrincipalWrapper : IPrincipal
+    {
+        private readonly UserPrincipal _principal;
+
+        public PrincipalWrapper(UserPrincipal principal)
+        {
+            Ensure.NotNull(principal, nameof(principal));
+            _principal = principal;
+        }
+
+        public string Provider => _principal.ContextType.ToString();
+
+        public string Domain => _principal.Context.Name;
+
+        public string SId => _principal.Sid.ToString();
+    }
+}

src/ReactiveDomain.IdentityStorage/ReadModels/PrincipleWrapper.cs

@@ -48,14 +48,14 @@ public bool TryGetSubjectIdForUser(Guid userId, string provider, string domain,
             }
             return false;
         }
-        public bool TryGetSubjectIdForPrinciple(IPrinciple principle, out Guid subjectId)
+        public bool TryGetSubjectIdForPrincipal(IPrincipal principal, out Guid subjectId)
         {
             try
             {
 
-                if (SubjectsBySubClaim.TryGetValue(GetDomainCategory(principle.Provider, principle.Domain), out var subList))
+                if (SubjectsBySubClaim.TryGetValue(GetDomainCategory(principal.Provider, principal.Domain), out var subList))
                 {
-                    return subList.TryGetValue(principle.SId, out subjectId);
+                    return subList.TryGetValue(principal.SId, out subjectId);
                 }
             }
             catch

src/ReactiveDomain.IdentityStorage/ReadModels/SubjectsRm.cs

@@ -89,7 +89,7 @@ public ValidationResult Validate(string domainName, string userName, string pass
 
                         if (authSucceeded)
                         {
-                            //build the Claims Principle to return in the token
+                            //build the Claims Principal to return in the token
                             result.IsValidated = true;
                             _userStore.UserAuthenticated(user, domainName, contextType.ToString(), remoteHttpAddress, clientId);
                             var additionalClaims = _userStore.GetAdditionalClaims(userId);