Skip to content

Commit 007ce55

Browse files
committed
fix GroupBy and GroupByUntil which are actually Operators
1 parent 65c268c commit 007ce55

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

rxjava-core/src/main/java/rx/Observable.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4053,7 +4053,7 @@ public final void forEach(final Action1<? super T> onNext, final Action1<Throwab
40534053
* @see <a href="https://github.com/Netflix/RxJava/wiki/Transforming-Observables#wiki-groupby-and-groupbyuntil">RxJava Wiki: groupBy</a>
40544054
*/
40554055
public final <K> Observable<GroupedObservable<K, T>> groupBy(final Func1<? super T, ? extends K> keySelector) {
4056-
return lift(new OnSubscribeGroupBy<K, T>(keySelector));
4056+
return lift(new OperatorGroupBy<K, T>(keySelector));
40574057
}
40584058

40594059
/**
@@ -4106,7 +4106,7 @@ public final <TKey, TDuration> Observable<GroupedObservable<TKey, T>> groupByUnt
41064106
* @see <a href="http://msdn.microsoft.com/en-us/library/hh229433.aspx">MSDN: Observable.GroupByUntil</a>
41074107
*/
41084108
public final <TKey, TValue, TDuration> Observable<GroupedObservable<TKey, TValue>> groupByUntil(Func1<? super T, ? extends TKey> keySelector, Func1<? super T, ? extends TValue> valueSelector, Func1<? super GroupedObservable<TKey, TValue>, ? extends Observable<? extends TDuration>> durationSelector) {
4109-
return lift(new OnSubscribeGroupByUntil<T, TKey, TValue, TDuration>(keySelector, valueSelector, durationSelector));
4109+
return lift(new OperatorGroupByUntil<T, TKey, TValue, TDuration>(keySelector, valueSelector, durationSelector));
41104110
}
41114111

41124112
/**

rxjava-core/src/main/java/rx/operators/OnSubscribeGroupBy.java renamed to rxjava-core/src/main/java/rx/operators/OperatorGroupBy.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@
3737
* @param <K> the key type
3838
* @param <T> the source and group value type
3939
*/
40-
public final class OnSubscribeGroupBy<K, T> implements Operator<GroupedObservable<K, T>, T> {
40+
public final class OperatorGroupBy<K, T> implements Operator<GroupedObservable<K, T>, T> {
4141

4242
final Func1<? super T, ? extends K> keySelector;
4343

44-
public OnSubscribeGroupBy(final Func1<? super T, ? extends K> keySelector) {
44+
public OperatorGroupBy(final Func1<? super T, ? extends K> keySelector) {
4545
this.keySelector = keySelector;
4646
}
4747

rxjava-core/src/main/java/rx/operators/OnSubscribeGroupByUntil.java renamed to rxjava-core/src/main/java/rx/operators/OperatorGroupByUntil.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,12 @@
4444
* @param <R> the value type of the groups
4545
* @param <D> the type of the duration
4646
*/
47-
public class OnSubscribeGroupByUntil<T, K, R, D> implements Operator<GroupedObservable<K, R>, T> {
47+
public class OperatorGroupByUntil<T, K, R, D> implements Operator<GroupedObservable<K, R>, T> {
4848
final Func1<? super T, ? extends K> keySelector;
4949
final Func1<? super T, ? extends R> valueSelector;
5050
final Func1<? super GroupedObservable<K, R>, ? extends Observable<? extends D>> durationSelector;
5151

52-
public OnSubscribeGroupByUntil(
52+
public OperatorGroupByUntil(
5353
Func1<? super T, ? extends K> keySelector,
5454
Func1<? super T, ? extends R> valueSelector,
5555
Func1<? super GroupedObservable<K, R>, ? extends Observable<? extends D>> durationSelector) {

rxjava-core/src/main/java/rx/operators/OperatorParallel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public OperatorParallel(Func1<Observable<T>, Observable<R>> f, Scheduler schedul
4141
public Subscriber<? super T> call(Subscriber<? super R> op) {
4242

4343
Func1<Subscriber<? super GroupedObservable<Long, T>>, Subscriber<? super T>> groupBy =
44-
new OnSubscribeGroupBy<Long, T>(new Func1<T, Long>() {
44+
new OperatorGroupBy<Long, T>(new Func1<T, Long>() {
4545

4646
long i = 0;
4747

rxjava-core/src/test/java/rx/operators/OnSubscribeGroupByTest.java renamed to rxjava-core/src/test/java/rx/operators/OperatorGroupByTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
import rx.observables.GroupedObservable;
5151
import rx.schedulers.Schedulers;
5252

53-
public class OnSubscribeGroupByTest {
53+
public class OperatorGroupByTest {
5454

5555
final Func1<String, Integer> length = new Func1<String, Integer>() {
5656
@Override
@@ -62,7 +62,7 @@ public Integer call(String s) {
6262
@Test
6363
public void testGroupBy() {
6464
Observable<String> source = Observable.from("one", "two", "three", "four", "five", "six");
65-
Observable<GroupedObservable<Integer, String>> grouped = source.lift(new OnSubscribeGroupBy<Integer, String>(length));
65+
Observable<GroupedObservable<Integer, String>> grouped = source.lift(new OperatorGroupBy<Integer, String>(length));
6666

6767
Map<Integer, Collection<String>> map = toMap(grouped);
6868

@@ -75,7 +75,7 @@ public void testGroupBy() {
7575
@Test
7676
public void testEmpty() {
7777
Observable<String> source = Observable.empty();
78-
Observable<GroupedObservable<Integer, String>> grouped = source.lift(new OnSubscribeGroupBy<Integer, String>(length));
78+
Observable<GroupedObservable<Integer, String>> grouped = source.lift(new OperatorGroupBy<Integer, String>(length));
7979

8080
Map<Integer, Collection<String>> map = toMap(grouped);
8181

@@ -88,7 +88,7 @@ public void testError() {
8888
Observable<String> errorSource = Observable.error(new RuntimeException("forced failure"));
8989
Observable<String> source = Observable.concat(sourceStrings, errorSource);
9090

91-
Observable<GroupedObservable<Integer, String>> grouped = source.lift(new OnSubscribeGroupBy<Integer, String>(length));
91+
Observable<GroupedObservable<Integer, String>> grouped = source.lift(new OperatorGroupBy<Integer, String>(length));
9292

9393
final AtomicInteger groupCounter = new AtomicInteger();
9494
final AtomicInteger eventCounter = new AtomicInteger();

rxjava-core/src/test/java/rx/operators/OnSubscribeGroupByUntilTest.java renamed to rxjava-core/src/test/java/rx/operators/OperatorGroupByUntilTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
import rx.functions.Functions;
4646
import rx.observables.GroupedObservable;
4747

48-
public class OnSubscribeGroupByUntilTest {
48+
public class OperatorGroupByUntilTest {
4949
@Mock
5050
Observer<Object> observer;
5151

0 commit comments

Comments
 (0)