Skip to content

Commit 223ea4c

Browse files
Merge pull request #1035 from vigdorchik/scala_cleanup
Scala cleanup
2 parents 187eddb + 0fa7896 commit 223ea4c

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/Observable.scala

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -347,18 +347,17 @@ trait Observable[+T]
347347
* An [[rx.lang.scala.Observable]] which produces connected non-overlapping buffers, which are emitted
348348
* when the current [[rx.lang.scala.Observable]] created with the function argument produces an object.
349349
*/
350-
def buffer[Closing](closings: () => Observable[_ <: Closing]) : Observable[Seq[T]] = {
351-
val f: Func0[_ <: rx.Observable[_ <: Closing]] = closings().asJavaObservable
352-
val jObs: rx.Observable[_ <: java.util.List[_]] = asJavaObservable.buffer[Closing](f)
350+
def buffer(closings: () => Observable[Any]) : Observable[Seq[T]] = {
351+
val f: Func0[_ <: rx.Observable[_ <: Any]] = closings().asJavaObservable
352+
val jObs: rx.Observable[_ <: java.util.List[_]] = asJavaObservable.buffer[Any](f)
353353
Observable.jObsOfListToScObsOfSeq(jObs.asInstanceOf[rx.Observable[_ <: java.util.List[T]]])
354354
}
355355
/**
356356
* Creates an Observable which produces buffers of collected values.
357357
*
358358
* This Observable produces buffers. Buffers are created when the specified `openings`
359-
* Observable produces an object. Additionally the function argument
360-
* is used to create an Observable which produces [[rx.lang.scala.util.Closing]] objects. When this
361-
* Observable produces such an object, the associated buffer is emitted.
359+
* Observable produces an object. That object is used to construct an Observable to emit buffers, feeding it into `closings` function.
360+
* Buffers are emitted when the created Observable produces an object.
362361
*
363362
* @param openings
364363
* The [[rx.lang.scala.Observable]] which, when it produces an object, will cause
@@ -568,10 +567,9 @@ trait Observable[+T]
568567
}
569568

570569
/**
571-
* Creates an Observable which produces windows of collected values. This Observable produces windows.
572-
* Chunks are created when the specified `openings` Observable produces an object.
573-
* Additionally the `closings` argument is used to create an Observable which produces [[rx.lang.scala.util.Closing]] objects.
574-
* When this Observable produces such an object, the associated window is emitted.
570+
* Creates an Observable which produces windows of collected values. Chunks are created when the specified `openings`
571+
* Observable produces an object. That object is used to construct an Observable to emit windows, feeding it into `closings` function.
572+
* Windows are emitted when the created Observable produces an object.
575573
*
576574
* @param openings
577575
* The [[rx.lang.scala.Observable]] which when it produces an object, will cause

0 commit comments

Comments
 (0)