Have internal.operator.flowable unit tests extends RxJavaTest - 4 (#6600)

This commit updates the unit tests for `internal.operator.flowable`

Related: #6583

Author: RomanWuattier

src/test/java/io/reactivex/internal/operators/flowable/AbstractFlowableWithUpstreamTest.java

@@ -15,13 +15,14 @@
 
 import static org.junit.Assert.assertSame;
 
+import io.reactivex.RxJavaTest;
 import org.junit.Test;
 
 import io.reactivex.Flowable;
 import io.reactivex.internal.functions.Functions;
 import io.reactivex.internal.fuseable.HasUpstreamPublisher;
 
-public class AbstractFlowableWithUpstreamTest {
+public class AbstractFlowableWithUpstreamTest extends RxJavaTest {
 
     @SuppressWarnings("unchecked")
     @Test

src/test/java/io/reactivex/internal/operators/flowable/BlockingFlowableLatestTest.java

@@ -28,8 +28,8 @@
 import io.reactivex.schedulers.TestScheduler;
 import io.reactivex.testsupport.TestHelper;
 
-public class BlockingFlowableLatestTest {
-    @Test(timeout = 1000)
+public class BlockingFlowableLatestTest extends RxJavaTest {
+    @Test
     public void simple() {
         TestScheduler scheduler = new TestScheduler();
 
@@ -53,7 +53,7 @@ public void simple() {
         Assert.assertFalse(it.hasNext());
     }
 
-    @Test(timeout = 1000)
+    @Test
     public void sameSourceMultipleIterators() {
         TestScheduler scheduler = new TestScheduler();
 
@@ -79,7 +79,7 @@ public void sameSourceMultipleIterators() {
         }
     }
 
-    @Test(timeout = 1000, expected = NoSuchElementException.class)
+    @Test(expected = NoSuchElementException.class)
     public void empty() {
         Flowable<Long> source = Flowable.<Long> empty();
 
@@ -92,7 +92,7 @@ public void empty() {
         it.next();
     }
 
-    @Test(timeout = 1000, expected = NoSuchElementException.class)
+    @Test(expected = NoSuchElementException.class)
     public void simpleJustNext() {
         TestScheduler scheduler = new TestScheduler();
 
@@ -111,7 +111,7 @@ public void simpleJustNext() {
         }
     }
 
-    @Test(/* timeout = 1000, */expected = RuntimeException.class)
+    @Test(expected = RuntimeException.class)
     public void hasNextThrows() {
         TestScheduler scheduler = new TestScheduler();
 
@@ -126,7 +126,7 @@ public void hasNextThrows() {
         it.hasNext();
     }
 
-    @Test(timeout = 1000, expected = RuntimeException.class)
+    @Test(expected = RuntimeException.class)
     public void nextThrows() {
         TestScheduler scheduler = new TestScheduler();
 
@@ -140,7 +140,7 @@ public void nextThrows() {
         it.next();
     }
 
-    @Test(timeout = 1000)
+    @Test
     public void fasterSource() {
         PublishProcessor<Integer> source = PublishProcessor.create();
         Flowable<Integer> blocker = source;
@@ -169,12 +169,6 @@ public void fasterSource() {
         Assert.assertFalse(it.hasNext());
     }
 
-    @Ignore("THe target is an enum")
-    @Test
-    public void constructorshouldbeprivate() {
-        TestHelper.checkUtilityClass(BlockingFlowableLatest.class);
-    }
-
     @Test(expected = UnsupportedOperationException.class)
     public void remove() {
         Flowable.never().blockingLatest().iterator().remove();

src/test/java/io/reactivex/internal/operators/flowable/BlockingFlowableMostRecentTest.java

@@ -26,7 +26,7 @@
 import io.reactivex.schedulers.TestScheduler;
 import io.reactivex.testsupport.TestHelper;
 
-public class BlockingFlowableMostRecentTest {
+public class BlockingFlowableMostRecentTest extends RxJavaTest {
     @Test
     public void mostRecentNull() {
         assertNull(Flowable.<Void>never().blockingMostRecent(null).iterator().next());
@@ -73,7 +73,7 @@ public void mostRecentWithException() {
         it.next();
     }
 
-    @Test(timeout = 1000)
+    @Test
     public void singleSourceManyIterators() {
         TestScheduler scheduler = new TestScheduler();
         Flowable<Long> source = Flowable.interval(1, TimeUnit.SECONDS, scheduler).take(10);
@@ -98,12 +98,6 @@ public void singleSourceManyIterators() {
 
     }
 
-    @Ignore("The target is an enum")
-    @Test
-    public void constructorshouldbeprivate() {
-        TestHelper.checkUtilityClass(BlockingFlowableMostRecent.class);
-    }
-
     @Test
     public void empty() {
         Iterator<Integer> it = Flowable.<Integer>empty()

src/test/java/io/reactivex/internal/operators/flowable/BlockingFlowableNextTest.java

@@ -32,7 +32,7 @@
 import io.reactivex.schedulers.Schedulers;
 import io.reactivex.testsupport.TestHelper;
 
-public class BlockingFlowableNextTest {
+public class BlockingFlowableNextTest extends RxJavaTest {
 
     private void fireOnNextInNewThread(final FlowableProcessor<String> o, final String value) {
         new Thread() {
@@ -307,7 +307,7 @@ public void run() {
         }
     }
 
-    @Test /* (timeout = 8000) */
+    @Test
     public void singleSourceManyIterators() throws InterruptedException {
         Flowable<Long> f = Flowable.interval(250, TimeUnit.MILLISECONDS);
         PublishProcessor<Integer> terminal = PublishProcessor.create();
@@ -333,12 +333,6 @@ public void synchronousNext() {
         assertEquals(3, BehaviorProcessor.createDefault(3).blockingNext().iterator().next().intValue());
     }
 
-    @Ignore("THe target is an enum")
-    @Test
-    public void constructorshouldbeprivate() {
-        TestHelper.checkUtilityClass(BlockingFlowableNext.class);
-    }
-
     @Test(expected = UnsupportedOperationException.class)
     public void remove() {
         Flowable.never().blockingNext().iterator().remove();

src/test/java/io/reactivex/internal/operators/flowable/BlockingFlowableToFutureTest.java

@@ -20,6 +20,7 @@
 import java.util.*;
 import java.util.concurrent.*;
 
+import io.reactivex.testsupport.TestHelper;
 import org.junit.*;
 import org.reactivestreams.*;
 
@@ -28,11 +29,6 @@
 import io.reactivex.internal.subscriptions.BooleanSubscription;
 
 public class BlockingFlowableToFutureTest {
-    @Ignore("No separate file")
-    @Test
-    public void constructorShouldBePrivate() {
-//        TestHelper.checkUtilityClass(FlowableToFuture.class);
-    }
 
     @Test
     public void toFuture() throws InterruptedException, ExecutionException {
@@ -50,7 +46,7 @@ public void toFutureList() throws InterruptedException, ExecutionException {
         assertEquals("three", f.get().get(2));
     }
 
-    @Test(/* timeout = 5000, */expected = IndexOutOfBoundsException.class)
+    @Test(expected = IndexOutOfBoundsException.class)
     public void exceptionWithMoreThanOneElement() throws Throwable {
         Flowable<String> obs = Flowable.just("one", "two");
         Future<String> f = obs.toFuture();
@@ -114,12 +110,4 @@ public void getWithEmptyFlowable() throws Throwable {
             throw e.getCause();
         }
     }
-
-    @Ignore("null value is not allowed")
-    @Test
-    public void getWithASingleNullItem() throws Exception {
-        Flowable<String> obs = Flowable.just((String)null);
-        Future<String> f = obs.toFuture();
-        assertNull(f.get());
-    }
 }

src/test/java/io/reactivex/internal/operators/flowable/BlockingFlowableToIteratorTest.java

@@ -17,6 +17,7 @@
 
 import java.util.*;
 
+import io.reactivex.RxJavaTest;
 import org.junit.*;
 import org.reactivestreams.*;
 
@@ -25,7 +26,7 @@
 import io.reactivex.internal.operators.flowable.BlockingFlowableIterable.BlockingFlowableIterator;
 import io.reactivex.internal.subscriptions.BooleanSubscription;
 
-public class BlockingFlowableToIteratorTest {
+public class BlockingFlowableToIteratorTest extends RxJavaTest {
 
     @Test
     public void toIterator() {
@@ -67,28 +68,6 @@ public void subscribe(Subscriber<? super String> subscriber) {
         it.next();
     }
 
-    @Ignore("subscribe() should not throw")
-    @Test(expected = TestException.class)
-    public void exceptionThrownFromOnSubscribe() {
-        Iterable<String> strings = Flowable.unsafeCreate(new Publisher<String>() {
-            @Override
-            public void subscribe(Subscriber<? super String> subscriber) {
-                throw new TestException("intentional");
-            }
-        }).blockingIterable();
-
-        for (String string : strings) {
-            // never reaches here
-            System.out.println(string);
-        }
-    }
-
-    @Ignore("This is not a separate class anymore")
-    @Test
-    public void constructorShouldBePrivate() {
-        // TestHelper.checkUtilityClass(BlockingOperatorToIterator.class);
-    }
-
     @Test
     public void iteratorExertBackpressure() {
         final Counter src = new Counter();

src/test/java/io/reactivex/internal/operators/flowable/BufferUntilSubscriberTest.java

@@ -17,6 +17,7 @@
 import java.util.concurrent.*;
 import java.util.concurrent.atomic.*;
 
+import io.reactivex.RxJavaTest;
 import org.junit.*;
 import org.reactivestreams.Publisher;
 
@@ -25,7 +26,7 @@
 import io.reactivex.processors.PublishProcessor;
 import io.reactivex.schedulers.Schedulers;
 
-public class BufferUntilSubscriberTest {
+public class BufferUntilSubscriberTest extends RxJavaTest {
 
     @Test
     public void issue1677() throws InterruptedException {

src/test/java/io/reactivex/internal/operators/flowable/FlowableAllTest.java

@@ -33,7 +33,7 @@
 import io.reactivex.subscribers.TestSubscriber;
 import io.reactivex.testsupport.*;
 
-public class FlowableAllTest {
+public class FlowableAllTest extends RxJavaTest {
 
     @Test
     public void all() {
@@ -125,7 +125,7 @@ public boolean test(Integer i) {
         assertFalse(allOdd.blockingGet());
     }
 
-    @Test(timeout = 5000)
+    @Test
     public void issue1935NoUnsubscribeDownstream() {
         Flowable<Integer> source = Flowable.just(1)
             .all(new Predicate<Integer>() {
@@ -144,22 +144,6 @@ public Publisher<Integer> apply(Boolean t1) {
         assertEquals((Object)2, source.blockingFirst());
     }
 
-    @Test
-    @Ignore("No backpressure in Single")
-    public void backpressureIfNoneRequestedNoneShouldBeDelivered() {
-        TestObserver<Boolean> to = new TestObserver<Boolean>();
-        Flowable.empty().all(new Predicate<Object>() {
-            @Override
-            public boolean test(Object t1) {
-                return false;
-            }
-        }).subscribe(to);
-
-        to.assertNoValues();
-        to.assertNoErrors();
-        to.assertNotComplete();
-    }
-
     @Test
     public void backpressureIfOneRequestedOneShouldBeDelivered() {
         TestObserverEx<Boolean> to = new TestObserverEx<Boolean>();
@@ -299,7 +283,7 @@ public boolean test(Integer i) {
         assertFalse(allOdd.blockingFirst());
     }
 
-    @Test(timeout = 5000)
+    @Test
     public void issue1935NoUnsubscribeDownstreamFlowable() {
         Flowable<Integer> source = Flowable.just(1)
             .all(new Predicate<Integer>() {