Change to a single 'get' call

zsxwing · zsxwing · commit 29b5150d0659 · 2014-03-10T23:15:54.000+08:00
diff --git a/rxjava-core/src/main/java/rx/operators/OperatorAmb.java b/rxjava-core/src/main/java/rx/operators/OperatorAmb.java
@@ -158,10 +158,11 @@ public void onError(Throwable e) {
         }
 
         private boolean isSelected() {
-            if (choice.get() == NONE) {
+            int ch = choice.get();
+            if (ch == NONE) {
                 return choice.compareAndSet(NONE, index);
             }
-            return choice.get() == index;
+            return ch == index;
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -158,10 +158,11 @@ public void onError(Throwable e) {`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`private boolean isSelected() {`
`161`		`- if (choice.get() == NONE) {`
	`161`	`+ int ch = choice.get();`
	`162`	`+ if (ch == NONE) {`
`162`	`163`	`return choice.compareAndSet(NONE, index);`
`163`	`164`	`}`
`164`		`- return choice.get() == index;`
	`165`	`+ return ch == index;`
`165`	`166`	`}`
`166`	`167`	`}`
`167`	`168`