overridden onFoo() methods in Subscriber subclasses need their own javadocs (#1849 #1850).

Also: Observer javadocs are a bit too groovy.

Author: DavidMGross

src/main/java/rx/Observer.java

@@ -50,9 +50,9 @@ public interface Observer<T> {
     /**
      * Provides the Observer with a new item to observe.
      * <p>
-     * The {@link Observable} may call this closure 0 or more times.
+     * The {@link Observable} may call this method 0 or more times.
      * <p>
-     * The {@code Observable} will not call this closure again after it calls either {@link #onCompleted} or
+     * The {@code Observable} will not call this method again after it calls either {@link #onCompleted} or
      * {@link #onError}.
      * 
      * @param t

src/main/java/rx/observers/SafeSubscriber.java

@@ -68,6 +68,11 @@ public SafeSubscriber(Subscriber<? super T> actual) {
         this.actual = actual;
     }
 
+    /**
+     * Notifies the Subscriber that the {@code Observable} has finished sending push-based notifications.
+     * <p>
+     * The {@code Observable} will not call this method if it calls {@link #onError}.
+     */
     @Override
     public void onCompleted() {
         if (!done) {
@@ -87,6 +92,15 @@ public void onCompleted() {
         }
     }
 
+    /**
+     * Notifies the Subscriber that the {@code Observable} has experienced an error condition.
+     * <p>
+     * If the {@code Observable} calls this method, it will not thereafter call {@link #onNext} or
+     * {@link #onCompleted}.
+     * 
+     * @param e
+     *          the exception encountered by the Observable
+     */
     @Override
     public void onError(Throwable e) {
         // we handle here instead of another method so we don't add stacks to the frame
@@ -98,6 +112,17 @@ public void onError(Throwable e) {
         }
     }
 
+    /**
+     * Provides the Subscriber with a new item to observe.
+     * <p>
+     * The {@code Observable} may call this method 0 or more times.
+     * <p>
+     * The {@code Observable} will not call this method again after it calls either {@link #onCompleted} or
+     * {@link #onError}.
+     * 
+     * @param args
+     *          the item emitted by the Observable
+     */
     @Override
     public void onNext(T args) {
         try {
@@ -114,7 +139,8 @@ public void onNext(T args) {
     }
 
     /**
-     * The logic for {@code onError} without the {@code isFinished} check so it can be called from within {@code onCompleted}.
+     * The logic for {@code onError} without the {@code isFinished} check so it can be called from within
+     * {@code onCompleted}.
      * 
      * @see <a href="https://github.com/ReactiveX/RxJava/issues/630">the report of this bug</a>
      */

src/main/java/rx/observers/SerializedSubscriber.java

@@ -41,16 +41,41 @@ public SerializedSubscriber(Subscriber<? super T> s) {
         this.s = new SerializedObserver<T>(s);
     }
 
+    /**
+     * Notifies the Subscriber that the {@code Observable} has finished sending push-based notifications.
+     * <p>
+     * The {@code Observable} will not call this method if it calls {@link #onError}.
+     */
     @Override
     public void onCompleted() {
         s.onCompleted();
     }
 
+    /**
+     * Notifies the Subscriber that the {@code Observable} has experienced an error condition.
+     * <p>
+     * If the {@code Observable} calls this method, it will not thereafter call {@link #onNext} or
+     * {@link #onCompleted}.
+     * 
+     * @param e
+     *          the exception encountered by the Observable
+     */
     @Override
     public void onError(Throwable e) {
         s.onError(e);
     }
 
+    /**
+     * Provides the Subscriber with a new item to observe.
+     * <p>
+     * The {@code Observable} may call this method 0 or more times.
+     * <p>
+     * The {@code Observable} will not call this method again after it calls either {@link #onCompleted} or
+     * {@link #onError}.
+     * 
+     * @param t
+     *          the item emitted by the Observable
+     */
     @Override
     public void onNext(T t) {
         s.onNext(t);

src/main/java/rx/observers/TestSubscriber.java

@@ -62,6 +62,11 @@ public void onNext(T t) {
         });
     }
 
+    /**
+     * Notifies the Subscriber that the {@code Observable} has finished sending push-based notifications.
+     * <p>
+     * The {@code Observable} will not call this method if it calls {@link #onError}.
+     */
     @Override
     public void onCompleted() {
         try {
@@ -82,6 +87,15 @@ public List<Notification<T>> getOnCompletedEvents() {
         return testObserver.getOnCompletedEvents();
     }
 
+    /**
+     * Notifies the Subscriber that the {@code Observable} has experienced an error condition.
+     * <p>
+     * If the {@code Observable} calls this method, it will not thereafter call {@link #onNext} or
+     * {@link #onCompleted}.
+     * 
+     * @param e
+     *          the exception encountered by the Observable
+     */
     @Override
     public void onError(Throwable e) {
         try {
@@ -102,6 +116,17 @@ public List<Throwable> getOnErrorEvents() {
         return testObserver.getOnErrorEvents();
     }
 
+    /**
+     * Provides the Subscriber with a new item to observe.
+     * <p>
+     * The {@code Observable} may call this method 0 or more times.
+     * <p>
+     * The {@code Observable} will not call this method again after it calls either {@link #onCompleted} or
+     * {@link #onError}.
+     * 
+     * @param t
+     *          the item emitted by the Observable
+     */
     @Override
     public void onNext(T t) {
         lastSeenThread = Thread.currentThread();