Merge pull request #1747 from akarnokd/Cleanup_Utility_Classes

Cleanup: final and utility classes

Author: benjchristensen

src/main/java/rx/Notification.java

@@ -20,7 +20,7 @@
  * 
  * @see <a href="http://msdn.microsoft.com/en-us/library/hh229462.aspx">the Microsoft Rx equivalent</a>
  */
-public class Notification<T> {
+public final class Notification<T> {
 
     private final Kind kind;
     private final Throwable throwable;

src/main/java/rx/exceptions/Exceptions.java

@@ -21,7 +21,7 @@
 /**
  * @warn javadoc class description missing
  */
-public class Exceptions {
+public final class Exceptions {
     private Exceptions() {
 
     }

src/main/java/rx/exceptions/OnErrorThrowable.java

@@ -21,7 +21,7 @@
  * recover more information from an {@code OnErrorThrowable} than is found in a typical {@code Throwable}, such
  * as the item the {@code Observable} was trying to emit at the time the error was encountered.
  */
-public class OnErrorThrowable extends RuntimeException {
+public final class OnErrorThrowable extends RuntimeException {
 
     private static final long serialVersionUID = -569558213262703934L;
 

src/main/java/rx/functions/Functions.java

@@ -15,7 +15,10 @@
  */
 package rx.functions;
 
-public class Functions {
+public final class Functions {
+    private Functions() {
+        throw new IllegalStateException("No instances!");
+    }
 
     /**
      * Converts a {@link Func0} to a {@link FuncN} to allow heterogeneous handling of functions with different

src/main/java/rx/internal/operators/BlockingOperatorMostRecent.java

@@ -29,7 +29,9 @@
  * <img width="640" src="https://github.com/ReactiveX/RxJava/wiki/images/rx-operators/B.mostRecent.png" alt="">
  */
 public final class BlockingOperatorMostRecent {
-
+    private BlockingOperatorMostRecent() {
+        throw new IllegalStateException("No instances!");
+    }
     /**
      * Returns an {@code Iterable} that always returns the item most recently emitted by the {@code Observable}.
      *
@@ -58,7 +60,7 @@ public Iterator<T> iterator() {
         };
     }
 
-    private static class MostRecentObserver<T> extends Subscriber<T> {
+    private static final class MostRecentObserver<T> extends Subscriber<T> {
         final NotificationLite<T> nl = NotificationLite.instance();
         volatile Object value;
 

src/main/java/rx/internal/operators/BlockingOperatorNext.java

@@ -33,6 +33,9 @@
  * <img width="640" src="https://github.com/ReactiveX/RxJava/wiki/images/rx-operators/B.next.png" alt="">
  */
 public final class BlockingOperatorNext {
+    private BlockingOperatorNext() {
+        throw new IllegalStateException("No instances!");
+    }
 
     /**
      * Returns an {@code Iterable} that blocks until the {@code Observable} emits another item, then returns

src/main/java/rx/internal/operators/BlockingOperatorToFuture.java

@@ -35,8 +35,10 @@
  * The toFuture operation throws an exception if the Observable emits more than one item. If the
  * Observable may emit more than item, use <code>toList().toFuture()</code>.
  */
-public class BlockingOperatorToFuture {
-
+public final class BlockingOperatorToFuture {
+    private BlockingOperatorToFuture() {
+        throw new IllegalStateException("No instances!");
+    }
     /**
      * Returns a Future that expects a single item from the observable.
      * 

src/main/java/rx/internal/operators/BlockingOperatorToIterator.java

@@ -34,7 +34,10 @@
  * 
  * @see <a href="https://github.com/ReactiveX/RxJava/issues/50">Issue #50</a>
  */
-public class BlockingOperatorToIterator {
+public final class BlockingOperatorToIterator {
+    private BlockingOperatorToIterator() {
+        throw new IllegalStateException("No instances!");
+    }
 
     /**
      * Returns an iterator that iterates all values of the observable.

src/main/java/rx/internal/operators/BufferUntilSubscriber.java

@@ -48,7 +48,7 @@
  * @param <T>
  *            the type of the items to be buffered
  */
-public class BufferUntilSubscriber<T> extends Subject<T, T> {
+public final class BufferUntilSubscriber<T> extends Subject<T, T> {
 
     /**
      * @warn create() undescribed

src/main/java/rx/internal/operators/OnSubscribeToObservableFuture.java

@@ -34,7 +34,11 @@
  * This is blocking so the {@code Subscription} returned when calling
  * {@code Observable.unsafeSubscribe(Observer)} does nothing.
  */
-public class OnSubscribeToObservableFuture {
+public final class OnSubscribeToObservableFuture {
+    private OnSubscribeToObservableFuture() {
+        throw new IllegalStateException("No instances!");
+    }
+
     /* package accessible for unit tests */static class ToObservableFuture<T> implements OnSubscribe<T> {
         private final Future<? extends T> that;
         private final long time;