Skip to content

Commit 6a858c4

Browse files
committed
Kotlin M7, minor fixes, compatibility with 0.17.0
1 parent 7a85774 commit 6a858c4

File tree

4 files changed

+27
-26
lines changed

4 files changed

+27
-26
lines changed

language-adaptors/rxjava-kotlin/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ buildscript {
44
}
55

66
dependencies {
7-
classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:0.6.1673'
7+
classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:0.7.270'
88
}
99
}
1010

@@ -13,7 +13,7 @@ apply plugin: 'osgi'
1313

1414
dependencies {
1515
compile project(':rxjava-core')
16-
compile 'org.jetbrains.kotlin:kotlin-stdlib:0.6.1673'
16+
compile 'org.jetbrains.kotlin:kotlin-stdlib:0.7.270'
1717
provided 'junit:junit-dep:4.10'
1818
provided 'org.mockito:mockito-core:1.8.5'
1919
}

language-adaptors/rxjava-kotlin/src/main/kotlin/rx/lang/kotlin/namespace.kt

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,16 @@ import rx.Observable
2121
import rx.Observable.OnSubscribe
2222
import rx.Subscription
2323
import rx.Observable.OnSubscribeFunc
24+
import rx.Subscriber
2425

2526

26-
public fun<T> Function1<Observer<in T>, Unit>.asObservable(): Observable<T> {
27-
return Observable.create(OnSubscribe<T>{ t1 ->
28-
this(t1!!)
27+
public fun<T> Function1<Subscriber<in T>, Unit>.asObservable(): Observable<T> {
28+
val v = this
29+
return Observable.create(object:OnSubscribe<T> {
30+
override fun call(t1: Subscriber<in T>?) {
31+
v(t1!!)
32+
}
33+
2934
})!!
3035
}
3136

language-adaptors/rxjava-kotlin/src/test/kotlin/rx/lang/kotlin/BasicKotlinTests.kt

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,7 @@
1616

1717
package rx.lang.kotlin
1818

19-
import org.mockito.Mock
2019
import rx.Observable
21-
import org.junit.Before
22-
import org.mockito.MockitoAnnotations
2320
import org.junit.Test
2421
import rx.subscriptions.Subscriptions
2522
import org.mockito.Mockito.*
@@ -31,21 +28,23 @@ import rx.Subscription
3128
import kotlin.concurrent.thread
3229
import rx.Observable.OnSubscribeFunc
3330
import rx.lang.kotlin.BasicKotlinTests.AsyncObservable
31+
import rx.Observable.OnSubscribe
32+
import rx.Subscriber
3433

3534
/**
3635
* This class use plain Kotlin without extensions from the language adaptor
3736
*/
38-
public class BasicKotlinTests:KotlinTests() {
39-
37+
public class BasicKotlinTests : KotlinTests() {
4038

4139

4240
[Test]
4341
public fun testCreate() {
4442

45-
Observable.create(OnSubscribeFunc<String> {
46-
it!!.onNext("Hello")
47-
it.onCompleted()
48-
Subscriptions.empty()
43+
Observable.create(object:OnSubscribe<String> {
44+
override fun call(subscriber: Subscriber<in String>?) {
45+
subscriber!!.onNext("Hello")
46+
subscriber.onCompleted()
47+
}
4948
})!!.subscribe { result ->
5049
a!!.received(result)
5150
}
@@ -310,7 +309,7 @@ public class BasicKotlinTests:KotlinTests() {
310309

311310

312311

313-
public class TestFactory(){
312+
public class TestFactory() {
314313
var counter = 1
315314

316315
val numbers: Observable<Int>
@@ -330,7 +329,7 @@ public class BasicKotlinTests:KotlinTests() {
330329

331330
}
332331

333-
class AsyncObservable : OnSubscribeFunc<Int>{
332+
class AsyncObservable : OnSubscribeFunc<Int> {
334333
override fun onSubscribe(op: Observer<in Int>?): Subscription? {
335334
thread {
336335
Thread.sleep(50)
@@ -343,7 +342,7 @@ public class BasicKotlinTests:KotlinTests() {
343342
}
344343
}
345344

346-
class TestOnSubscribe(val count: Int) : OnSubscribeFunc<String>{
345+
class TestOnSubscribe(val count: Int) : OnSubscribeFunc<String> {
347346
override fun onSubscribe(op: Observer<in String>?): Subscription? {
348347
op!!.onNext("hello_$count")
349348
op.onCompleted()

language-adaptors/rxjava-kotlin/src/test/kotlin/rx/lang/kotlin/ExtensionTests.kt

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,7 @@
1616

1717
package rx.lang.kotlin
1818

19-
import org.mockito.Mock
2019
import rx.Observable
21-
import org.junit.Before
22-
import org.mockito.MockitoAnnotations
2320
import org.junit.Test
2421
import rx.subscriptions.Subscriptions
2522
import org.mockito.Mockito.*
@@ -29,6 +26,7 @@ import org.junit.Assert.*
2926
import rx.Notification
3027
import rx.Subscription
3128
import kotlin.concurrent.thread
29+
import rx.Subscriber
3230

3331
/**
3432
* This class contains tests using the extension functions provided by the language adaptor.
@@ -39,11 +37,10 @@ public class ExtensionTests : KotlinTests() {
3937
[Test]
4038
public fun testCreate() {
4139

42-
{(observer: Observer<in String>) ->
43-
observer.onNext("Hello")
44-
observer.onCompleted()
45-
Subscriptions.empty()!!
46-
}.asObservableFunc().subscribe { result ->
40+
{(subscriber: Subscriber<in String>) ->
41+
subscriber.onNext("Hello")
42+
subscriber.onCompleted()
43+
}.asObservable().subscribe { result ->
4744
a!!.received(result)
4845
}
4946

@@ -283,7 +280,7 @@ public class ExtensionTests : KotlinTests() {
283280
return {(p2: P2) -> this(p1, p2) }
284281
}
285282

286-
inner public class TestFactory(){
283+
inner public class TestFactory() {
287284
var counter = 1
288285

289286
val numbers: Observable<Int>

0 commit comments

Comments
 (0)