Skip to content

Commit 6de7fd1

Browse files
Move last 6 remaining unit tests out.
1 parent 6ec81df commit 6de7fd1

File tree

4 files changed

+130
-105
lines changed

4 files changed

+130
-105
lines changed

rxjava-core/src/main/java/rx/operators/OperationToFuture.java

Lines changed: 0 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,16 @@
1515
*/
1616
package rx.operators;
1717

18-
import static org.junit.Assert.*;
19-
20-
import java.util.List;
2118
import java.util.concurrent.CountDownLatch;
2219
import java.util.concurrent.ExecutionException;
2320
import java.util.concurrent.Future;
2421
import java.util.concurrent.TimeUnit;
2522
import java.util.concurrent.TimeoutException;
2623
import java.util.concurrent.atomic.AtomicReference;
2724

28-
import org.junit.Test;
29-
3025
import rx.Observable;
31-
import rx.Observable.OnSubscribeFunc;
3226
import rx.Observer;
3327
import rx.Subscription;
34-
import rx.subscriptions.Subscriptions;
3528

3629
/**
3730
* Returns a Future representing the single value emitted by an Observable.
@@ -136,52 +129,4 @@ private T getValue() throws ExecutionException {
136129

137130
}
138131

139-
@Test
140-
public void testToFuture() throws InterruptedException, ExecutionException {
141-
Observable<String> obs = Observable.from("one");
142-
Future<String> f = toFuture(obs);
143-
assertEquals("one", f.get());
144-
}
145-
146-
@Test
147-
public void testToFutureList() throws InterruptedException, ExecutionException {
148-
Observable<String> obs = Observable.from("one", "two", "three");
149-
Future<List<String>> f = toFuture(obs.toList());
150-
assertEquals("one", f.get().get(0));
151-
assertEquals("two", f.get().get(1));
152-
assertEquals("three", f.get().get(2));
153-
}
154-
155-
@Test(expected = ExecutionException.class)
156-
public void testExceptionWithMoreThanOneElement() throws InterruptedException, ExecutionException {
157-
Observable<String> obs = Observable.from("one", "two");
158-
Future<String> f = toFuture(obs);
159-
assertEquals("one", f.get());
160-
// we expect an exception since there are more than 1 element
161-
}
162-
163-
@Test
164-
public void testToFutureWithException() {
165-
Observable<String> obs = Observable.create(new OnSubscribeFunc<String>() {
166-
167-
@Override
168-
public Subscription onSubscribe(Observer<? super String> observer) {
169-
observer.onNext("one");
170-
observer.onError(new TestException());
171-
return Subscriptions.empty();
172-
}
173-
});
174-
175-
Future<String> f = toFuture(obs);
176-
try {
177-
f.get();
178-
fail("expected exception");
179-
} catch (Throwable e) {
180-
assertEquals(TestException.class, e.getCause().getClass());
181-
}
182-
}
183-
184-
private static class TestException extends RuntimeException {
185-
private static final long serialVersionUID = 1L;
186-
}
187132
}

rxjava-core/src/main/java/rx/operators/OperationToIterator.java

Lines changed: 0 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -15,20 +15,13 @@
1515
*/
1616
package rx.operators;
1717

18-
import static org.junit.Assert.*;
19-
2018
import java.util.Iterator;
2119
import java.util.concurrent.BlockingQueue;
2220
import java.util.concurrent.LinkedBlockingQueue;
2321

24-
import org.junit.Test;
25-
2622
import rx.Notification;
2723
import rx.Observable;
28-
import rx.Observable.OnSubscribeFunc;
2924
import rx.Observer;
30-
import rx.Subscription;
31-
import rx.subscriptions.Subscriptions;
3225
import rx.util.Exceptions;
3326

3427
/**
@@ -108,47 +101,4 @@ public void remove() {
108101
};
109102
}
110103

111-
@Test
112-
public void testToIterator() {
113-
Observable<String> obs = Observable.from("one", "two", "three");
114-
115-
Iterator<String> it = toIterator(obs);
116-
117-
assertEquals(true, it.hasNext());
118-
assertEquals("one", it.next());
119-
120-
assertEquals(true, it.hasNext());
121-
assertEquals("two", it.next());
122-
123-
assertEquals(true, it.hasNext());
124-
assertEquals("three", it.next());
125-
126-
assertEquals(false, it.hasNext());
127-
128-
}
129-
130-
@Test(expected = TestException.class)
131-
public void testToIteratorWithException() {
132-
Observable<String> obs = Observable.create(new OnSubscribeFunc<String>() {
133-
134-
@Override
135-
public Subscription onSubscribe(Observer<? super String> observer) {
136-
observer.onNext("one");
137-
observer.onError(new TestException());
138-
return Subscriptions.empty();
139-
}
140-
});
141-
142-
Iterator<String> it = toIterator(obs);
143-
144-
assertEquals(true, it.hasNext());
145-
assertEquals("one", it.next());
146-
147-
assertEquals(true, it.hasNext());
148-
it.next();
149-
}
150-
151-
private static class TestException extends RuntimeException {
152-
private static final long serialVersionUID = 1L;
153-
}
154104
}
Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,68 @@
1+
package rx.operators;
2+
3+
import static org.junit.Assert.*;
4+
import static rx.operators.OperationToFuture.*;
5+
6+
import java.util.List;
7+
import java.util.concurrent.ExecutionException;
8+
import java.util.concurrent.Future;
9+
10+
import org.junit.Test;
11+
12+
import rx.Observable;
13+
import rx.Observable.OnSubscribeFunc;
14+
import rx.Observer;
15+
import rx.Subscription;
16+
import rx.subscriptions.Subscriptions;
17+
18+
public class OperationToFutureTest {
19+
20+
@Test
21+
public void testToFuture() throws InterruptedException, ExecutionException {
22+
Observable<String> obs = Observable.from("one");
23+
Future<String> f = toFuture(obs);
24+
assertEquals("one", f.get());
25+
}
26+
27+
@Test
28+
public void testToFutureList() throws InterruptedException, ExecutionException {
29+
Observable<String> obs = Observable.from("one", "two", "three");
30+
Future<List<String>> f = toFuture(obs.toList());
31+
assertEquals("one", f.get().get(0));
32+
assertEquals("two", f.get().get(1));
33+
assertEquals("three", f.get().get(2));
34+
}
35+
36+
@Test(expected = ExecutionException.class)
37+
public void testExceptionWithMoreThanOneElement() throws InterruptedException, ExecutionException {
38+
Observable<String> obs = Observable.from("one", "two");
39+
Future<String> f = toFuture(obs);
40+
assertEquals("one", f.get());
41+
// we expect an exception since there are more than 1 element
42+
}
43+
44+
@Test
45+
public void testToFutureWithException() {
46+
Observable<String> obs = Observable.create(new OnSubscribeFunc<String>() {
47+
48+
@Override
49+
public Subscription onSubscribe(Observer<? super String> observer) {
50+
observer.onNext("one");
51+
observer.onError(new TestException());
52+
return Subscriptions.empty();
53+
}
54+
});
55+
56+
Future<String> f = toFuture(obs);
57+
try {
58+
f.get();
59+
fail("expected exception");
60+
} catch (Throwable e) {
61+
assertEquals(TestException.class, e.getCause().getClass());
62+
}
63+
}
64+
65+
private static class TestException extends RuntimeException {
66+
private static final long serialVersionUID = 1L;
67+
}
68+
}
Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,62 @@
1+
package rx.operators;
2+
3+
import static org.junit.Assert.*;
4+
import static rx.operators.OperationToIterator.*;
5+
6+
import java.util.Iterator;
7+
8+
import org.junit.Test;
9+
10+
import rx.Observable;
11+
import rx.Observable.OnSubscribeFunc;
12+
import rx.Observer;
13+
import rx.Subscription;
14+
import rx.subscriptions.Subscriptions;
15+
16+
public class OperationToIteratorTest {
17+
18+
@Test
19+
public void testToIterator() {
20+
Observable<String> obs = Observable.from("one", "two", "three");
21+
22+
Iterator<String> it = toIterator(obs);
23+
24+
assertEquals(true, it.hasNext());
25+
assertEquals("one", it.next());
26+
27+
assertEquals(true, it.hasNext());
28+
assertEquals("two", it.next());
29+
30+
assertEquals(true, it.hasNext());
31+
assertEquals("three", it.next());
32+
33+
assertEquals(false, it.hasNext());
34+
35+
}
36+
37+
@Test(expected = TestException.class)
38+
public void testToIteratorWithException() {
39+
Observable<String> obs = Observable.create(new OnSubscribeFunc<String>() {
40+
41+
@Override
42+
public Subscription onSubscribe(Observer<? super String> observer) {
43+
observer.onNext("one");
44+
observer.onError(new TestException());
45+
return Subscriptions.empty();
46+
}
47+
});
48+
49+
Iterator<String> it = toIterator(obs);
50+
51+
assertEquals(true, it.hasNext());
52+
assertEquals("one", it.next());
53+
54+
assertEquals(true, it.hasNext());
55+
it.next();
56+
}
57+
58+
private static class TestException extends RuntimeException {
59+
private static final long serialVersionUID = 1L;
60+
}
61+
62+
}

0 commit comments

Comments
 (0)