Merge pull request #2547 from davidmoten/fix-more-warnings

Warnings cleanup

Author: akarnokd

src/main/java/rx/exceptions/OnErrorThrowable.java

@@ -148,7 +148,7 @@ private static String renderValue(Object value){
                 return (String) value;
             }
             if (value instanceof Enum) {
-                return ((Enum) value).name();
+                return ((Enum<?>) value).name();
             }
             return value.getClass().getName() + ".class";
         }

src/main/java/rx/functions/Actions.java

@@ -15,8 +15,6 @@
  */
 package rx.functions;
 
-import rx.Observer;
-
 /**
  * Utility class for the Action interfaces.
  */

src/main/java/rx/internal/operators/BlockingOperatorNext.java

@@ -147,6 +147,7 @@ public void remove() {
 
     private static class NextObserver<T> extends Subscriber<Notification<? extends T>> {
         private final BlockingQueue<Notification<? extends T>> buf = new ArrayBlockingQueue<Notification<? extends T>>(1);
+        @SuppressWarnings("unused")
         volatile int waiting;
         @SuppressWarnings("rawtypes")
         static final AtomicIntegerFieldUpdater<NextObserver> WAITING_UPDATER

src/main/java/rx/internal/operators/OnSubscribeCache.java

@@ -20,7 +20,6 @@
 import rx.Observable;
 import rx.Observable.OnSubscribe;
 import rx.Subscriber;
-import rx.observers.Subscribers;
 import rx.subjects.ReplaySubject;
 import rx.subjects.Subject;
 

src/main/java/rx/internal/operators/OperatorGroupBy.java

@@ -15,12 +15,10 @@
  */
 package rx.internal.operators;
 
-import java.util.Map;
 import java.util.Queue;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ConcurrentLinkedQueue;
 import java.util.concurrent.atomic.AtomicBoolean;
-import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicIntegerFieldUpdater;
 import java.util.concurrent.atomic.AtomicLong;
 import java.util.concurrent.atomic.AtomicLongFieldUpdater;
@@ -206,6 +204,7 @@ private Object groupedKey(K key) {
             return key == null ? NULL_KEY : key;
         }
 
+        @SuppressWarnings("unchecked")
         private K getKey(Object groupedKey) {
             return groupedKey == NULL_KEY ? null : (K) groupedKey;
         }

src/main/java/rx/internal/operators/OperatorObserveOn.java

@@ -72,10 +72,12 @@ private static final class ObserveOnSubscriber<T> extends Subscriber<T> {
         private boolean completed = false;
         private boolean failure = false;
 
+        @SuppressWarnings("unused")
         private volatile long requested = 0;
         @SuppressWarnings("rawtypes")
         static final AtomicLongFieldUpdater<ObserveOnSubscriber> REQUESTED = AtomicLongFieldUpdater.newUpdater(ObserveOnSubscriber.class, "requested");
 
+        @SuppressWarnings("unused")
         volatile long counter;
         @SuppressWarnings("rawtypes")
         static final AtomicLongFieldUpdater<ObserveOnSubscriber> COUNTER_UPDATER = AtomicLongFieldUpdater.newUpdater(ObserveOnSubscriber.class, "counter");

src/main/java/rx/internal/operators/OperatorPublish.java

@@ -16,7 +16,6 @@
 package rx.internal.operators;
 
 import java.util.ArrayList;
-import java.util.HashMap;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
@@ -266,6 +265,7 @@ public synchronized void removeSubscriber(Subscriber<? super T> subscriber) {
             resetAfterSubscriberUpdate();
         }
 
+        @SuppressWarnings("unchecked")
         private long resetAfterSubscriberUpdate() {
             subscribers = new Subscriber[ss.size()];
             int i = 0;

src/main/java/rx/internal/operators/OperatorScan.java

@@ -23,7 +23,6 @@
 import rx.exceptions.OnErrorThrowable;
 import rx.functions.Func0;
 import rx.functions.Func2;
-import rx.internal.util.UtilityFunctions;
 
 /**
  * Returns an Observable that applies a function to the first item emitted by a source Observable, then feeds

src/main/java/rx/observables/BlockingObservable.java

@@ -26,7 +26,6 @@
 import rx.Subscription;
 import rx.functions.Action1;
 import rx.functions.Func1;
-import rx.functions.Functions;
 import rx.internal.operators.BlockingOperatorLatest;
 import rx.internal.operators.BlockingOperatorMostRecent;
 import rx.internal.operators.BlockingOperatorNext;

src/main/java/rx/schedulers/CachedThreadScheduler.java

@@ -110,6 +110,7 @@ public Worker createWorker() {
     private static final class EventLoopWorker extends Scheduler.Worker {
         private final CompositeSubscription innerSubscription = new CompositeSubscription();
         private final ThreadWorker threadWorker;
+        @SuppressWarnings("unused")
         volatile int once;
         static final AtomicIntegerFieldUpdater<EventLoopWorker> ONCE_UPDATER
                 = AtomicIntegerFieldUpdater.newUpdater(EventLoopWorker.class, "once");