Skip to content

Commit 843a57e

Browse files
authored
1.x: rework Single internals to reduce overhead and stack depth (#4648)
* 1.x: rework Single internals to reduce overhead and stack depth * Remove auto-gen TODO, mark Single(Observable.OnSubscribe) deprecated
1 parent 09b1389 commit 843a57e

27 files changed

+1271
-374
lines changed

src/main/java/rx/Completable.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -540,6 +540,7 @@ public void call(rx.CompletableSubscriber s) {
540540
* @return the new Completable instance
541541
* @since (if this graduates from Experimental/Beta to supported, replace this parenthetical with the release number)
542542
*/
543+
@SuppressWarnings("deprecation")
543544
@Experimental
544545
public static Completable fromEmitter(Action1<CompletableEmitter> producer) {
545546
return create(new CompletableFromEmitter(producer));

src/main/java/rx/Observable.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2016,15 +2016,15 @@ public static <T> Observable<T> from(T[] array) {
20162016
* @see AsyncEmitter.BackpressureMode
20172017
* @see AsyncEmitter.Cancellable
20182018
* @since (if this graduates from Experimental/Beta to supported, replace this parenthetical with the release number)
2019-
* @deprecated since 1.2.1 because Async prefix of AsyncEmitter class is potentially misleading. Use
2019+
* @deprecated since 1.2.1 because Async prefix of AsyncEmitter class is potentially misleading. Use
20202020
* {@link #fromEmitter(Action1, Emitter.BackpressureMode)} instead.
20212021
*/
20222022
@Experimental
20232023
@Deprecated
20242024
public static <T> Observable<T> fromEmitter(Action1<AsyncEmitter<T>> emitter, AsyncEmitter.BackpressureMode backpressure) {
20252025
return create(new OnSubscribeFromAsyncEmitter<T>(emitter, backpressure));
20262026
}
2027-
2027+
20282028
/**
20292029
* Provides an API (via a cold Observable) that bridges the reactive world with the callback-style,
20302030
* generally non-backpressured world.
@@ -2063,7 +2063,7 @@ public static <T> Observable<T> fromEmitter(Action1<AsyncEmitter<T>> emitter, As
20632063
* @return the new Observable instance
20642064
* @see Emitter
20652065
* @see Emitter.BackpressureMode
2066-
* @see Emitter.Cancellable
2066+
* @see rx.functions.Cancellable
20672067
* @since (if this graduates from Experimental/Beta to supported, replace this parenthetical with the release number)
20682068
*/
20692069
@Experimental

0 commit comments

Comments
 (0)