Skip to content

Commit 9d319bc

Browse files
committed
Update CompletenessTest
1 parent 59ebdb2 commit 9d319bc

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

language-adaptors/rxjava-scala/src/test/scala/rx/lang/scala/CompletenessTest.scala

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ class CompletenessTest extends JUnitSuite {
7979
"firstOrDefault(T)" -> "firstOrElse(=> U)",
8080
"firstOrDefault(Func1[_ >: T, Boolean], T)" -> "[use `.filter(condition).firstOrElse(default)`]",
8181
"groupBy(Func1[_ >: T, _ <: K], Func1[_ >: T, _ <: R])" -> "[use `groupBy` and `map`]",
82+
"lift(Operator[_ <: R, _ >: T])" -> "lift(Subscriber[R] => Subscriber[_ >: T])",
8283
"mapMany(Func1[_ >: T, _ <: Observable[_ <: R]])" -> "flatMap(T => Observable[R])",
8384
"mapWithIndex(Func2[_ >: T, Integer, _ <: R])" -> "[combine `zipWithIndex` with `map` or with a for comprehension]",
8485
"onErrorResumeNext(Func1[Throwable, _ <: Observable[_ <: T]])" -> "onErrorResumeNext(Throwable => Observable[U])",
@@ -89,16 +90,28 @@ class CompletenessTest extends JUnitSuite {
8990
"parallel(Func1[Observable[T], Observable[R]], Scheduler)" -> "parallel(Observable[T] => Observable[R], Scheduler)",
9091
"reduce(Func2[T, T, T])" -> "reduce((U, U) => U)",
9192
"reduce(R, Func2[R, _ >: T, R])" -> "foldLeft(R)((R, T) => R)",
93+
"retry()" -> "retry()",
9294
"scan(Func2[T, T, T])" -> unnecessary,
9395
"scan(R, Func2[R, _ >: T, R])" -> "scan(R)((R, T) => R)",
9496
"skip(Int)" -> "drop(Int)",
97+
"skip(Long, TimeUnit)" -> "drop(Duration)",
98+
"skip(Long, TimeUnit, Scheduler)" -> "drop(Duration, Scheduler)",
9599
"skipWhile(Func1[_ >: T, Boolean])" -> "dropWhile(T => Boolean)",
96100
"skipWhileWithIndex(Func2[_ >: T, Integer, Boolean])" -> unnecessary,
97101
"startWith(Iterable[T])" -> "[unnecessary because we can just use `++` instead]",
102+
"skipLast(Int)" -> "dropRight(Int)",
103+
"skipLast(Long, TimeUnit)" -> "dropRight(Duration)",
104+
"skipLast(Long, TimeUnit, Scheduler)" -> "dropRight(Duration, Scheduler)",
98105
"takeFirst()" -> "first",
99106
"takeFirst(Func1[_ >: T, Boolean])" -> commentForFirstWithPredicate,
100107
"takeLast(Int)" -> "takeRight(Int)",
101108
"takeWhileWithIndex(Func2[_ >: T, _ >: Integer, Boolean])" -> "[use `.zipWithIndex.takeWhile{case (elem, index) => condition}.map(_._1)`]",
109+
"timeout(Func0[_ <: Observable[U]], Func1[_ >: T, _ <: Observable[V]], Observable[_ <: T])" -> "timeout(() => Observable[U], T => Observable[V], Observable[O])",
110+
"timeout(Func1[_ >: T, _ <: Observable[V]], Observable[_ <: T])" -> "timeout(() => Observable[U], T => Observable[V])",
111+
"timeout(Long, TimeUnit, Observable[_ <: T])" -> "timeout(Duration, Observable[U])",
112+
"timeout(Long, TimeUnit, Observable[_ <: T], Scheduler)" -> "timeout(Duration, Observable[U], Scheduler)",
113+
"timer(Long, Long, TimeUnit)" -> "timer(Duration, Duration)",
114+
"timer(Long, Long, TimeUnit, Scheduler)" -> "timer(Duration, Duration, Scheduler)",
102115
"toList()" -> "toSeq",
103116
"toSortedList()" -> "[Sorting is already done in Scala's collection library, use `.toSeq.map(_.sorted)`]",
104117
"toSortedList(Func2[_ >: T, _ >: T, Integer])" -> "[Sorting is already done in Scala's collection library, use `.toSeq.map(_.sortWith(f))`]",

0 commit comments

Comments
 (0)