3.x: Add NonNull & SafeVarargs annotations + validator (#6791)

Author: akarnokd

src/main/java/io/reactivex/rxjava3/core/Completable.java

@@ -27,7 +27,7 @@ public final class Notification<T> {
     final Object value;
 
     /** Not meant to be implemented externally. */
-    private Notification(Object value) {
+    private Notification(@Nullable Object value) {
         this.value = value;
     }
 

src/main/java/io/reactivex/rxjava3/core/Flowable.java

@@ -483,7 +483,6 @@ public void mergeArrayNull() {
         Flowable.mergeArray(128, 128, (Publisher<Object>[])null);
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void mergeArrayOneIsNull() {
         Flowable.mergeArray(128, 128, just1, null).blockingLast();
@@ -514,7 +513,6 @@ public void mergeDelayErrorArrayNull() {
         Flowable.mergeArrayDelayError(128, 128, (Publisher<Object>[])null);
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void mergeDelayErrorArrayOneIsNull() {
         Flowable.mergeArrayDelayError(128, 128, just1, null).blockingLast();

src/main/java/io/reactivex/rxjava3/core/Maybe.java

@@ -1210,7 +1210,6 @@ public void arrayDelayErrorMaxConcurrency() {
         PublishProcessor<Integer> pp2 = PublishProcessor.create();
         PublishProcessor<Integer> pp3 = PublishProcessor.create();
 
-        @SuppressWarnings("unchecked")
         TestSubscriber<Integer> ts = Flowable.concatArrayEagerDelayError(2, 2, pp1, pp2, pp3)
         .test();
 
@@ -1246,7 +1245,6 @@ public void arrayDelayErrorMaxConcurrencyErrorDelayed() {
         PublishProcessor<Integer> pp2 = PublishProcessor.create();
         PublishProcessor<Integer> pp3 = PublishProcessor.create();
 
-        @SuppressWarnings("unchecked")
         TestSubscriber<Integer> ts = Flowable.concatArrayEagerDelayError(2, 2, pp1, pp2, pp3)
         .test();
 

src/main/java/io/reactivex/rxjava3/core/Notification.java

@@ -622,7 +622,6 @@ public void array() {
         }
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void mergeArrayDelayError() {
         Flowable.mergeArrayDelayError(Flowable.just(1), Flowable.just(2))

src/main/java/io/reactivex/rxjava3/core/Observable.java

@@ -1518,7 +1518,6 @@ public void array() {
         }
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void mergeArray2() {
         Flowable.mergeArray(Flowable.just(1), Flowable.just(2))