Merge pull request #3651 from artem-zinnatullin/remove-redundant-final

1.x: Remove redundant "final" modifiers

Author: zsxwing

src/main/java/rx/Observable.java

@@ -247,7 +247,7 @@ public String getMessage() {
         }
     }
 
-    private final List<Throwable> getListOfCauses(Throwable ex) {
+    private List<Throwable> getListOfCauses(Throwable ex) {
         List<Throwable> list = new ArrayList<Throwable>();
         Throwable root = ex.getCause();
         if (root == null) {

src/main/java/rx/Single.java

@@ -278,7 +278,7 @@ private static final class AmbSubscriber<T> extends Subscriber<T> {
             request(requested);
         }
 
-        private final void requestMore(long n) {
+        private void requestMore(long n) {
             request(n);
         }
 

src/main/java/rx/exceptions/CompositeException.java

@@ -58,7 +58,7 @@ protected IndexedRingBuffer<?> createObject() {
     };
 
     @SuppressWarnings("unchecked")
-    public final static <T> IndexedRingBuffer<T> getInstance() {
+    public static <T> IndexedRingBuffer<T> getInstance() {
         return (IndexedRingBuffer<T>) POOL.borrowObject();
     }
 

src/main/java/rx/internal/operators/OnSubscribeAmb.java

@@ -78,7 +78,7 @@ static <T> Producer createProducer(Subscriber<? super T> s, T v) {
      * @param t the value to emit when requested
      * @return the new Observable
      */
-    public static final <T> ScalarSynchronousObservable<T> create(T t) {
+    public static <T> ScalarSynchronousObservable<T> create(T t) {
         return new ScalarSynchronousObservable<T>(t);
     }
 

src/main/java/rx/internal/util/IndexedRingBuffer.java

@@ -242,17 +242,17 @@ private void soConsumerIndex(long v) {
         CONSUMER_INDEX.lazySet(this, v);
     }
 
-    private static final int calcWrappedOffset(long index, int mask) {
+    private static int calcWrappedOffset(long index, int mask) {
         return calcDirectOffset((int)index & mask);
     }
-    private static final int calcDirectOffset(int index) {
+    private static int calcDirectOffset(int index) {
         return index;
     }
-    private static final void soElement(AtomicReferenceArray<Object> buffer, int offset, Object e) {
+    private static void soElement(AtomicReferenceArray<Object> buffer, int offset, Object e) {
         buffer.lazySet(offset, e);
     }
 
-    private static final <E> Object lvElement(AtomicReferenceArray<Object> buffer, int offset) {
+    private static <E> Object lvElement(AtomicReferenceArray<Object> buffer, int offset) {
         return buffer.get(offset);
     }
 

src/main/java/rx/internal/util/ScalarSynchronousObservable.java

@@ -243,17 +243,17 @@ private void soConsumerIndex(long v) {
         CONSUMER_INDEX.lazySet(this, v);
     }
 
-    private static final int calcWrappedOffset(long index, int mask) {
+    private static int calcWrappedOffset(long index, int mask) {
         return calcDirectOffset((int)index & mask);
     }
-    private static final int calcDirectOffset(int index) {
+    private static int calcDirectOffset(int index) {
         return index;
     }
-    private static final void soElement(AtomicReferenceArray<Object> buffer, int offset, Object e) {
+    private static void soElement(AtomicReferenceArray<Object> buffer, int offset, Object e) {
         buffer.lazySet(offset, e);
     }
 
-    private static final <E> Object lvElement(AtomicReferenceArray<Object> buffer, int offset) {
+    private static <E> Object lvElement(AtomicReferenceArray<Object> buffer, int offset) {
         return buffer.get(offset);
     }
 

src/main/java/rx/internal/util/atomic/SpscLinkedArrayQueue.java

@@ -264,17 +264,17 @@ private void soConsumerIndex(long v) {
         UNSAFE.putOrderedLong(this, C_INDEX_OFFSET, v);
     }
 
-    private static final long calcWrappedOffset(long index, long mask) {
+    private static long calcWrappedOffset(long index, long mask) {
         return calcDirectOffset(index & mask);
     }
-    private static final long calcDirectOffset(long index) {
+    private static long calcDirectOffset(long index) {
         return REF_ARRAY_BASE + (index << REF_ELEMENT_SHIFT);
     }
-    private static final void soElement(Object[] buffer, long offset, Object e) {
+    private static void soElement(Object[] buffer, long offset, Object e) {
         UNSAFE.putOrderedObject(buffer, offset, e);
     }
 
-    private static final <E> Object lvElement(E[] buffer, long offset) {
+    private static <E> Object lvElement(E[] buffer, long offset) {
         return UNSAFE.getObjectVolatile(buffer, offset);
     }
 

src/main/java/rx/internal/util/atomic/SpscUnboundedAtomicArrayQueue.java

@@ -47,7 +47,7 @@ private UnsafeAccess() {
         UNSAFE = u;
     }
 
-    public static final boolean isUnsafeAvailable() {
+    public static boolean isUnsafeAvailable() {
         return UNSAFE != null;
     }