Skip to content

Commit de7ac42

Browse files
work around scalac bug by renaming companion object Timestamped to TimestampedObject
1 parent 6f56788 commit de7ac42

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

language-adaptors/rxjava-scala/src/examples/scala/rx/lang/scala/examples/RxScalaDemo.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import scala.concurrent.duration._
2222
import org.junit.{Before, Test, Ignore}
2323
import org.junit.Assert._
2424
import rx.lang.scala.concurrency.NewThreadScheduler
25-
import rx.lang.scala.util.Timestamped
25+
import rx.lang.scala.util.{Timestamped, TimestampedObject}
2626

2727
@Ignore // Since this doesn't do automatic testing, don't increase build time unnecessarily
2828
class RxScalaDemo extends JUnitSuite {
@@ -378,7 +378,7 @@ class RxScalaDemo extends JUnitSuite {
378378

379379
@Test def timestampExample() {
380380
val timestamped = Observable.interval(100 millis).take(3).timestamp.toBlockingObservable
381-
for (Timestamped(millis, value) <- timestamped if value > 0) {
381+
for (TimestampedObject(millis, value) <- timestamped if value > 0) {
382382
println(value + " at t = " + millis)
383383
}
384384
}

language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/Observable.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ class Observable[+T](val asJava: rx.Observable[_ <: T])
199199
* @return an Observable that emits timestamped items from the source Observable
200200
*/
201201
def timestamp: Observable[Timestamped[T]] = {
202-
Observable[rx.util.Timestamped[_ <: T]](asJava.timestamp()).map(Timestamped(_))
202+
Observable[rx.util.Timestamped[_ <: T]](asJava.timestamp()).map(TimestampedObject(_))
203203
}
204204

205205
/**

language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/util/package.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ package object util {
4545

4646
class Timestamped[+T](val asJava: rx.util.Timestamped[_ <: T]) {}
4747

48-
object Timestamped {
48+
// TODO rename this to Timestamped without making scalac crash
49+
object TimestampedObject {
4950
def apply[T](timestampMillis: Long, value: T): Timestamped[T] = {
5051
new Timestamped(new rx.util.Timestamped(timestampMillis, value))
5152
}

0 commit comments

Comments
 (0)