Skip to content

Commit f26b7b2

Browse files
Conditionals: Fix all but 2 tests
1 parent e24a23b commit f26b7b2

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

rxjava-contrib/rxjava-computation-expressions/src/test/java/rx/operators/OperationConditionalsTest.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package rx.operators;
1717

18+
import static org.junit.Assert.*;
1819
import static org.mockito.Matchers.*;
1920
import static org.mockito.Mockito.*;
2021

@@ -33,8 +34,10 @@
3334
import rx.Observer;
3435
import rx.Statement;
3536
import rx.Subscription;
37+
import rx.observers.TestObserver;
3638
import rx.schedulers.Schedulers;
3739
import rx.schedulers.TestScheduler;
40+
import rx.util.functions.Action1;
3841
import rx.util.functions.Func0;
3942

4043
public class OperationConditionalsTest {
@@ -108,7 +111,7 @@ public T call() {
108111
<T> void observe(Observable<? extends T> source, T... values) {
109112
Observer<T> o = mock(Observer.class);
110113

111-
Subscription s = source.subscribe(o);
114+
Subscription s = source.subscribe(new TestObserver<T>(o));
112115

113116
InOrder inOrder = inOrder(o);
114117

@@ -127,7 +130,7 @@ <T> void observe(Observable<? extends T> source, T... values) {
127130
<T> void observeSequence(Observable<? extends T> source, Iterable<? extends T> values) {
128131
Observer<T> o = mock(Observer.class);
129132

130-
Subscription s = source.subscribe(o);
133+
Subscription s = source.subscribe(new TestObserver<T>(o));
131134

132135
InOrder inOrder = inOrder(o);
133136

@@ -146,7 +149,7 @@ <T> void observeSequence(Observable<? extends T> source, Iterable<? extends T> v
146149
<T> void observeError(Observable<? extends T> source, Class<? extends Throwable> error, T... valuesBeforeError) {
147150
Observer<T> o = mock(Observer.class);
148151

149-
Subscription s = source.subscribe(o);
152+
Subscription s = source.subscribe(new TestObserver<T>(o));
150153

151154
InOrder inOrder = inOrder(o);
152155

@@ -165,7 +168,7 @@ <T> void observeError(Observable<? extends T> source, Class<? extends Throwable>
165168
<T> void observeSequenceError(Observable<? extends T> source, Class<? extends Throwable> error, Iterable<? extends T> valuesBeforeError) {
166169
Observer<T> o = mock(Observer.class);
167170

168-
Subscription s = source.subscribe(o);
171+
Subscription s = source.subscribe(new TestObserver<T>(o));
169172

170173
InOrder inOrder = inOrder(o);
171174

@@ -400,6 +403,7 @@ public Boolean call() {
400403

401404
@Test
402405
public void testDoWhileManyTimes() {
406+
fail("deadlocking");
403407
Observable<Integer> source1 = Observable.from(1, 2, 3).subscribeOn(Schedulers.currentThread());
404408

405409
List<Integer> expected = new ArrayList<Integer>(numRecursion * 3);

0 commit comments

Comments
 (0)