Rename test methods and enable the check (#6528)

* Rename test methods

* Enable TestPrefixInMethodName check

Author: maksim-m

src/test/java/io/reactivex/completable/CompletableTest.java

@@ -3786,7 +3786,7 @@ public void after() {
     }
 
     @Test
-    public void testHookCreate() throws Throwable {
+    public void hookCreate() throws Throwable {
         CompletableSource subscriber = mock(CompletableSource.class);
         Completable create = Completable.unsafeCreate(subscriber);
 
@@ -4200,7 +4200,7 @@ public void onSubscribe(Subscription s) {
     }
 
     @Test
-    public void testHookSubscribeStart() throws Throwable {
+    public void hookSubscribeStart() throws Throwable {
         TestSubscriber<String> ts = new TestSubscriber<String>();
 
         Completable completable = Completable.unsafeCreate(new CompletableSource() {
@@ -4215,7 +4215,7 @@ public void testHookSubscribeStart() throws Throwable {
 
     @Ignore("No unsafeSubscribe")
     @Test
-    public void testHookUnsafeSubscribeStart() {
+    public void hookUnsafeSubscribeStart() {
         /*
         TestSubscriber<String> ts = new TestSubscriber<String>();
         Completable completable = Completable.create(new CompletableOnSubscribe() {

src/test/java/io/reactivex/disposables/CompositeDisposableTest.java

@@ -29,7 +29,7 @@
 public class CompositeDisposableTest {
 
     @Test
-    public void testSuccess() {
+    public void success() {
         final AtomicInteger counter = new AtomicInteger();
         CompositeDisposable cd = new CompositeDisposable();
         cd.add(Disposables.fromRunnable(new Runnable() {
@@ -97,7 +97,7 @@ public void run() {
     }
 
     @Test
-    public void testException() {
+    public void exception() {
         final AtomicInteger counter = new AtomicInteger();
         CompositeDisposable cd = new CompositeDisposable();
         cd.add(Disposables.fromRunnable(new Runnable() {
@@ -131,7 +131,7 @@ public void run() {
     }
 
     @Test
-    public void testCompositeException() {
+    public void compositeException() {
         final AtomicInteger counter = new AtomicInteger();
         CompositeDisposable cd = new CompositeDisposable();
         cd.add(Disposables.fromRunnable(new Runnable() {
@@ -173,7 +173,7 @@ public void run() {
     }
 
     @Test
-    public void testRemoveUnsubscribes() {
+    public void removeUnsubscribes() {
         Disposable d1 = Disposables.empty();
         Disposable d2 = Disposables.empty();
 
@@ -188,7 +188,7 @@ public void testRemoveUnsubscribes() {
     }
 
     @Test
-    public void testClear() {
+    public void clear() {
         Disposable d1 = Disposables.empty();
         Disposable d2 = Disposables.empty();
 
@@ -215,7 +215,7 @@ public void testClear() {
     }
 
     @Test
-    public void testUnsubscribeIdempotence() {
+    public void unsubscribeIdempotence() {
         final AtomicInteger counter = new AtomicInteger();
         CompositeDisposable cd = new CompositeDisposable();
         cd.add(Disposables.fromRunnable(new Runnable() {
@@ -236,7 +236,7 @@ public void run() {
     }
 
     @Test(timeout = 1000)
-    public void testUnsubscribeIdempotenceConcurrently()
+    public void unsubscribeIdempotenceConcurrently()
             throws InterruptedException {
         final AtomicInteger counter = new AtomicInteger();
         final CompositeDisposable cd = new CompositeDisposable();
@@ -279,7 +279,7 @@ public void run() {
     }
 
     @Test
-    public void testTryRemoveIfNotIn() {
+    public void tryRemoveIfNotIn() {
         CompositeDisposable cd = new CompositeDisposable();
 
         CompositeDisposable cd1 = new CompositeDisposable();
@@ -293,7 +293,7 @@ public void testTryRemoveIfNotIn() {
     }
 
     @Test(expected = NullPointerException.class)
-    public void testAddingNullDisposableIllegal() {
+    public void addingNullDisposableIllegal() {
         CompositeDisposable cd = new CompositeDisposable();
         cd.add(null);
     }

src/test/java/io/reactivex/disposables/DisposablesTest.java

@@ -32,7 +32,7 @@
 public class DisposablesTest {
 
     @Test
-    public void testUnsubscribeOnlyOnce() {
+    public void unsubscribeOnlyOnce() {
         Runnable dispose = mock(Runnable.class);
         Disposable subscription = Disposables.fromRunnable(dispose);
         subscription.dispose();
@@ -41,15 +41,15 @@ public void testUnsubscribeOnlyOnce() {
     }
 
     @Test
-    public void testEmpty() {
+    public void empty() {
         Disposable empty = Disposables.empty();
         assertFalse(empty.isDisposed());
         empty.dispose();
         assertTrue(empty.isDisposed());
     }
 
     @Test
-    public void testUnsubscribed() {
+    public void unsubscribed() {
         Disposable disposed = Disposables.disposed();
         assertTrue(disposed.isDisposed());
     }

src/test/java/io/reactivex/exceptions/CompositeExceptionTest.java

@@ -39,7 +39,7 @@ private CompositeException getNewCompositeExceptionWithEx123() {
     }
 
     @Test(timeout = 1000)
-    public void testMultipleWithSameCause() {
+    public void multipleWithSameCause() {
         Throwable rootCause = new Throwable("RootCause");
         Throwable e1 = new Throwable("1", rootCause);
         Throwable e2 = new Throwable("2", rootCause);
@@ -57,7 +57,7 @@ public void testMultipleWithSameCause() {
     }
 
     @Test
-    public void testEmptyErrors() {
+    public void emptyErrors() {
         try {
             new CompositeException();
             fail("CompositeException should fail if errors is empty");
@@ -73,7 +73,7 @@ public void testEmptyErrors() {
     }
 
     @Test(timeout = 1000)
-    public void testCompositeExceptionFromParentThenChild() {
+    public void compositeExceptionFromParentThenChild() {
         CompositeException cex = new CompositeException(ex1, ex2);
 
         System.err.println("----------------------------- print composite stacktrace");
@@ -88,7 +88,7 @@ public void testCompositeExceptionFromParentThenChild() {
     }
 
     @Test(timeout = 1000)
-    public void testCompositeExceptionFromChildThenParent() {
+    public void compositeExceptionFromChildThenParent() {
         CompositeException cex = new CompositeException(ex2, ex1);
 
         System.err.println("----------------------------- print composite stacktrace");
@@ -103,7 +103,7 @@ public void testCompositeExceptionFromChildThenParent() {
     }
 
     @Test(timeout = 1000)
-    public void testCompositeExceptionFromChildAndComposite() {
+    public void compositeExceptionFromChildAndComposite() {
         CompositeException cex = new CompositeException(ex1, getNewCompositeExceptionWithEx123());
 
         System.err.println("----------------------------- print composite stacktrace");
@@ -118,7 +118,7 @@ public void testCompositeExceptionFromChildAndComposite() {
     }
 
     @Test(timeout = 1000)
-    public void testCompositeExceptionFromCompositeAndChild() {
+    public void compositeExceptionFromCompositeAndChild() {
         CompositeException cex = new CompositeException(getNewCompositeExceptionWithEx123(), ex1);
 
         System.err.println("----------------------------- print composite stacktrace");
@@ -133,7 +133,7 @@ public void testCompositeExceptionFromCompositeAndChild() {
     }
 
     @Test(timeout = 1000)
-    public void testCompositeExceptionFromTwoDuplicateComposites() {
+    public void compositeExceptionFromTwoDuplicateComposites() {
         List<Throwable> exs = new ArrayList<Throwable>();
         exs.add(getNewCompositeExceptionWithEx123());
         exs.add(getNewCompositeExceptionWithEx123());
@@ -177,21 +177,21 @@ private static Throwable getRootCause(Throwable ex) {
     }
 
     @Test
-    public void testNullCollection() {
+    public void nullCollection() {
         CompositeException composite = new CompositeException((List<Throwable>)null);
         composite.getCause();
         composite.printStackTrace();
     }
 
     @Test
-    public void testNullElement() {
+    public void nullElement() {
         CompositeException composite = new CompositeException(Collections.singletonList((Throwable) null));
         composite.getCause();
         composite.printStackTrace();
     }
 
     @Test(timeout = 1000)
-    public void testCompositeExceptionWithUnsupportedInitCause() {
+    public void compositeExceptionWithUnsupportedInitCause() {
         Throwable t = new Throwable() {
 
             private static final long serialVersionUID = -3282577447436848385L;
@@ -215,7 +215,7 @@ public synchronized Throwable initCause(Throwable cause) {
     }
 
     @Test(timeout = 1000)
-    public void testCompositeExceptionWithNullInitCause() {
+    public void compositeExceptionWithNullInitCause() {
         Throwable t = new Throwable("ThrowableWithNullInitCause") {
 
             private static final long serialVersionUID = -7984762607894527888L;

src/test/java/io/reactivex/exceptions/ExceptionsNullTest.java

@@ -24,78 +24,78 @@ public class ExceptionsNullTest {
 
     @Ignore("OnCompleteFailedException will likely not be ported")
     @Test
-    public void testOnCompleteFailedExceptionNull() {
+    public void onCompleteFailedExceptionNull() {
 //        Throwable t = new OnCompleteFailedException(null);
 //
 //        Assert.assertTrue(t.getCause() instanceof NullPointerException);
     }
 
     @Ignore("OnCompleteFailedException will likely not be ported")
     @Test
-    public void testOnCompleteFailedExceptionMessageAndNull() {
+    public void onCompleteFailedExceptionMessageAndNull() {
 //        Throwable t = new OnCompleteFailedException("Message", null);
 //
 //        Assert.assertTrue(t.getCause() instanceof NullPointerException);
     }
 
     @Ignore("OnErrorFailedException will likely not be ported")
     @Test
-    public void testOnErrorFailedExceptionNull() {
+    public void onErrorFailedExceptionNull() {
 //        Throwable t = new OnErrorFailedException(null);
 //
 //        Assert.assertTrue(t.getCause() instanceof NullPointerException);
     }
 
     @Ignore("OnErrorFailedException will likely not be ported")
     @Test
-    public void testOnErrorFailedExceptionMessageAndNull() {
+    public void onErrorFailedExceptionMessageAndNull() {
 //        Throwable t = new OnErrorFailedException("Message", null);
 //
 //        Assert.assertTrue(t.getCause() instanceof NullPointerException);
     }
 
     @Ignore("UnsubscribeFailedException will likely not be ported")
     @Test
-    public void testUnsubscribeFailedExceptionNull() {
+    public void unsubscribeFailedExceptionNull() {
 //        Throwable t = new UnsubscribeFailedException(null);
 //
 //        Assert.assertTrue(t.getCause() instanceof NullPointerException);
     }
 
     @Ignore("UnsubscribeFailedException will likely not be ported")
     @Test
-    public void testUnsubscribeFailedExceptionMessageAndNull() {
+    public void unsubscribeFailedExceptionMessageAndNull() {
 //        Throwable t = new UnsubscribeFailedException("Message", null);
 //
 //        Assert.assertTrue(t.getCause() instanceof NullPointerException);
     }
 
     @Ignore("OnErrorNotImplementedException will likely not be ported")
     @Test
-    public void testOnErrorNotImplementedExceptionNull() {
+    public void onErrorNotImplementedExceptionNull() {
 //        Throwable t = new OnErrorNotImplementedException(null);
 //
 //        Assert.assertTrue(t.getCause() instanceof NullPointerException);
     }
 
     @Ignore("OnErrorNotImplementedException will likely not be ported")
     @Test
-    public void testOnErrorNotImplementedExceptionMessageAndNull() {
+    public void onErrorNotImplementedExceptionMessageAndNull() {
 //        Throwable t = new OnErrorNotImplementedException("Message", null);
 //
 //        Assert.assertTrue(t.getCause() instanceof NullPointerException);
     }
 
     @Ignore("OnErrorThrowable may be ported later")
     @Test
-    public void testOnErrorThrowableFrom() {
+    public void onErrorThrowableFrom() {
 //        Throwable t = OnErrorThrowable.from(null);
 //        Assert.assertTrue(t.getCause() instanceof NullPointerException);
     }
 
     @Ignore("OnErrorThrowable may be ported later")
     @Test
-    public void testOnErrorThrowableAddValueAsLastCause() {
+    public void onErrorThrowableAddValueAsLastCause() {
 //        Throwable t = OnErrorThrowable.addValueAsLastCause(null, "value");
 //        Assert.assertTrue(t instanceof NullPointerException);
     }