Remove isFinishing check when calling back to activities

We decided it's sufficient for the callback to be safe as long as the caller unsubscribes in onDestroy

Author: mttkay

rxjava-contrib/rxjava-android/src/main/java/rx/operators/OperationObserveFromAndroidComponent.java

@@ -44,10 +44,10 @@ public static <T> Observable<T> observeFromAndroidComponent(Observable<T> source
     }
 
     public static <T> Observable<T> observeFromAndroidComponent(Observable<T> source, Activity activity) {
-        return Observable.create(new OnSubscribeActivity<T>(source, activity));
+        return Observable.create(new OnSubscribeBase<T, Activity>(source, activity));
     }
 
-    private static abstract class OnSubscribeBase<T, AndroidComponent> implements Observable.OnSubscribeFunc<T> {
+    private static class OnSubscribeBase<T, AndroidComponent> implements Observable.OnSubscribeFunc<T> {
 
         private static final String LOG_TAG = OperationObserveFromAndroidComponent.class.getSimpleName();
 
@@ -68,7 +68,9 @@ private void log(String message) {
             }
         }
 
-        protected abstract boolean isComponentValid(AndroidComponent component);
+        protected boolean isComponentValid(AndroidComponent component) {
+            return true;
+        }
 
         @Override
         public Subscription onSubscribe(Observer<? super T> observer) {
@@ -148,18 +150,6 @@ protected boolean isComponentValid(android.support.v4.app.Fragment fragment) {
         }
     }
 
-    private static final class OnSubscribeActivity<T> extends OnSubscribeBase<T, Activity> {
-
-        private OnSubscribeActivity(Observable<T> source, Activity activity) {
-            super(source, activity);
-        }
-
-        @Override
-        protected boolean isComponentValid(Activity activity) {
-            return !activity.isFinishing();
-        }
-    }
-
     @RunWith(RobolectricTestRunner.class)
     @Config(manifest = Config.NONE)
     public static final class UnitTest {
@@ -292,36 +282,6 @@ public void itDoesNotForwardOnErrorIfFragmentIsDetached() {
             verify(mockObserver, never()).onError(any(Exception.class));
         }
 
-        @Test
-        public void isDoesNotForwardOnNextOnCompletedSequenceIfActivityIsFinishing() {
-            PublishSubject<Integer> source = PublishSubject.create();
-            OperationObserveFromAndroidComponent.observeFromAndroidComponent(source, mockActivity).subscribe(mockObserver);
-
-            source.onNext(1);
-
-            when(mockActivity.isFinishing()).thenReturn(true);
-            source.onNext(2);
-            source.onNext(3);
-            source.onCompleted();
-
-            verify(mockObserver).onNext(1);
-            verify(mockObserver, never()).onCompleted();
-        }
-
-        @Test
-        public void itDoesNotForwardOnErrorIfActivityIsFinishing() {
-            PublishSubject<Integer> source = PublishSubject.create();
-            OperationObserveFromAndroidComponent.observeFromAndroidComponent(source, mockActivity).subscribe(mockObserver);
-
-            source.onNext(1);
-
-            when(mockActivity.isFinishing()).thenReturn(true);
-            source.onError(new Exception());
-
-            verify(mockObserver).onNext(1);
-            verify(mockObserver, never()).onError(any(Exception.class));
-        }
-
         @Test
         public void itUnsubscribesFromTheSourceSequence() {
             Subscription underlying = mock(Subscription.class);