removing unnecessary constants

Author: bksh05

src/constants/responses.ts

@@ -28,9 +28,5 @@ export const NAME_CHANGED = "User nickname changed successfully";
 
 export const ROLE_REMOVED = "Role Removed successfully";
 
-export const ROLE_FETCH_FAILED_MESSAGE =
+export const ROLE_FETCH_FAILED =
   "Oops! We are experiencing an issue fetching roles.";
-
-export const ROLE_FETCH_FAILED_ERROR = {
-  error: ROLE_FETCH_FAILED_MESSAGE,
-};

src/controllers/guildRoleHandler.ts

@@ -81,10 +81,13 @@ export async function getGuildRolesHandler(request: IRequest, env: env) {
     const roles = await getGuildRoles(env);
     return new JSONResponse({ roles });
   } catch (err: any) {
-    if (err.message === response.ROLE_FETCH_FAILED_MESSAGE) {
-      return new JSONResponse(response.ROLE_FETCH_FAILED_ERROR, {
-        status: 500,
-      });
+    if (err.message === response.ROLE_FETCH_FAILED) {
+      return new JSONResponse(
+        { error: response.ROLE_FETCH_FAILED },
+        {
+          status: 500,
+        }
+      );
     }
     return new JSONResponse(response.INTERNAL_SERVER_ERROR, { status: 500 });
   }
@@ -112,10 +115,13 @@ export async function getGuildRoleByRoleNameHandler(
     }
     return new JSONResponse(role);
   } catch (err: any) {
-    if (err.message === response.ROLE_FETCH_FAILED_MESSAGE) {
-      return new JSONResponse(response.ROLE_FETCH_FAILED_ERROR, {
-        status: 500,
-      });
+    if (err.message === response.ROLE_FETCH_FAILED) {
+      return new JSONResponse(
+        { error: response.ROLE_FETCH_FAILED },
+        {
+          status: 500,
+        }
+      );
     }
     return new JSONResponse(response.INTERNAL_SERVER_ERROR, { status: 500 });
   }

src/utils/guildRole.ts

@@ -2,7 +2,7 @@ import {
   INTERNAL_SERVER_ERROR,
   ROLE_ADDED,
   ROLE_REMOVED,
-  ROLE_FETCH_FAILED_MESSAGE,
+  ROLE_FETCH_FAILED,
 } from "../constants/responses";
 import { DISCORD_BASE_URL } from "../constants/urls";
 import { env } from "../typeDefinitions/default.types";
@@ -99,7 +99,7 @@ export async function getGuildRoles(env: env): Promise<Array<GuildRole>> {
   });
 
   if (!response.ok) {
-    throw new Error(ROLE_FETCH_FAILED_MESSAGE);
+    throw new Error(ROLE_FETCH_FAILED);
   }
 
   const guildDetails: GuildDetails = await response.json();

tests/unit/handlers/guildRoleHandler.test.ts

@@ -38,7 +38,7 @@ describe("get roles", () => {
 
   it("should return role fetch failed error response if it fails to fetch roles", async () => {
     getGuildRolesSpy.mockRejectedValueOnce({
-      message: responseConstants.ROLE_FETCH_FAILED_MESSAGE,
+      message: responseConstants.ROLE_FETCH_FAILED,
     });
     const mockRequest = generateDummyRequestObject({
       url: "/roles",
@@ -50,7 +50,9 @@ describe("get roles", () => {
     );
     const jsonResponse = await response.json();
     expect(response.status).toBe(500);
-    expect(jsonResponse).toEqual(responseConstants.ROLE_FETCH_FAILED_ERROR);
+    expect(jsonResponse).toEqual({
+      error: responseConstants.ROLE_FETCH_FAILED,
+    });
   });
 
   it("should return internal server error response if it fails for any other reason", async () => {
@@ -189,7 +191,7 @@ describe("get role by role name", () => {
 
   it("should return role fetch failed error if there was an error while fetching roles", async () => {
     getGuildRoleByNameSpy.mockRejectedValueOnce({
-      message: responseConstants.ROLE_FETCH_FAILED_MESSAGE,
+      message: responseConstants.ROLE_FETCH_FAILED,
     });
 
     const mockRequest = generateDummyRequestObject({
@@ -206,7 +208,9 @@ describe("get role by role name", () => {
     );
     const jsonResponse: { roles: Array<GuildRole> } = await response.json();
     expect(response.status).toBe(500);
-    expect(jsonResponse).toEqual(responseConstants.ROLE_FETCH_FAILED_ERROR);
+    expect(jsonResponse).toEqual({
+      error: responseConstants.ROLE_FETCH_FAILED,
+    });
   });
 
   it("should return internal server error if there was any other error", async () => {

tests/unit/utils/guildRole.test.ts

@@ -140,7 +140,7 @@ describe("getGuildRoles", () => {
         Promise.resolve(new JSONResponse({}, { status: 500 }))
       );
     await expect(getGuildRoles(guildEnv)).rejects.toThrow(
-      response.ROLE_FETCH_FAILED_MESSAGE
+      response.ROLE_FETCH_FAILED
     );
   });
 
@@ -173,7 +173,7 @@ describe("getGuildRolesByName", () => {
         Promise.resolve(new JSONResponse({}, { status: 500 }))
       );
     await expect(getGuildRoleByName("@everyone", guildEnv)).rejects.toThrow(
-      response.ROLE_FETCH_FAILED_MESSAGE
+      response.ROLE_FETCH_FAILED
     );
   });