fix: add tests to handle edge cases and fix existing failing tests

Author: pankajjs

src/utils/onboardingExtension.ts

@@ -32,7 +32,7 @@ export const createOnboardingExtension = async (
 
   if (args.userId && args.discordId !== args.userId) {
     const userResponse = await getUserDetails(args.discordId);
-    if (!userResponse.user?.roles?.super_user) {
+    if (!userResponse?.user?.roles?.super_user) {
       content = `<@${args.discordId}> ${UNAUTHORIZED_TO_CREATE_ONBOARDING_EXTENSION_REQUEST}`;
       return await sendReplyInDiscordChannel(discordReplyUrl, content, env);
     }

tests/unit/utils/onboardingExtension.test.ts

@@ -2,6 +2,7 @@ import config from "../../../config/config";
 import { UNAUTHORIZED_TO_CREATE_ONBOARDING_EXTENSION_REQUEST } from "../../../src/constants/responses";
 import { DISCORD_BASE_URL } from "../../../src/constants/urls";
 import { generateDiscordAuthToken } from "../../../src/utils/authTokenGenerator";
+import JSONResponse from "../../../src/utils/JsonResponse";
 import {
   createOnboardingExtension,
   CreateOnboardingExtensionArgs,
@@ -46,8 +47,10 @@ describe("createOnboaringExtension", () => {
     jest.restoreAllMocks();
   });
 
-  it("should call sendReplyInDiscordChannel with error content", async () => {
+  it("should call sendReplyInDicordChannel when user is not a super user", async () => {
+    fetchSpy.mockImplementation(() => new JSONResponse(null));
     await createOnboardingExtension(args, guildEnv);
+    expect(fetchSpy).toHaveBeenCalledTimes(2);
     expect(utils.sendReplyInDiscordChannel).toHaveBeenCalledTimes(1);
     expect(utils.sendReplyInDiscordChannel).toHaveBeenCalledWith(
       discordReplyUrl,
@@ -56,7 +59,46 @@ describe("createOnboaringExtension", () => {
     );
   });
 
-  it("should call fetch with success response", async () => {
+  it("should call sendReplyInDiscordChannel with error response for invalid request body", async () => {
+    const message = "numberOfDays must be positive";
+    const errorContent = `<@${args.discordId}> ${message}`;
+    const response = new JSONResponse({ message });
+
+    fetchSpy.mockImplementation(() => response);
+
+    args.numberOfDays = -1;
+    args.userId = undefined;
+    requestData.numberOfDays = args.numberOfDays;
+
+    await createOnboardingExtension(args, guildEnv);
+    expect(fetchSpy).toHaveBeenCalledTimes(2);
+    expect(utils.sendReplyInDiscordChannel).toHaveBeenCalledTimes(1);
+    expect(utils.sendReplyInDiscordChannel).toHaveBeenCalledWith(
+      discordReplyUrl,
+      errorContent,
+      guildEnv
+    );
+  });
+
+  it("should call sendReplyInDiscordChannel with error content for unexpected error", async () => {
+    fetchSpy.mockImplementation(() => {
+      throw new Error("Unexpected Error");
+    });
+    try {
+      await createOnboardingExtension(args, guildEnv);
+    } catch (error) {
+      expect(utils.sendReplyInDiscordChannel).toHaveBeenCalledTimes(1);
+      expect(utils.sendReplyInDiscordChannel).toHaveBeenCalledWith(
+        discordReplyUrl,
+        `<@${
+          args.discordId
+        }> ${"Error occurred while creating onboarding extension request."}`,
+        guildEnv
+      );
+    }
+  });
+
+  it("should call sendReplyInDiscordChannel  with success response", async () => {
     args.userId = undefined;
     requestData.userId = args.discordId;
     await createOnboardingExtension(args, guildEnv);