Skip to content

Commit 515256d

Browse files
authored
Merge pull request #197 from Real-Dev-Squad/develop
Dev to main sync
2 parents 2f12023 + 7f07d77 commit 515256d

File tree

5 files changed

+14
-3
lines changed

5 files changed

+14
-3
lines changed

.github/workflows/register-commands-production.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ jobs:
3535
CURRENT_ENVIRONMENT
3636
BOT_PRIVATE_KEY
3737
RDS_SERVERLESS_PUBLIC_KEY
38+
CRON_JOBS_PUBLIC_KEY
3839
env:
3940
CURRENT_ENVIRONMENT: production
4041
CLOUDFLARE_API_TOKEN: ${{secrets.CLOUDFLARE_API_TOKEN}}
@@ -43,3 +44,4 @@ jobs:
4344
BOT_PRIVATE_KEY: ${{secrets.BOT_PRIVATE_KEY}}
4445
DISCORD_GUILD_ID: ${{secrets.DISCORD_GUILD_ID}}
4546
RDS_SERVERLESS_PUBLIC_KEY: ${{secrets.RDS_SERVERLESS_PUBLIC_KEY}}
47+
CRON_JOBS_PUBLIC_KEY: ${{secrets.CRON_JOBS_PUBLIC_KEY}}

.github/workflows/register-commands-staging.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,12 @@ jobs:
3434
DISCORD_GUILD_ID
3535
CURRENT_ENVIRONMENT
3636
BOT_PRIVATE_KEY
37+
CRON_JOBS_PUBLIC_KEY
3738
env:
3839
CURRENT_ENVIRONMENT: staging
3940
CLOUDFLARE_API_TOKEN: ${{secrets.CLOUDFLARE_API_TOKEN}}
4041
DISCORD_PUBLIC_KEY: ${{secrets.DISCORD_PUBLIC_KEY}}
4142
DISCORD_TOKEN: ${{secrets.DISCORD_TOKEN}}
4243
BOT_PRIVATE_KEY: ${{secrets.BOT_PRIVATE_KEY}}
4344
DISCORD_GUILD_ID: ${{secrets.DISCORD_GUILD_ID}}
45+
CRON_JOBS_PUBLIC_KEY: ${{secrets.CRON_JOBS_PUBLIC_KEY}}

src/controllers/guildRoleHandler.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import {
1313
createNewRole,
1414
memberGroupRole,
1515
} from "../typeDefinitions/discordMessage.types";
16-
import { verifyAuthToken } from "../utils/verifyAuthToken";
16+
import { verifyAuthToken, verifyCronJobsToken } from "../utils/verifyAuthToken";
1717
import { batchDiscordRequests } from "../utils/batchDiscordRequests";
1818
import { DISCORD_BASE_URL } from "../constants/urls";
1919
import { GROUP_ROLE_ADD } from "../constants/requestsActions";
@@ -59,8 +59,13 @@ export async function getGuildRolesPostHandler(request: IRequest, env: env) {
5959
const reason = request.headers.get("X-Audit-Log-Reason");
6060

6161
try {
62-
await verifyAuthToken(authHeader, env);
63-
const { action } = request.query;
62+
const { action, dev } = request.query;
63+
//TODO(@Ajeyakrishna-k): remove dev flag https://github.com/Real-Dev-Squad/discord-slash-commands/issues/193
64+
if (dev === "true") {
65+
await verifyCronJobsToken(authHeader, env);
66+
} else {
67+
await verifyAuthToken(authHeader, env);
68+
}
6469

6570
switch (action) {
6671
case GROUP_ROLE_ADD.ADD_ROLE: {

tests/fixtures/fixture.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ export const dummyAddRoleBody: memberGroupRole = {
5454
export const guildEnv = {
5555
DISCORD_GUILD_ID: "1234",
5656
DISCORD_TOKEN: "abcd",
57+
CRON_JOBS_PUBLIC_KEY: "test",
5758
};
5859

5960
export const dummyInviteBody = {

tests/unit/handlers/guildRoleHandler.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import { GROUP_ROLE_ADD } from "../../../src/constants/requestsActions";
1818

1919
jest.mock("../../../src/utils/verifyAuthToken", () => ({
2020
verifyAuthToken: jest.fn().mockReturnValue(true),
21+
verifyCronJobsToken: jest.fn().mockReturnValue(true),
2122
}));
2223

2324
const getGuildRolesSpy = jest.spyOn(guildRoleUtils, "getGuildRoles");

0 commit comments

Comments
 (0)