Merge pull request #300 from mbramani/fix/remove-feature-flag-onboarding-extension

chore: remove feature flag onboarding extension command

Author: mbramani

src/constants/commands.ts

@@ -240,11 +240,5 @@ export const ONBOARDING_EXTENSION = {
       type: 6,
       required: false,
     },
-    {
-      name: "dev",
-      description: "Feature flag",
-      type: 5,
-      required: false,
-    },
   ],
 };

src/controllers/onboardingExtensionCommand.ts

@@ -22,13 +22,8 @@ export async function onboardingExtensionCommand(
   env: env,
   ctx: ExecutionContext
 ) {
-  const dev = transformedArgument.devObj?.value || false;
   const discordId = transformedArgument.memberObj.user.id.toString();
 
-  if (!dev) {
-    return discordTextResponse(`<@${discordId}> Feature not implemented`);
-  }
-
   const args: CreateOnboardingExtensionArgs = {
     channelId: transformedArgument.channelId,
     userId: transformedArgument.userIdObj?.value,

src/utils/onboardingExtension.ts

@@ -40,7 +40,7 @@ export const createOnboardingExtension = async (
 
   const userDiscordId = args.userId ? args.userId : args.discordId;
   const base_url = config(env).RDS_BASE_API_URL;
-  const createOnboardingExtensionUrl = `${base_url}/requests?dev=true`;
+  const createOnboardingExtensionUrl = `${base_url}/requests`;
 
   const requestBody = {
     userId: userDiscordId,

tests/unit/handlers/onboardingExtension.test.ts

@@ -17,20 +17,6 @@ describe("onboardingExtensionCommand", () => {
   const discordId =
     transformedArgsForOnboardingExtension.memberObj.user.id.toString();
 
-  it("should return Feature not implemented", async () => {
-    const expectedRes = await onboardingExtensionCommand(
-      transformedArgsForOnboardingExtension,
-      guildEnv,
-      ctx
-    );
-    const jsonResponse = await expectedRes.json();
-    const mockResponse = discordTextResponse(
-      `<@${discordId}> Feature not implemented`
-    );
-    const mockJsonResponse = await mockResponse.json();
-    expect(jsonResponse).toStrictEqual(mockJsonResponse);
-  });
-
   it("should return initial response", async () => {
     transformedArgsForOnboardingExtension.devObj.value = true;
     const expectedRes = await onboardingExtensionCommand(

tests/unit/utils/onboardingExtension.test.ts

@@ -20,7 +20,7 @@ describe("createOnboaringExtension", () => {
   };
   const discordReplyUrl = `${DISCORD_BASE_URL}/channels/${args.channelId}/messages`;
   const base_url = config(env).RDS_BASE_API_URL;
-  const createOnboardingExtensionUrl = `${base_url}/requests?dev=true`;
+  const createOnboardingExtensionUrl = `${base_url}/requests`;
   let fetchSpy: jest.SpyInstance;
   let authToken: string;