Feature: Create Discord API Endpoint to Remove Role from User (#82)

* add an api endpoint to relete role on discord

* revert commits to urls

* add test for remove guild role api

* remove unwanted changes

* add proper response headers

Author: RitikJaiswal75

src/constants/responses.ts

@@ -25,3 +25,5 @@ export const RETRY_COMMAND =
 export const ROLE_ADDED = "Role added successfully";
 
 export const NAME_CHANGED = "User nickname changed successfully";
+
+export const ROLE_REMOVED = "Role Removed successfully";

src/controllers/guildRoleHandler.ts

@@ -2,7 +2,11 @@ import * as response from "../constants/responses";
 import { env } from "../typeDefinitions/default.types";
 import JSONResponse from "../utils/JsonResponse";
 import { IRequest } from "itty-router";
-import { addGroupRole, createGuildRole } from "../utils/guildRole";
+import {
+  addGroupRole,
+  createGuildRole,
+  removeGuildRole,
+} from "../utils/guildRole";
 import {
   createNewRole,
   memberGroupRole,
@@ -39,3 +43,28 @@ export async function addGroupRoleHandler(request: IRequest, env: env) {
     return new JSONResponse(response.BAD_SIGNATURE);
   }
 }
+
+export async function removeGuildRoleHandler(request: IRequest, env: env) {
+  const authHeader = request.headers.get("Authorization");
+  if (!authHeader) {
+    return new JSONResponse(response.BAD_SIGNATURE, { status: 401 });
+  }
+  try {
+    await verifyAuthToken(authHeader, env);
+    const body: memberGroupRole = await request.json();
+    const res = await removeGuildRole(body, env);
+    return new JSONResponse(res, {
+      status: 200,
+      headers: {
+        "content-type": "application/json;charset=UTF-8",
+      },
+    });
+  } catch (err) {
+    return new JSONResponse(response.INTERNAL_SERVER_ERROR, {
+      status: 500,
+      headers: {
+        "content-type": "application/json;charset=UTF-8",
+      },
+    });
+  }
+}

src/index.ts

@@ -9,6 +9,7 @@ import { verifyBot } from "./utils/verifyBot";
 import {
   addGroupRoleHandler,
   createGuildRoleHandler,
+  removeGuildRoleHandler,
 } from "./controllers/guildRoleHandler";
 import { getMembersInServerHandler } from "./controllers/getMembersInServer";
 import { changeNickname } from "./controllers/changeNickname";
@@ -28,6 +29,8 @@ router.put("/roles/create", createGuildRoleHandler);
 
 router.put("/roles/add", addGroupRoleHandler);
 
+router.delete("/roles", removeGuildRoleHandler);
+
 router.get("/discord-members", getMembersInServerHandler);
 
 router.get("/member/:id", getGuildMemberDetailsHandler);

src/utils/guildRole.ts

@@ -1,4 +1,8 @@
-import { INTERNAL_SERVER_ERROR, ROLE_ADDED } from "../constants/responses";
+import {
+  INTERNAL_SERVER_ERROR,
+  ROLE_ADDED,
+  ROLE_REMOVED,
+} from "../constants/responses";
 import { DISCORD_BASE_URL } from "../constants/urls";
 import { env } from "../typeDefinitions/default.types";
 import {
@@ -55,3 +59,28 @@ export async function addGroupRole(body: memberGroupRole, env: env) {
     return INTERNAL_SERVER_ERROR;
   }
 }
+
+export async function removeGuildRole(details: memberGroupRole, env: env) {
+  const { userid, roleid } = details;
+  const removeGuildRoleUrl = `${DISCORD_BASE_URL}/guilds/${env.DISCORD_GUILD_ID}/members/${userid}/roles/${roleid}`;
+  try {
+    const response = await fetch(removeGuildRoleUrl, {
+      method: "DELETE",
+      headers: {
+        "Content-Type": "application/json",
+        Authorization: `Bot ${env.DISCORD_TOKEN}`,
+      },
+    });
+    if (response.ok) {
+      return {
+        message: ROLE_REMOVED,
+        userAffected: {
+          userid,
+          roleid,
+        },
+      };
+    }
+  } catch (err) {
+    return INTERNAL_SERVER_ERROR;
+  }
+}

tests/unit/utils/guildRole.test.ts

@@ -1,6 +1,10 @@
 import JSONResponse from "../../../src/utils/JsonResponse";
 import * as response from "../../../src/constants/responses";
-import { createGuildRole, addGroupRole } from "../../../src/utils/guildRole";
+import {
+  createGuildRole,
+  addGroupRole,
+  removeGuildRole,
+} from "../../../src/utils/guildRole";
 import {
   dummyAddRoleBody,
   dummyCreateBody,
@@ -89,3 +93,39 @@ describe("addGroupRole", () => {
     );
   });
 });
+
+describe("removeGuildRole", () => {
+  test("Should return success message on proper response", async () => {
+    const mockResponse = {
+      ok: true,
+    };
+    jest
+      .spyOn(global, "fetch")
+      .mockImplementation(() =>
+        Promise.resolve(new JSONResponse(mockResponse))
+      );
+    const result = await removeGuildRole(dummyAddRoleBody, guildEnv);
+    expect(global.fetch).toHaveBeenCalledWith(
+      `https://discord.com/api/v10/guilds/${guildEnv.DISCORD_GUILD_ID}/members/${dummyAddRoleBody.userid}/roles/${dummyAddRoleBody.roleid}`,
+      {
+        method: "DELETE",
+        headers: {
+          "Content-Type": "application/json",
+          Authorization: `Bot ${guildEnv.DISCORD_TOKEN}`,
+        },
+      }
+    );
+    expect(result).toEqual({
+      message: response.ROLE_REMOVED,
+      userAffected: {
+        userid: dummyAddRoleBody.userid,
+        roleid: dummyAddRoleBody.roleid,
+      },
+    });
+  });
+  test("Should return internal error response on api failure", async () => {
+    jest.spyOn(global, "fetch").mockRejectedValue("Oops some error");
+    const result = await removeGuildRole(dummyAddRoleBody, guildEnv);
+    expect(result).toEqual(response.INTERNAL_SERVER_ERROR);
+  });
+});