changing error type thrown on bad request

Author: bksh05

src/constants/responses.ts

@@ -30,3 +30,7 @@ export const ROLE_REMOVED = "Role Removed successfully";
 
 export const ROLE_FETCH_FAILED =
   "Oops! We are experiencing an issue fetching roles.";
+
+export const BAD_REQUEST = {
+  error: "Oops! This is not a proper request.",
+};

src/controllers/guildRoleHandler.ts

@@ -111,7 +111,7 @@ export async function getGuildRoleByRoleNameHandler(
   }
 
   if (!roleName) {
-    return new JSONResponse(response.NOT_FOUND, { status: 404 });
+    return new JSONResponse(response.BAD_REQUEST, { status: 404 });
   }
   try {
     await verifyAuthToken(authHeader, env);

tests/unit/handlers/guildRoleHandler.test.ts

@@ -20,9 +20,6 @@ const getGuildRolesSpy = jest.spyOn(guildRoleUtils, "getGuildRoles");
 const getGuildRoleByNameSpy = jest.spyOn(guildRoleUtils, "getGuildRoleByName");
 
 describe("get roles", () => {
-  beforeEach(() => {
-    jest.resetAllMocks();
-  });
   it("should return a instance of JSONResponse", async () => {
     const mockRequest = generateDummyRequestObject({ url: "/roles" });
     const response = await getGuildRolesHandler(mockRequest, guildEnv);
@@ -148,7 +145,7 @@ describe("get role by role name", () => {
     expect(jsonResponse).toEqual(responseConstants.BAD_SIGNATURE);
   });
 
-  it("should return Not Found error if no roleName is not provided", async () => {
+  it("should return BAD REQUEST error if roleName is not provided", async () => {
     getGuildRoleByNameSpy.mockResolvedValueOnce(undefined);
     const mockRequest = generateDummyRequestObject({
       url: "/roles",
@@ -162,7 +159,7 @@ describe("get role by role name", () => {
     );
     const jsonResponse: { error: string } = await response.json();
     expect(response.status).toBe(404);
-    expect(jsonResponse).toEqual(responseConstants.NOT_FOUND);
+    expect(jsonResponse).toEqual(responseConstants.BAD_REQUEST);
   });
 
   it("should return not found object if there is no roles with given name in guild", async () => {