Skip to content

Commit aec9003

Browse files
removed unnecessary changes from files
1 parent 56b0926 commit aec9003

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed

src/controllers/mentionEachUser.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export async function mentionEachUser(
2323
) {
2424
const getMembersInServerResponse = await getMembersInServer(env);
2525
const roleId = transformedArgument.roleToBeTaggedObj.value;
26-
const customMessage = transformedArgument?.displayMessageObj?.value; // Get custom message
26+
const msgToBeSent = transformedArgument?.displayMessageObj?.value; // Get custom message
2727
const dev = transformedArgument?.dev?.value || false;
2828

2929
const usersWithMatchingRole = filterUserByRoles(
@@ -34,7 +34,7 @@ export async function mentionEachUser(
3434
// Use the custom message if provided, otherwise construct the default message
3535
let responseMessage;
3636
if (usersWithMatchingRole.length === 0) {
37-
responseMessage = customMessage || "Sorry no user found under this role."; // Use custom message if available
37+
responseMessage = msgToBeSent || "Sorry no user found under this role."; // Use custom message if available
3838
} else {
3939
const roleTag = `<@&${roleId}>`;
4040
const userList = usersWithMatchingRole.join(", ");

src/utils/guildRole.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export async function createGuildRole(
4444
body: JSON.stringify(data),
4545
});
4646
if (response.ok) {
47-
return (await response.json()) as string | guildRoleResponse;
47+
return await response.json();
4848
} else {
4949
return INTERNAL_SERVER_ERROR;
5050
}
@@ -125,7 +125,7 @@ export async function getGuildRoles(env: env): Promise<Array<Role>> {
125125
throw new Error(ROLE_FETCH_FAILED);
126126
}
127127

128-
const guildRoles: Array<GuildRole> = (await response.json()) as GuildRole[];
128+
const guildRoles: Array<GuildRole> = await response.json();
129129

130130
return guildRoles.map((role) => ({
131131
id: role.id,
@@ -143,7 +143,6 @@ export async function getGuildRoleByName(
143143
const roles = await getGuildRoles(env);
144144
return roles?.find((role) => role.name === roleName);
145145
}
146-
import { Response } from "@cloudflare/workers-types";
147146

148147
export async function mentionEachUserInMessage({
149148
message,
@@ -174,12 +173,10 @@ export async function mentionEachUserInMessage({
174173
content: `${message ? message + " " : ""} ${userId}`,
175174
}),
176175
}).then((response) => {
177-
const rateLimitRemaining = parseRateLimitRemaining(
178-
response as unknown as Response
179-
);
176+
const rateLimitRemaining = parseRateLimitRemaining(response);
180177
if (rateLimitRemaining === 0) {
181178
waitTillNextAPICall = Math.max(
182-
parseResetAfter(response as unknown as Response),
179+
parseResetAfter(response),
183180
waitTillNextAPICall
184181
);
185182
}

tests/unit/handlers/mentionEachUser.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,6 @@ describe("Test mention each function", () => {
127127
expect(response).toBe(expectedResponse);
128128
});
129129

130-
// New test cases in the same style
131-
132130
it("should handle custom message when provided", async () => {
133131
const env = {
134132
BOT_PUBLIC_KEY: "xyz",

0 commit comments

Comments
 (0)