refactor: refactor and filtred discord ids

Author: sahsisunny

src/handlers/scheduledEventHandler.ts

@@ -5,22 +5,22 @@ import { SUPER_USER_ONE, SUPER_USER_TWO } from "../constants/variables";
 
 export async function send(env: env): Promise<void> {
   try {
-    let discordIds: string[] | string = await taskOverDueDiscordMembers();
+    const discordIds: string[] = await taskOverDueDiscordMembers();
 
-    if (!Array.isArray(discordIds)) {
-      // If it's not an array, convert it to an array with a single element
-      discordIds = [discordIds];
-    }
+    const superUsers = [SUPER_USER_ONE, SUPER_USER_TWO];
+    const filteredDiscordIds = discordIds.filter(
+      (id) => !superUsers.includes(id)
+    );
 
-    if (discordIds.length === 0) {
+    if (filteredDiscordIds.length === 0) {
       return;
     }
 
     //notifying the two users with the authority.
     let stringToBeSent = `<@${SUPER_USER_ONE}> <@${SUPER_USER_TWO}>\nThese people have their task running red:\n`;
 
     let forFormatting = 0;
-    discordIds.forEach((id: string) => {
+    filteredDiscordIds.forEach((id: string) => {
       const discordUser = `<@${id}> `;
       stringToBeSent += discordUser;
       forFormatting++;

src/utils/taskOverDueDiscordMembers.ts

@@ -1,9 +1,7 @@
 import { RDS_BASE_API_URL } from "../constants/urls";
 import { UserOverdueTaskResponseType } from "../typeDefinitions/rdsUser";
 
-export const taskOverDueDiscordMembers = async (): Promise<
-  string[] | string
-> => {
+export const taskOverDueDiscordMembers = async (): Promise<string[]> => {
   try {
     const overDueUrl = `${RDS_BASE_API_URL}/users?query=filterBy:overdue_tasks`;