Reorder env vars and removed success log from bash script

Author: Saitharun279

.github/workflows/register-commands-production.yaml

@@ -3,7 +3,25 @@ on:
   push:
     branches: main
 jobs:
+  Environment-Variables-Check:
+    runs-on: ubuntu-latest
+    environment: production
+    steps:
+      - uses: actions/checkout@v2
+      - run: bash environment-variables-validator.sh
+        env:
+          DISCORD_APPLICATION_ID: ${{secrets.DISCORD_APPLICATION_ID}}
+          DISCORD_GUILD_ID: ${{secrets.DISCORD_GUILD_ID}}
+          DISCORD_TOKEN: ${{secrets.DISCORD_TOKEN}}
+          DISCORD_PUBLIC_KEY: ${{secrets.DISCORD_PUBLIC_KEY}}
+          CLOUDFLARE_API_TOKEN: ${{secrets.CLOUDFLARE_API_TOKEN}}
+          CLOUDFLARE_ACCOUNT_ID: ${{secrets.CLOUDFLARE_ACCOUNT_ID}}
+          BOT_PRIVATE_KEY: ${{secrets.BOT_PRIVATE_KEY}}
+          RDS_SERVERLESS_PUBLIC_KEY: ${{secrets.RDS_SERVERLESS_PUBLIC_KEY}}
+          CRON_JOBS_PUBLIC_KEY: ${{secrets.CRON_JOBS_PUBLIC_KEY}}
+          IDENTITY_SERVICE_PUBLIC_KEY: ${{secrets.IDENTITY_SERVICE_PUBLIC_KEY}}
   Register-Commands:
+    needs: [Environment-Variables-Check]
     runs-on: ubuntu-latest
     environment: production
     steps:

.github/workflows/register-commands-staging.yaml

@@ -11,15 +11,15 @@ jobs:
       - run: bash environment-variables-validator.sh
         env:
           DISCORD_APPLICATION_ID: ${{secrets.DISCORD_APPLICATION_ID}}
-          CLOUDFLARE_API_TOKEN: ${{secrets.CLOUDFLARE_API_TOKEN}}
-          DISCORD_PUBLIC_KEY: ${{secrets.DISCORD_PUBLIC_KEY}}
+          DISCORD_GUILD_ID: ${{secrets.DISCORD_GUILD_ID}}
           DISCORD_TOKEN: ${{secrets.DISCORD_TOKEN}}
+          DISCORD_PUBLIC_KEY: ${{secrets.DISCORD_PUBLIC_KEY}}
+          CLOUDFLARE_API_TOKEN: ${{secrets.CLOUDFLARE_API_TOKEN}}
+          CLOUDFLARE_ACCOUNT_ID: ${{secrets.CLOUDFLARE_ACCOUNT_ID}}
           BOT_PRIVATE_KEY: ${{secrets.BOT_PRIVATE_KEY}}
-          DISCORD_GUILD_ID: ${{secrets.DISCORD_GUILD_ID}}
           RDS_SERVERLESS_PUBLIC_KEY: ${{secrets.RDS_SERVERLESS_PUBLIC_KEY}}
           CRON_JOBS_PUBLIC_KEY: ${{secrets.CRON_JOBS_PUBLIC_KEY}}
           IDENTITY_SERVICE_PUBLIC_KEY: ${{secrets.IDENTITY_SERVICE_PUBLIC_KEY}}
-          CLOUDFLARE_ACCOUNT_ID: ${{secrets.CLOUDFLARE_ACCOUNT_ID}}
   Register-Commands:
     needs: [Environment-Variables-Check]
     runs-on: ubuntu-latest
@@ -64,4 +64,4 @@ jobs:
           DISCORD_GUILD_ID: ${{secrets.DISCORD_GUILD_ID}}
           RDS_SERVERLESS_PUBLIC_KEY: ${{secrets.RDS_SERVERLESS_PUBLIC_KEY}}
           CRON_JOBS_PUBLIC_KEY: ${{secrets.CRON_JOBS_PUBLIC_KEY}}
-          IDENTITY_SERVICE_PUBLIC_KEY: ${{secrets.IDENTITY_SERVICE_PUBLIC_KEY}}
+          IDENTITY_SERVICE_PUBLIC_KEY: ${{secrets.IDENTITY_SERVICE_PUBLIC_KEY}}

environment-variables-validator.sh

@@ -13,7 +13,5 @@ while IFS= read -r var_name; do
   if [[ -z "${!var_name}" ]]; then
     echo "Environment variable $var_name is not set."
     exit 1  # Exit with error if any variable is not set
-  else
-    echo "Environment variable $var_name is set."
   fi
 done < "$ENV_VARS_FILE"

environment-variables.txt

@@ -1,10 +1,10 @@
-DISCORD_PUBLIC_KEY
-DISCORD_TOKEN
-DISCORD_GUILD_ID
 DISCORD_APPLICATION_ID
-CURRENT_ENVIRONMENT
+DISCORD_GUILD_ID
+DISCORD_TOKEN
+DISCORD_PUBLIC_KEY
+CLOUDFLARE_API_TOKEN
+CLOUDFLARE_ACCOUNT_ID
 BOT_PRIVATE_KEY
 RDS_SERVERLESS_PUBLIC_KEY
 CRON_JOBS_PUBLIC_KEY
-IDENTITY_SERVICE_PUBLIC_KEY
-CLOUDFLARE_ACCOUNT_ID
+IDENTITY_SERVICE_PUBLIC_KEY