fixed response interface

Author: DashDeipayan

src/constants/responses.ts

@@ -21,3 +21,5 @@ export const INTERNAL_SERVER_ERROR =
 
 export const RETRY_COMMAND =
   "Oops, we didn't catch that! Please use the command again.";
+
+export const ROLE_ADDED = "Role added successfully";

src/controllers/guildRoleHandler.ts

@@ -22,6 +22,7 @@ export async function createGuildRoleHandler(request: IRequest, env: env) {
     const body: createNewRole = await request.json();
 
     const res = await createGuildRole(body, env);
+    console.log(res);
     return new JSONResponse(res);
   } catch (err) {
     return new JSONResponse(response.BAD_SIGNATURE);

src/typeDefinitions/discordMessage.types.d.ts

@@ -38,3 +38,17 @@ export interface memberGroupRole {
   userid: string;
   roleid: string;
 }
+
+export interface guildRoleResponse {
+  id: string;
+  name: string;
+  color: number;
+  hoist: boolean;
+  icon?: string;
+  unicode_emoji?: string;
+  position: number;
+  permissions: string;
+  managed: boolean;
+  mentionable: boolean;
+  tags?: object;
+}

src/utils/guildRole.ts

@@ -1,12 +1,16 @@
-import { INTERNAL_SERVER_ERROR } from "../constants/responses";
+import { INTERNAL_SERVER_ERROR, ROLE_ADDED } from "../constants/responses";
 import { DISCORD_BASE_URL } from "../constants/urls";
 import { env } from "../typeDefinitions/default.types";
 import {
   createNewRole,
+  guildRoleResponse,
   memberGroupRole,
 } from "../typeDefinitions/discordMessage.types";
 
-export async function createGuildRole(body: createNewRole, env: env) {
+export async function createGuildRole(
+  body: createNewRole,
+  env: env
+): Promise<guildRoleResponse | string> {
   const createGuildRoleUrl = `${DISCORD_BASE_URL}/guilds/${env.DISCORD_GUILD_ID}/roles`;
   const data = {
     ...body,
@@ -43,7 +47,7 @@ export async function addGroupRole(body: memberGroupRole, env: env) {
       },
     });
     if (response.ok) {
-      return { message: "Role added successfully" };
+      return { message: ROLE_ADDED };
     } else {
       return INTERNAL_SERVER_ERROR;
     }

tests/unit/guildRole.test.ts

@@ -45,7 +45,7 @@ describe("createGuildRole", () => {
 
     const result = await createGuildRole(dummyCreateBody, guildEnv);
 
-    expect(result).toEqual({});
+    expect(result).toEqual(mockResponse);
     expect(global.fetch).toHaveBeenCalledWith(
       `https://discord.com/api/v10/guilds/${guildEnv.DISCORD_GUILD_ID}/roles`,
       {