fix: change error response and validation order

Author: pankajjs

src/constants/responses.ts

@@ -82,3 +82,4 @@ export const INVALID_TOKEN_FORMAT =
 export const AUTHENTICATION_ERROR = "Invalid Authentication token";
 export const TASK_UPDATE_SENT_MESSAGE =
   "Task update sent on Discord's tracking-updates channel.";
+export const NOT_IMPLEMENTED = "Feature not implemented";

src/controllers/deleteGuildRoleHandler.ts

@@ -12,13 +12,14 @@ export async function deleteGuildRoleHandler(request: IRequest, env: env) {
   const { dev } = request.query;
   const devFlag = dev === "true";
 
-  if (!devFlag) {
-    return new JSONResponse(response.NOT_FOUND, { status: 404 });
-  }
-
   if (!authHeader) {
     return new JSONResponse(response.BAD_SIGNATURE, { status: 401 });
   }
+
+  if (!devFlag) {
+    return new JSONResponse(response.NOT_IMPLEMENTED, { status: 501 });
+  }
+
   if (!roleId) {
     return new JSONResponse(response.BAD_REQUEST, { status: 400 });
   }

tests/unit/handlers/deleteGuildRoleHandler.test.ts

@@ -12,7 +12,7 @@ describe("deleteGuildRoleHandler", () => {
     jest.clearAllMocks();
   });
   const roleId = "1A32BEX04";
-  it("should return NOT_FOUND when dev is false", async () => {
+  it("should return NOT_IMPLEMENTED when dev is false", async () => {
     const mockRequest = generateDummyRequestObject({
       url: "/roles",
       params: {
@@ -22,10 +22,11 @@ describe("deleteGuildRoleHandler", () => {
         dev: "false",
       },
       method: "DELETE",
+      headers: { Authorization: "Bearer testtoken" },
     });
     const response = await deleteGuildRoleHandler(mockRequest, guildEnv);
     const jsonResponse = await response.json();
-    expect(jsonResponse).toEqual(responseConstants.NOT_FOUND);
+    expect(jsonResponse).toEqual(responseConstants.NOT_IMPLEMENTED);
   });
   it("should return BAD_REQUEST when roleId is not valid", async () => {
     const mockRequest = generateDummyRequestObject({