refactor: refactor deleteGuildRoleHandler and tests

Author: pankajjs

src/controllers/deleteGuildRoleHandler.ts

@@ -0,0 +1,42 @@
+import { IRequest } from "itty-router";
+import JSONResponse from "../utils/JsonResponse";
+import { env } from "../typeDefinitions/default.types";
+import * as response from "../constants/responses";
+import { verifyNodejsBackendAuthToken } from "../utils/verifyAuthToken";
+import { deleteGuildRole } from "../utils/deleteGuildRole";
+
+export async function deleteGuildRoleHandler(request: IRequest, env: env) {
+  const authHeader = request.headers.get("Authorization");
+  const reason = request.headers.get("X-Audit-Log-Reason");
+  const roleId = decodeURI(request.params?.roleId ?? "");
+  const { dev } = request.query;
+  const devFlag = dev === "true" ? true : false;
+
+  if (!devFlag) {
+    return new JSONResponse(response.NOT_FOUND, { status: 404 });
+  }
+
+  if (!authHeader) {
+    return new JSONResponse(response.BAD_SIGNATURE, { status: 401 });
+  }
+  if (!roleId) {
+    return new JSONResponse(response.BAD_REQUEST, { status: 400 });
+  }
+
+  try {
+    await verifyNodejsBackendAuthToken(authHeader, env);
+    const result = await deleteGuildRole(env, roleId, reason);
+
+    if (result === response.ROLE_REMOVED) {
+      return new Response(null, { status: 204 });
+    } else {
+      return new JSONResponse(response.INTERNAL_SERVER_ERROR, {
+        status: 500,
+      });
+    }
+  } catch (err) {
+    return new JSONResponse(response.INTERNAL_SERVER_ERROR, {
+      status: 500,
+    });
+  }
+}

src/controllers/guildRoleHandler.ts

@@ -8,7 +8,6 @@ import {
   removeGuildRole,
   getGuildRoleByName,
   getGuildRoles,
-  deleteGuildRole,
 } from "../utils/guildRole";
 import {
   createNewRole,
@@ -23,10 +22,6 @@ import { DISCORD_BASE_URL } from "../constants/urls";
 import { GROUP_ROLE_ADD } from "../constants/requestsActions";
 import createDiscordHeaders from "../utils/createDiscordHeaders";
 
-export async function deleteGuildRoleHandler(request: IRequest, env: env) {
-  return await deleteGuildRole(env, "101");
-}
-
 export async function createGuildRoleHandler(request: IRequest, env: env) {
   const authHeader = request.headers.get("Authorization");
   if (!authHeader) {

tests/unit/handlers/deleteGuildRoleHandler.test.ts

@@ -0,0 +1,128 @@
+import { generateDummyRequestObject, guildEnv } from "../../fixtures/fixture";
+import * as responseConstants from "../../../src/constants/responses";
+import * as verifyTokenUtils from "../../../src/utils/verifyAuthToken";
+import { deleteGuildRoleHandler } from "../../../src/controllers/deleteGuildRoleHandler";
+import * as deleteGuildRoleUtils from "../../../src/utils/deleteGuildRole";
+
+describe("deleteGuildRoleHandler", () => {
+  afterEach(() => {
+    jest.restoreAllMocks();
+  });
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+  const roleId = "1A32BEX04";
+  it("should return NOT_FOUND when dev is false", async () => {
+    const mockRequest = generateDummyRequestObject({
+      url: "/guildroles",
+      params: {
+        roleId: roleId,
+      },
+      query: {
+        dev: "false",
+      },
+      method: "DELETE",
+    });
+    const response = await deleteGuildRoleHandler(mockRequest, guildEnv);
+    const jsonResponse = await response.json();
+    expect(jsonResponse).toEqual(responseConstants.NOT_FOUND);
+  });
+  it("should return BAD_REQUEST when roleId is not valid", async () => {
+    const mockRequest = generateDummyRequestObject({
+      url: "/guildroles",
+      params: {
+        roleId: "",
+      },
+      query: {
+        dev: "true",
+      },
+      method: "DELETE",
+      headers: { Authorization: "Bearer testtoken" },
+    });
+    const response = await deleteGuildRoleHandler(mockRequest, guildEnv);
+    const jsonResponse = await response.json();
+    expect(jsonResponse).toEqual(responseConstants.BAD_REQUEST);
+  });
+  it("should return BAD_SIGNATURE when authorization header is not provided", async () => {
+    const mockRequest = generateDummyRequestObject({
+      url: "/guildroles",
+      params: {
+        roleId: roleId,
+      },
+      query: {
+        dev: "true",
+      },
+      method: "DELETE",
+    });
+    const response = await deleteGuildRoleHandler(mockRequest, guildEnv);
+    const jsonResponse = await response.json();
+    expect(jsonResponse).toEqual(responseConstants.BAD_SIGNATURE);
+  });
+  it("should return INTERNAL_SERVER_ERROR when response is not ok", async () => {
+    const mockResponse = responseConstants.INTERNAL_SERVER_ERROR;
+    const mockRequest = generateDummyRequestObject({
+      url: "/guildroles",
+      params: {
+        roleId: roleId,
+      },
+      query: {
+        dev: "true",
+      },
+      method: "DELETE",
+      headers: { Authorization: "Bearer testtoken" },
+    });
+    jest
+      .spyOn(deleteGuildRoleUtils, "deleteGuildRole")
+      .mockResolvedValue(mockResponse);
+    const response = await deleteGuildRoleHandler(mockRequest, guildEnv);
+    const jsonResponse = await response.json();
+    expect(jsonResponse).toEqual(mockResponse);
+  });
+  it("should return INTERNAL_SERVER_ERROR when token is not verified", async () => {
+    const mockResponse = responseConstants.INTERNAL_SERVER_ERROR;
+    const mockRequest = generateDummyRequestObject({
+      url: "/guildroles",
+      method: "DELETE",
+      params: {
+        roleId: roleId,
+      },
+      query: {
+        dev: "true",
+      },
+      headers: { Authorization: "Bearer testtoken" },
+    });
+    jest
+      .spyOn(verifyTokenUtils, "verifyNodejsBackendAuthToken")
+      .mockRejectedValue(mockResponse);
+    const response = await deleteGuildRoleHandler(mockRequest, guildEnv);
+    const jsonResponse = await response.json();
+    expect(jsonResponse).toEqual(mockResponse);
+  });
+  it("should return ok response", async () => {
+    const mockResponse = new Response(null, {
+      status: 204,
+    });
+    const mockRequest = generateDummyRequestObject({
+      url: "/guildroles",
+      method: "DELETE",
+      params: {
+        roleId: roleId,
+      },
+      query: {
+        dev: "true",
+      },
+      headers: { Authorization: "Bearer testtoken" },
+    });
+    const verifyTokenSpy = jest
+      .spyOn(verifyTokenUtils, "verifyNodejsBackendAuthToken")
+      .mockResolvedValueOnce();
+    const deleteGuildRoleSpy = jest
+      .spyOn(deleteGuildRoleUtils, "deleteGuildRole")
+      .mockResolvedValueOnce(responseConstants.ROLE_REMOVED);
+    const response = await deleteGuildRoleHandler(mockRequest, guildEnv);
+    expect(verifyTokenSpy).toHaveBeenCalledTimes(1);
+    expect(deleteGuildRoleSpy).toHaveBeenCalledTimes(1);
+    expect(response).toEqual(mockResponse);
+    expect(response.status).toEqual(mockResponse.status);
+  });
+});

tests/unit/handlers/guildRoleHandler.test.ts

@@ -1,5 +1,4 @@
 import {
-  deleteGuildRoleHandler,
   getGuildRoleByRoleNameHandler,
   getGuildRolesHandler,
   getGuildRolesPostHandler,
@@ -348,17 +347,3 @@ describe("getGuildRolesPostHandler", () => {
     expect(jsonResponse).toEqual(responseConstants.INTERNAL_SERVER_ERROR);
   });
 });
-
-describe("deleteGuildRoleHandler", () => {
-  it("should return undefined", async () => {
-    const mockRequest = generateDummyRequestObject({
-      url: "/guildroles",
-      params: {
-        roleId: "101",
-      },
-      method: "DELETE",
-    });
-    const response = await deleteGuildRoleHandler(mockRequest, guildEnv);
-    expect(response).toEqual(undefined);
-  });
-});