Skip to content

Commit ecd84ed

Browse files
Merge pull request #191 from Real-Dev-Squad/chore/verify-cron-token
Changes the function to verify cron auth token
2 parents 33a2957 + 8e7ba27 commit ecd84ed

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

src/controllers/guildRoleHandler.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import {
1313
createNewRole,
1414
memberGroupRole,
1515
} from "../typeDefinitions/discordMessage.types";
16-
import { verifyAuthToken } from "../utils/verifyAuthToken";
16+
import { verifyAuthToken, verifyCronJobsToken } from "../utils/verifyAuthToken";
1717
import { batchDiscordRequests } from "../utils/batchDiscordRequests";
1818
import { DISCORD_BASE_URL } from "../constants/urls";
1919
import { GROUP_ROLE_ADD } from "../constants/requestsActions";
@@ -59,8 +59,13 @@ export async function getGuildRolesPostHandler(request: IRequest, env: env) {
5959
const reason = request.headers.get("X-Audit-Log-Reason");
6060

6161
try {
62-
await verifyAuthToken(authHeader, env);
63-
const { action } = request.query;
62+
const { action, dev } = request.query;
63+
//TODO(@Ajeyakrishna-k): remove dev flag https://github.com/Real-Dev-Squad/discord-slash-commands/issues/193
64+
if (dev === "true") {
65+
await verifyCronJobsToken(authHeader, env);
66+
} else {
67+
await verifyAuthToken(authHeader, env);
68+
}
6469

6570
switch (action) {
6671
case GROUP_ROLE_ADD.ADD_ROLE: {

tests/fixtures/fixture.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ export const dummyAddRoleBody: memberGroupRole = {
5454
export const guildEnv = {
5555
DISCORD_GUILD_ID: "1234",
5656
DISCORD_TOKEN: "abcd",
57+
CRON_JOBS_PUBLIC_KEY: "test",
5758
};
5859

5960
export const dummyInviteBody = {

tests/unit/handlers/guildRoleHandler.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import { GROUP_ROLE_ADD } from "../../../src/constants/requestsActions";
1818

1919
jest.mock("../../../src/utils/verifyAuthToken", () => ({
2020
verifyAuthToken: jest.fn().mockReturnValue(true),
21+
verifyCronJobsToken: jest.fn().mockReturnValue(true),
2122
}));
2223

2324
const getGuildRolesSpy = jest.spyOn(guildRoleUtils, "getGuildRoles");

0 commit comments

Comments
 (0)