Skip to content

Commit faba991

Browse files
changed the feature flag name and removed nesting
1 parent 7148548 commit faba991

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

src/constants/commands.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export const MENTION_EACH = {
5151
require: false,
5252
},
5353
{
54-
name: "showroles",
54+
name: "devtitle",
5555
description: "want to see extra details?",
5656
type: 5,
5757
require: false,

src/controllers/baseHandler.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ export async function baseHandler(
7575
displayMessageObj: data.find((item) => item.name === "message"),
7676
channelId: message.channel_id,
7777
dev: data.find((item) => item.name === "dev") as unknown as DevFlag,
78-
showroles: data.find(
79-
(item) => item.name === "showroles"
78+
devtitle: data.find(
79+
(item) => item.name === "devtitle"
8080
) as unknown as DevFlag,
8181
};
8282
return await mentionEachUser(transformedArgument, env, ctx);

src/controllers/mentionEachUser.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export async function mentionEachUser(
1616
roleToBeTaggedObj: MentionEachUserOptions;
1717
displayMessageObj?: MentionEachUserOptions;
1818
channelId: number;
19-
showroles?: DevFlag;
19+
devtitle?: DevFlag;
2020
dev?: DevFlag;
2121
},
2222
env: env,
@@ -26,7 +26,7 @@ export async function mentionEachUser(
2626
const roleId = transformedArgument.roleToBeTaggedObj.value;
2727
const msgToBeSent = transformedArgument?.displayMessageObj?.value;
2828
const dev = transformedArgument?.dev?.value || false;
29-
const showroles = transformedArgument?.showroles?.value || false;
29+
const devtitle = transformedArgument?.devtitle?.value || false;
3030
// optional chaining here only because display message obj is optional argument
3131
const usersWithMatchingRole = filterUserByRoles(
3232
getMembersInServerResponse as UserArray[],
@@ -38,7 +38,8 @@ export async function mentionEachUser(
3838
message: msgToBeSent,
3939
usersWithMatchingRole,
4040
};
41-
if (transformedArgument.showroles?.value === true) {
41+
42+
if (transformedArgument.devtitle?.value === true) {
4243
let responseMessage = "";
4344
if (usersWithMatchingRole.length === 0) {
4445
responseMessage = `Sorry, no user found with <@&${roleId}> role.`;
@@ -50,7 +51,9 @@ export async function mentionEachUser(
5051
responseMessage = `The users with <@&${roleId}> role are ${payload.usersWithMatchingRole}.`;
5152
}
5253
return discordTextResponse(responseMessage);
53-
} else if (!dev || usersWithMatchingRole.length === 0) {
54+
}
55+
56+
if (!dev || usersWithMatchingRole.length === 0) {
5457
const responseData = checkDisplayType({
5558
usersWithMatchingRole,
5659
msgToBeSent,

0 commit comments

Comments
 (0)