fix: added validation for super-user and fix reply

Author: pankajjs

src/utils/onboardingExtension.ts

@@ -1,11 +1,13 @@
 import config from "../../config/config";
+import { UNAUTHORIZED_TO_CREATE_ONBOARDING_EXTENSION_REQUEST } from "../constants/responses";
 import { DISCORD_BASE_URL } from "../constants/urls";
 import { env } from "../typeDefinitions/default.types";
 import { generateDiscordAuthToken } from "./authTokenGenerator";
+import { getUserDetails } from "./getUserDetails";
 import { sendReplyInDiscordChannel } from "./sendReplyInDiscordChannel";
 
 export type CreateOnboardingExtensionArgs = {
-  userId: string;
+  userId?: string;
   channelId: number;
   reason: string;
   numberOfDays: number;
@@ -25,19 +27,28 @@ export const createOnboardingExtension = async (
     "RS256"
   );
 
+  let content: string;
   const discordReplyUrl = `${DISCORD_BASE_URL}/channels/${channelId}/messages`;
+
+  if (args.userId && args.discordId !== args.userId) {
+    const userResponse = await getUserDetails(args.discordId);
+    if (!userResponse.user?.roles?.super_user) {
+      content = `<@${args.discordId}> ${UNAUTHORIZED_TO_CREATE_ONBOARDING_EXTENSION_REQUEST}`;
+      return await sendReplyInDiscordChannel(discordReplyUrl, content, env);
+    }
+  }
+
+  const userDiscordId = args.userId ? args.userId : args.discordId;
   const base_url = config(env).RDS_BASE_API_URL;
   const createOnboardingExtensionUrl = `${base_url}/requests?dev=true`;
+
   const requestBody = {
-    userId: args.userId,
+    userId: userDiscordId,
     type: "ONBOARDING",
     numberOfDays: args.numberOfDays,
-    requestedBy: args.discordId,
     reason: args.reason,
   };
 
-  let content: string;
-
   try {
     const response = await fetch(createOnboardingExtensionUrl, {
       method: "POST",
@@ -51,9 +62,9 @@ export const createOnboardingExtension = async (
       message: string;
     };
     content = `<@${args.discordId}> ${jsonResponse.message}`;
-    await sendReplyInDiscordChannel(discordReplyUrl, content, env);
+    return await sendReplyInDiscordChannel(discordReplyUrl, content, env);
   } catch (err) {
     content = `<@${args.discordId}> Error occurred while creating onboarding extension request.`;
-    await sendReplyInDiscordChannel(discordReplyUrl, content, env);
+    return await sendReplyInDiscordChannel(discordReplyUrl, content, env);
   }
 };