feat: add users field to TeamDTO and update team detail view to include user information (#159)

Author: prakashchoudhary07

todo/dto/team_dto.py

@@ -1,6 +1,7 @@
 from pydantic import BaseModel, validator
 from typing import List, Optional
 from datetime import datetime
+from todo.dto.user_dto import UserDTO
 from todo.repositories.user_repository import UserRepository
 
 
@@ -48,3 +49,4 @@ class TeamDTO(BaseModel):
     updated_by: str
     created_at: datetime
     updated_at: datetime
+    users: Optional[List[UserDTO]] = None

todo/repositories/team_repository.py

@@ -97,8 +97,8 @@ def get_users_by_team_id(cls, team_id: str) -> list[str]:
         """
         collection = cls.get_collection()
         try:
-            user_teams_data = collection.find({"team_id": ObjectId(team_id), "is_active": True})
-            return [str(data["user_id"]) for data in user_teams_data]
+            user_teams_data = list(collection.find({"team_id": team_id, "is_active": True}))
+            return [data["user_id"] for data in user_teams_data]
         except Exception:
             return []
 

todo/views/team.py

@@ -140,16 +140,15 @@ def get(self, request: Request, team_id: str):
         Retrieve a single team by ID, or users in the team if ?member=true.
         """
         try:
+            team_dto: TeamDTO = TeamService.get_team_by_id(team_id)
             member = request.query_params.get("member", "false").lower() == "true"
             if member:
                 from todo.repositories.team_repository import UserTeamDetailsRepository
 
                 user_ids = UserTeamDetailsRepository.get_users_by_team_id(team_id)
                 users = UserService.get_users_by_ids(user_ids)
-                return Response(data=[user.model_dump(mode="json") for user in users], status=status.HTTP_200_OK)
-            else:
-                team_dto: TeamDTO = TeamService.get_team_by_id(team_id)
-                return Response(data=team_dto.model_dump(mode="json"), status=status.HTTP_200_OK)
+                team_dto.users = users if member else None
+            return Response(data=team_dto.model_dump(mode="json"), status=status.HTTP_200_OK)
         except ValueError as e:
             fallback_response = ApiErrorResponse(
                 statusCode=404,