tests: add tests for remove from team API (#271)

* feat(team): restrict member removal to admins and reassign tasks

- enforce auth so only admins can remove another member
- automatically remove user roles on removal
- reassign all non-DONE tasks of the removed user to the team
- add audit log entry for task reassignment

* feat(remove-member): resolve comments by bot

* feat(remove-member): instantiate the exception raised

- fix cannot remove error being shown for correct exception

* feat(remove-from-team): sync changes for task assignment to postgres

- update postgres model for audit log to include task_count

* feat(remove-member): update cannot remove POC exception message
- fix formatting

* feat(remove-member-from-team): handle mixed ObjectId and string types in task reassignment

- Moves service imports to the top level in `team_service.py` for better code organization.
- Modifies the `update_many` call in `task_assignment_repository.py` to use the `$in` operator. This ensures that `assignee_id` and `team_id` can be matched regardless of whether they are stored as ObjectIds or strings, preventing potential issues when deactivating task assignments during member removal.

* feat(remove-member-from-team): move UserTeamDetailsRepository to the
function

* feat(remove-from-team): set updated_by to None in the ops for task
assignment creation in reassign_tasks_from_user_to_team

- fix formatting issues

* test(remove-member): add tests for remove_member_from_team

* test(remove-member): move import to function

* feat(remove-member): move task_reassignment function in transaction

- add team exception in views
- add assigned_from and assigned_to to audit log

* feat(remove-member): fix formatting issues

* feat(remove-from-team): include is_active in unique constraint to prevent sync failures

* feat(remove-from-team): remove unecessary comments

- fix bug where done tasks were also being reassigned
- fix bug where in postgres_user_role where data sync failed if a user
  was removed and added more than once
- updated reassigned tasks status and add sync to postgres db

* feat(remove-from-member): add serializer for path params validation

* feat(remove-from-team): removed aggregation pipeline and use normal db
queries

* feat(remove-from-todo): remove unecessary migration files

* feat(remove-from-team): remove task_count field from audit log model

* feat(remove-from-team): fix bug where reassigned todos not showing on
poc dashboard

* feat(remove-from-team): move remove role and validation to individual
function

* feat(remove-from-team): fix formatting issues

* feat(remove-from-team): use bool return value instead of count for task reassignment function

* feat(remove-from-team): update test cases for changed implementation

* test(remove-from-team): remove unnecssary setup values

Author: Hariom01010

todo/tests/unit/services/test_team_service.py

@@ -2,30 +2,58 @@
 from unittest.mock import patch
 from datetime import datetime, timezone
 
+from todo.exceptions.team_exceptions import (
+    CannotRemoveOwnerException,
+    CannotRemoveTeamPOCException,
+    NotTeamAdminException,
+)
 from todo.services.team_service import TeamService
 from todo.dto.responses.get_user_teams_response import GetUserTeamsResponse
 from todo.models.team import TeamModel, UserTeamDetailsModel
 from todo.models.common.pyobjectid import PyObjectId
+from todo.dto.user_dto import UserDTO
+from todo.dto.team_dto import TeamDTO
 
 
 class TeamServiceTests(TestCase):
     def setUp(self):
         self.user_id = "507f1f77bcf86cd799439011"
         self.team_id = "507f1f77bcf86cd799439012"
-
+        self.poc_id = "507f1f77bcf86cd799439014"
+        self.admin_id = "507f1f77bcf86cd799439015"
+        self.member_id = "507f1f77bcf86cd799439016"
         # Mock team model
         self.team_model = TeamModel(
             id=PyObjectId(self.team_id),
             name="Test Team",
             description="Test Description",
-            poc_id=PyObjectId(self.user_id),
+            poc_id=PyObjectId(self.poc_id),
             invite_code="TEST123",
             created_by=PyObjectId(self.user_id),
             updated_by=PyObjectId(self.user_id),
             created_at=datetime.now(timezone.utc),
             updated_at=datetime.now(timezone.utc),
         )
 
+        self.user_details = [
+            UserDTO(id=self.user_id, name="Test User 1", addedOn=datetime.now(timezone.utc), tasksAssignedCount=2),
+            UserDTO(id=self.poc_id, name="Test User 2", addedOn=datetime.now(timezone.utc), tasksAssignedCount=1),
+            UserDTO(id=self.admin_id, name="Test User 3", addedOn=datetime.now(timezone.utc), tasksAssignedCount=2),
+            UserDTO(id=self.member_id, name="Test User 4", addedOn=datetime.now(timezone.utc), tasksAssignedCount=1),
+        ]
+
+        self.team_details = TeamDTO(
+            id=self.team_id,
+            name="Test Team",
+            description="Test Description",
+            poc_id=self.poc_id,
+            invite_code="TEST123",
+            created_by=self.user_id,
+            updated_by=self.user_id,
+            created_at=datetime.now(timezone.utc),
+            updated_at=datetime.now(timezone.utc),
+        )
+
         # Mock user team details model
         self.user_team_details = UserTeamDetailsModel(
             id=PyObjectId("507f1f77bcf86cd799439013"),
@@ -185,3 +213,90 @@ def test_join_team_by_invite_code_already_member(self, mock_get_by_user_id, mock
         with self.assertRaises(ValueError) as context:
             TeamService.join_team_by_invite_code("TEST123", self.user_id)
         self.assertIn("already a member", str(context.exception))
+
+    @patch("todo.services.user_service.UserService.get_users_by_team_id")
+    @patch("todo.services.team_service.TeamService.get_team_by_id")
+    def test_cannot_remove_owner(self, mock_get_by_team_id, mock_get_users_by_team_id):
+        """Test cannot remove team owner"""
+        mock_get_users_by_team_id.return_value = self.user_details
+        mock_get_by_team_id.return_value = self.team_details
+        with self.assertRaises(CannotRemoveOwnerException):
+            TeamService._validate_remove_member_permissions(self.user_id, self.team_id, self.user_id)
+
+    @patch("todo.services.user_service.UserService.get_users_by_team_id")
+    @patch("todo.services.team_service.TeamService.get_team_by_id")
+    def test_cannot_remove_poc(self, mock_get_by_team_id, mock_get_users_by_team_id):
+        """Test cannot remove team POC"""
+        mock_get_users_by_team_id.return_value = self.user_details
+        mock_get_by_team_id.return_value = self.team_details
+
+        with self.assertRaises(CannotRemoveTeamPOCException):
+            TeamService._validate_remove_member_permissions(self.poc_id, self.team_id, self.user_id)
+
+    @patch("todo.services.user_service.UserService.get_users_by_team_id")
+    @patch("todo.services.team_service.TeamService.get_team_by_id")
+    def test_normal_member_cannot_remove_member(self, mock_get_by_team_id, mock_get_users_by_team_id):
+        mock_get_users_by_team_id.return_value = self.user_details
+        mock_get_by_team_id.return_value = self.team_details
+
+        with self.assertRaises(NotTeamAdminException):
+            TeamService._validate_remove_member_permissions(self.admin_id, self.team_id, self.member_id)
+
+    @patch("todo.services.user_service.UserService.get_users_by_team_id")
+    @patch("todo.services.team_service.TeamService.get_team_by_id")
+    def test_team_or_user_not_found(self, mock_get_by_team_id, mock_get_users_by_team_id):
+        mock_get_users_by_team_id.return_value = self.user_details
+        mock_get_by_team_id.return_value = self.team_details
+
+        with self.assertRaises(TeamService.TeamOrUserNotFound):
+            TeamService._validate_remove_member_permissions("not-existing-member", self.team_id, self.member_id)
+
+    @patch("todo.services.task_assignment_service.TaskAssignmentService.reassign_tasks_from_user_to_team")
+    @patch("todo.services.user_role_service.UserRoleService.remove_all_user_roles_for_team")
+    @patch("todo.repositories.audit_log_repository.AuditLogRepository.create")
+    @patch("todo.repositories.user_team_details_repository.UserTeamDetailsRepository.remove_member_from_team")
+    @patch("todo.services.team_service.TeamService._validate_remove_member_permissions")
+    def test_admin_can_remove_member_successfully(
+        self, mock_validate, mock_remove_member, mock_audit_log_create, mock_remove_roles, mock_reassign_tasks
+    ):
+        mock_validate.return_value = None
+        mock_remove_member.return_value = True
+        mock_remove_roles.return_value = True
+        mock_reassign_tasks.return_value = True
+
+        result = TeamService.remove_member_from_team(self.member_id, self.team_id, self.admin_id)
+
+        self.assertTrue(result)
+        mock_remove_member.assert_called_once_with(user_id=self.member_id, team_id=self.team_id)
+        mock_remove_roles.assert_called_once()
+        mock_reassign_tasks.assert_called_once()
+        mock_audit_log_create.assert_called_once()
+        log_entry = mock_audit_log_create.call_args[0][0]
+        self.assertEqual(log_entry.action, "member_removed_from_team")
+        self.assertEqual(str(log_entry.team_id), self.team_id)
+        self.assertEqual(str(log_entry.performed_by), self.admin_id)
+
+    @patch("todo.services.task_assignment_service.TaskAssignmentService.reassign_tasks_from_user_to_team")
+    @patch("todo.services.user_role_service.UserRoleService.remove_all_user_roles_for_team")
+    @patch("todo.repositories.audit_log_repository.AuditLogRepository.create")
+    @patch("todo.repositories.user_team_details_repository.UserTeamDetailsRepository.remove_member_from_team")
+    @patch("todo.services.team_service.TeamService._validate_remove_member_permissions")
+    def test_user_can_remove_themselves(
+        self, mock_validate, mock_remove_member, mock_audit_log_create, mock_remove_roles, mock_reassign_tasks
+    ):
+        mock_validate.return_value = None
+        mock_remove_member.return_value = True
+        mock_remove_roles.return_value = True
+        mock_reassign_tasks.return_value = True
+
+        result = TeamService.remove_member_from_team(self.member_id, self.team_id, self.member_id)
+
+        self.assertTrue(result)
+        mock_remove_member.assert_called_once_with(user_id=self.member_id, team_id=self.team_id)
+        mock_remove_roles.assert_called_once_with(self.member_id, self.team_id)
+        mock_reassign_tasks.assert_called_once_with(self.member_id, self.team_id, self.member_id)
+        mock_audit_log_create.assert_called_once()
+        log_entry = mock_audit_log_create.call_args[0][0]
+        self.assertEqual(log_entry.action, "member_left_team")
+        self.assertEqual(str(log_entry.team_id), self.team_id)
+        self.assertEqual(str(log_entry.performed_by), self.member_id)