feat(remove-from-member): add serializer for path params validation

Author: Hariom01010

todo/serializers/remove_from_team_serializer.py

@@ -0,0 +1,18 @@
+from rest_framework import serializers
+from bson import ObjectId
+from todo.constants.messages import ValidationErrors
+
+
+class RemoveFromTeamSerializer(serializers.Serializer):
+    team_id = serializers.CharField()
+    user_id = serializers.CharField()
+
+    def validate_team_id(self, value):
+        if not ObjectId.is_valid(value):
+            raise serializers.ValidationError(ValidationErrors.INVALID_OBJECT_ID.format(value))
+        return value
+
+    def validate_user_id(self, value):
+        if not ObjectId.is_valid(value):
+            raise serializers.ValidationError(ValidationErrors.INVALID_OBJECT_ID.format(value))
+        return value

todo/views/team.py

@@ -27,6 +27,7 @@
     CannotRemoveOwnerException,
     CannotRemoveTeamPOCException,
 )
+from todo.serializers.remove_from_team_serializer import RemoveFromTeamSerializer
 
 
 class TeamListView(APIView):
@@ -476,10 +477,37 @@ class RemoveTeamMemberView(APIView):
         },
         tags=["teams"],
     )
+    def _handle_validation_errors(self, errors):
+        """Handle validation errors and return appropriate response."""
+        formatted = []
+        for field, msgs in errors.items():
+            for msg in msgs:
+                formatted.append(
+                    {
+                        "source": field,
+                        "title": "Invalid value",
+                        "detail": str(msg),
+                    }
+                )
+        return Response(
+            {
+                "statusCode": 400,
+                "message": "Validation Error",
+                "errors": formatted,
+                "authenticated": getattr(self.request, "user", None) is not None,
+            },
+            status=400,
+        )
+
     def delete(self, request, team_id, user_id):
         print(f"DEBUG: RemoveTeamMemberView.delete called with team_id={team_id}, user_id={user_id}")
         from todo.services.team_service import TeamService
 
+        serializer = RemoveFromTeamSerializer(data={"team_id": team_id, "user_id": user_id})
+
+        if not serializer.is_valid():
+            return self._handle_validation_errors(serializer.errors)
+
         try:
             # Pass the user performing the removal (request.user_id) and the user being removed (user_id)
             TeamService.remove_member_from_team(user_id=user_id, team_id=team_id, removed_by_user_id=request.user_id)