Skip to content

Commit e89ce55

Browse files
feat: refactor user retrieval in team detail view to improve readability (#152)
Co-authored-by: Amit Prakash <[email protected]>
1 parent 5064ad9 commit e89ce55

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

todo/services/user_service.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,15 @@ def get_users_by_ids(cls, user_ids: list[str]) -> list[UserDTO]:
4242
for user_id in user_ids:
4343
user = UserRepository.get_by_id(user_id)
4444
if user:
45-
users.append(UserDTO(
46-
id=str(user.id),
47-
name=user.name,
48-
email_id=user.email_id,
49-
created_at=user.created_at,
50-
updated_at=user.updated_at,
51-
))
45+
users.append(
46+
UserDTO(
47+
id=str(user.id),
48+
name=user.name,
49+
email_id=user.email_id,
50+
created_at=user.created_at,
51+
updated_at=user.updated_at,
52+
)
53+
)
5254
return users
5355

5456
@classmethod

todo/views/team.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ def get(self, request: Request, team_id: str):
131131
member = request.query_params.get("member", "false").lower() == "true"
132132
if member:
133133
from todo.repositories.team_repository import UserTeamDetailsRepository
134+
134135
user_ids = UserTeamDetailsRepository.get_users_by_team_id(team_id)
135136
users = UserService.get_users_by_ids(user_ids)
136137
return Response(data=[user.model_dump(mode="json") for user in users], status=status.HTTP_200_OK)

0 commit comments

Comments
 (0)